Record completions snippets #900

gdevanla · 2020-11-09T13:47:47Z

This PR addresses the issue in haskell/haskell-language-server#333.

gdevanla · 2020-11-09T13:53:31Z

src/Development/IDE/Plugin/Completions/Logic.hs

 ppr :: Outputable a => a -> T.Text
 ppr = T.pack . prettyPrint

 newtype WithSnippets = WithSnippets Bool

 toggleSnippets :: ClientCapabilities -> WithSnippets -> CompletionItem -> CompletionItem
 toggleSnippets ClientCapabilities { _textDocument } (WithSnippets with) x
-  | with && supported = x
+  | with || supported = x


Note that I had to make this change to let snippets show up. I think we need to make a more relevant change to the code

ghcide/src/Development/IDE/Plugin/Completions.hs

Lines 134 to 135 in dcf6804

let fakeClientCapabilities = ClientCapabilities Nothing Nothing Nothing Nothing

Completions . List <$> getCompletions ideOpts cci' parsedMod bindMap pfix' fakeClientCapabilities (WithSnippets True)

Ugh, we need to clean up this code. I think it was copy-pasted from haskell-ide-engine and originally written a rather long time ago. I'll clean it if you don't get there first

wz1000 · 2020-11-10T12:56:38Z

How do I add tests that test non-local record definitions and completions. Please could you point to places where I can look for some examples of those.

See https://github.com/haskell/ghcide/blob/master/test/exe/Main.hs#L2662

How does one go about debugging/printing things inside ghcide

You can use the logging mechanism, Debug.Trace or just hPutStrLn stderr, whichever is convenient.

gdevanla · 2020-11-14T01:00:21Z

How do I add tests that test non-local record definitions and completions. Please could you point to places where I can look for some examples of those.

See https://github.com/haskell/ghcide/blob/master/test/exe/Main.hs#L2662

How does one go about debugging/printing things inside ghcide

You can use the logging mechanism, Debug.Trace or just hPutStrLn stderr, whichever is convenient.

@wz1000 So, I used trace inside say findRecordCompl and ran tests. i did not see any output. i also ran the code through hls and still did not see any output in hls.log. Does the output get written to some temp file? I cannot see any output on the terminal. What would be a typical workflow to print and debug stuff? Or should I wrap this functions in IO to see the trace statements?

Appreciate your help!

pepeiborra · 2020-11-14T09:25:20Z

For tests, check the lsp-test haddocks. By default stderr is not echoed and you need to change the settings or define an env var

For hls, I don't know how the log file works. I usually find stderr is logged to the haskell Output window in VSCode

For ghcide, the stderr is logged to the ghcide output window in VSCode

…ist.

gdevanla · 2020-11-14T19:13:25Z

Thanks @pepeiborra. I will explore those options. For now, I was able to figure out what was happening by just staring at the code!

I managed to add tests (also had to extend completionTest to compare the insertText).

One test I would like to add and which I am not able to figure out is, declare a Record in one module, and check if snippet gets generated in another module. I see 2 options.

Have a test declare 2 modules and then create a test. (by importing the record from one module onto another)
If there an record in standard haskell library(like Data.List, say), then I can use that in tests. That way I do not have to declare an separate module. I looked around but failed.

wz1000 · 2020-11-14T19:18:17Z

If there an record in standard haskell library(like Data.List, say), then I can use that in tests. That way I do not have to declare an separate module. I looked around but failed.

How about this? https://hackage.haskell.org/package/base-4.14.0.0/docs/Text-Printf.html#t:FieldFormat

gdevanla · 2020-11-14T22:02:22Z

Thanks, @wz1000. I was able to use examples from that module to add the tests I wanted.

gdevanla · 2020-11-17T14:17:37Z

Looks like this failure is because earlier version do not have this type: https://github.com/haskell/ghcide/pull/900/checks?check_run_id=1402628784.

src/Development/IDE/Plugin/Completions/Logic.hs:397:79: error:
    Not in scope: type constructor or class ‘SrcSpanLess’
    |
397 |         getFlds :: HsConDetails arg (Located [LConDeclField GhcPs]) -> Maybe [SrcSpanLess (LConDeclField GhcPs)]
    |                                                                               ^^^^^^^^^^^
cabal: Failed to build ghcide-0.5.0 (which is required by bench:benchHist from
ghcide-0.5.0).

Please can I have some suggestions on how to fix this in prior versions?

wz1000 · 2020-11-17T14:21:06Z

Use ConDeclField instead of SrcSpanLess LConDeclField

gdevanla · 2020-11-17T14:21:20Z

Also, I am a not able to address this hlint failure.

https://dev.azure.com/digitalasset/ghcide/_build/results?buildId=60930&view=logs&j=8c509560-e3d6-573f-8a24-ae9e290d8e4f&t=fdec7397-253f-5ca6-ce5e-10d811d2034a&l=16

src/Development/IDE/Plugin/Completions/Logic.hs:271:10-26: Suggestion: Use tuple-section
Found:
  \ x -> (x, mempty)
Perhaps:
  (, mempty)
Note: may require `{-# LANGUAGE TupleSections #-}` adding to the top of the file

When I use this suggestion, then I get a hlint warning regarding use of TupleSections, which seems circular.

wz1000 · 2020-11-17T14:23:26Z

You don't need to add TupleSections, it is already enabled in default-extensions.

gdevanla

I think I have addressed all the requested changes.

I am happy to recieve further suggestions on improving how I implemented the list comprehension logic in findCompletions.

src/Development/IDE/Plugin/Completions/Logic.hs

pepeiborra

Many thanks for incorporating the feedback, this is ready to merge now

src/Development/IDE/Plugin/Completions/Logic.hs

Restored from haskell#900

* Use the real client capabilities on completions * Return completion snippets only when supported by the client Restored from #900

* Add field for RecordSnippets to CachcedCompletion * Initial version of local record snippets * Supprt record snippet completion for non local declarations. * Better integration of local completions with current implementation * Clean up non-local completions. * Remove commented code. * Switch from String to Text * Remove ununsed definition * Treat only Records and leave other defintions as is. * Differentiate Records from Data constructors for external declaration * Update test to include snippet in local record completions expected list. * Update completionTest to also compare insertText. * Add test for record snippet completion for imported records. * Hlint fixes * Hlint fixes * Hlint suggestions. * Update type. * Consolidate imports * Unpack tuple with explicit names * Idiomatic changes * Remove unused variable * Better variable name * Hlint suggestions * Handle exhaustive pattern warning * Add _ to snippet field name suggestions * Remove type information passed around but not used * Update to list comprehension style * Eliminate intermediate function * HLint suggestions. * Idiomatic list comprehension Co-authored-by: Pepe Iborra <pepeiborra@me.com>

* Use the real client capabilities on completions * Return completion snippets only when supported by the client Restored from haskell#900

* Move tracing functions to own module * Bump opentelemetry to 0.6.0 * Write Values map size to OpenTelemetry metric * Trace all requests and notifications Instead of doing it in `HoverDefinition`, do it in with{Response,Notification,...}. These wrap all handlers, so this should cover everything. It also means that the span covers the entire processing time for the request, where before we missed the setup happening in the with* functions. * Add flag for OpenTelemetry profiling Run GC regularly with --ot-profiling * Add flag to enable OT profiling in benchmark * Use heapsize instead of ghc-datasize I renamed the fork to distringuish from the original. It is still being pulled from git using stack. This will be addressed once I can push the fork to hackage. * Bump opentelemetry to 0.6.1 - fixes 8.6 build * Use heapsize from hackage * Address HLint messages * Record size of each key independently * Refactor `startTelemetry` function * Remove delay between measuring memory loops * Each key in values map gets own OT instrument * Measure values map length more rarely * Rename --ot-profiling to --ot-memory-profiling * Add docs for how to use the opentelemetry output * Add instructions to build release version of tracy * Clarify dependencies in opentelemetry instructions * Fix LSP traces * otTraced: delete unused * Extract types out of D.IDE.Core.Shake to avoid circular module dependencies * Extract startTelemetry out of D.IDE.Shake and upgrade to 0.2 No more segfaults * [nix] install opentelemetry * [nix] install tracy * Fix merge wibble * Measure recursive sizes with sharing * Sort keys for cost attribution * Remove debug traces * Allocate less, group keys, clean up hlints * Add -A4G to the flags used for --ot-memory-profiling * Modularize D.IDE.Core.Tracing I want to reuse this code more directly in the non lsp driver * Direct driver: report closure sizes when --ot-memory-profiling An eventlog memory analysis doesnt' seem so relevant since this mode is not interactive, but we could easily produce both if wanted to * Everything is reachable from GhcSessionIO, so compute it last I suspect the ShakeExtras record is reachable from GhcSessionIO * bound recursion and use logger * hlint suggestions * Fix 8.6 build * Format imports * Do the memory analysis with full sharing. GhcSessionIO last * Fail fast in the memory analysis * error handling * runHeapsize now takes initSize as an input argument * Trace Shake sessions * Reduced frequency for sampling values length * Drop the -fexternal-interpreter flag in the Windows stack build * Produce more benchmark artifacts * Fix stack descriptors to use heapsize-0.2 from Hackage * Bump to heapsize-0.3.0 * Record completions snippets (#900) * Add field for RecordSnippets to CachcedCompletion * Initial version of local record snippets * Supprt record snippet completion for non local declarations. * Better integration of local completions with current implementation * Clean up non-local completions. * Remove commented code. * Switch from String to Text * Remove ununsed definition * Treat only Records and leave other defintions as is. * Differentiate Records from Data constructors for external declaration * Update test to include snippet in local record completions expected list. * Update completionTest to also compare insertText. * Add test for record snippet completion for imported records. * Hlint fixes * Hlint fixes * Hlint suggestions. * Update type. * Consolidate imports * Unpack tuple with explicit names * Idiomatic changes * Remove unused variable * Better variable name * Hlint suggestions * Handle exhaustive pattern warning * Add _ to snippet field name suggestions * Remove type information passed around but not used * Update to list comprehension style * Eliminate intermediate function * HLint suggestions. * Idiomatic list comprehension Co-authored-by: Pepe Iborra <pepeiborra@me.com> * [nix] use gitignore.nix (#920) * Ignore import list while producing completions (#919) * Drop any items in explicit import list * Test if imports not included in explicit list show up in completions * Update README.md (#924) * Custom cradle loading (#928) When using ghcide as a library, it may be desirable to host the hie.yaml file in a location other than the project root, or even avoid the file system altogether * Favor `lookupPathToId` over `pathToId` (#926) * Favor `lookupPathToId` over `pathToId` * Fix `typecheckParentsAction` * Fix `needsCompilationRule` * Return completion snippets only when client supports it (#929) * Use the real client capabilities on completions * Return completion snippets only when supported by the client Restored from #900 * Redundant import * Fix stack windows build Co-authored-by: Michalis Pardalos <m.pardalos@gmail.com> Co-authored-by: Michalis Pardalos <mpardalos@gmail.com> Co-authored-by: Guru Devanla <gdevanla@users.noreply.github.com> Co-authored-by: Samuel Ainsworth <skainsworth@gmail.com>

* Add field for RecordSnippets to CachcedCompletion * Initial version of local record snippets * Supprt record snippet completion for non local declarations. * Better integration of local completions with current implementation * Clean up non-local completions. * Remove commented code. * Switch from String to Text * Remove ununsed definition * Treat only Records and leave other defintions as is. * Differentiate Records from Data constructors for external declaration * Update test to include snippet in local record completions expected list. * Update completionTest to also compare insertText. * Add test for record snippet completion for imported records. * Hlint fixes * Hlint fixes * Hlint suggestions. * Update type. * Consolidate imports * Unpack tuple with explicit names * Idiomatic changes * Remove unused variable * Better variable name * Hlint suggestions * Handle exhaustive pattern warning * Add _ to snippet field name suggestions * Remove type information passed around but not used * Update to list comprehension style * Eliminate intermediate function * HLint suggestions. * Idiomatic list comprehension Co-authored-by: Pepe Iborra <pepeiborra@me.com>

…de#929) * Use the real client capabilities on completions * Return completion snippets only when supported by the client Restored from haskell/ghcide#900

* Move tracing functions to own module * Bump opentelemetry to 0.6.0 * Write Values map size to OpenTelemetry metric * Trace all requests and notifications Instead of doing it in `HoverDefinition`, do it in with{Response,Notification,...}. These wrap all handlers, so this should cover everything. It also means that the span covers the entire processing time for the request, where before we missed the setup happening in the with* functions. * Add flag for OpenTelemetry profiling Run GC regularly with --ot-profiling * Add flag to enable OT profiling in benchmark * Use heapsize instead of ghc-datasize I renamed the fork to distringuish from the original. It is still being pulled from git using stack. This will be addressed once I can push the fork to hackage. * Bump opentelemetry to 0.6.1 - fixes 8.6 build * Use heapsize from hackage * Address HLint messages * Record size of each key independently * Refactor `startTelemetry` function * Remove delay between measuring memory loops * Each key in values map gets own OT instrument * Measure values map length more rarely * Rename --ot-profiling to --ot-memory-profiling * Add docs for how to use the opentelemetry output * Add instructions to build release version of tracy * Clarify dependencies in opentelemetry instructions * Fix LSP traces * otTraced: delete unused * Extract types out of D.IDE.Core.Shake to avoid circular module dependencies * Extract startTelemetry out of D.IDE.Shake and upgrade to 0.2 No more segfaults * [nix] install opentelemetry * [nix] install tracy * Fix merge wibble * Measure recursive sizes with sharing * Sort keys for cost attribution * Remove debug traces * Allocate less, group keys, clean up hlints * Add -A4G to the flags used for --ot-memory-profiling * Modularize D.IDE.Core.Tracing I want to reuse this code more directly in the non lsp driver * Direct driver: report closure sizes when --ot-memory-profiling An eventlog memory analysis doesnt' seem so relevant since this mode is not interactive, but we could easily produce both if wanted to * Everything is reachable from GhcSessionIO, so compute it last I suspect the ShakeExtras record is reachable from GhcSessionIO * bound recursion and use logger * hlint suggestions * Fix 8.6 build * Format imports * Do the memory analysis with full sharing. GhcSessionIO last * Fail fast in the memory analysis * error handling * runHeapsize now takes initSize as an input argument * Trace Shake sessions * Reduced frequency for sampling values length * Drop the -fexternal-interpreter flag in the Windows stack build * Produce more benchmark artifacts * Fix stack descriptors to use heapsize-0.2 from Hackage * Bump to heapsize-0.3.0 * Record completions snippets (haskell/ghcide#900) * Add field for RecordSnippets to CachcedCompletion * Initial version of local record snippets * Supprt record snippet completion for non local declarations. * Better integration of local completions with current implementation * Clean up non-local completions. * Remove commented code. * Switch from String to Text * Remove ununsed definition * Treat only Records and leave other defintions as is. * Differentiate Records from Data constructors for external declaration * Update test to include snippet in local record completions expected list. * Update completionTest to also compare insertText. * Add test for record snippet completion for imported records. * Hlint fixes * Hlint fixes * Hlint suggestions. * Update type. * Consolidate imports * Unpack tuple with explicit names * Idiomatic changes * Remove unused variable * Better variable name * Hlint suggestions * Handle exhaustive pattern warning * Add _ to snippet field name suggestions * Remove type information passed around but not used * Update to list comprehension style * Eliminate intermediate function * HLint suggestions. * Idiomatic list comprehension Co-authored-by: Pepe Iborra <pepeiborra@me.com> * [nix] use gitignore.nix (haskell/ghcide#920) * Ignore import list while producing completions (haskell/ghcide#919) * Drop any items in explicit import list * Test if imports not included in explicit list show up in completions * Update README.md (haskell/ghcide#924) * Custom cradle loading (haskell/ghcide#928) When using ghcide as a library, it may be desirable to host the hie.yaml file in a location other than the project root, or even avoid the file system altogether * Favor `lookupPathToId` over `pathToId` (haskell/ghcide#926) * Favor `lookupPathToId` over `pathToId` * Fix `typecheckParentsAction` * Fix `needsCompilationRule` * Return completion snippets only when client supports it (haskell/ghcide#929) * Use the real client capabilities on completions * Return completion snippets only when supported by the client Restored from haskell/ghcide#900 * Redundant import * Fix stack windows build Co-authored-by: Michalis Pardalos <m.pardalos@gmail.com> Co-authored-by: Michalis Pardalos <mpardalos@gmail.com> Co-authored-by: Guru Devanla <gdevanla@users.noreply.github.com> Co-authored-by: Samuel Ainsworth <skainsworth@gmail.com>

* Add field for RecordSnippets to CachcedCompletion * Initial version of local record snippets * Supprt record snippet completion for non local declarations. * Better integration of local completions with current implementation * Clean up non-local completions. * Remove commented code. * Switch from String to Text * Remove ununsed definition * Treat only Records and leave other defintions as is. * Differentiate Records from Data constructors for external declaration * Update test to include snippet in local record completions expected list. * Update completionTest to also compare insertText. * Add test for record snippet completion for imported records. * Hlint fixes * Hlint fixes * Hlint suggestions. * Update type. * Consolidate imports * Unpack tuple with explicit names * Idiomatic changes * Remove unused variable * Better variable name * Hlint suggestions * Handle exhaustive pattern warning * Add _ to snippet field name suggestions * Remove type information passed around but not used * Update to list comprehension style * Eliminate intermediate function * HLint suggestions. * Idiomatic list comprehension Co-authored-by: Pepe Iborra <pepeiborra@me.com>

…de#929) * Use the real client capabilities on completions * Return completion snippets only when supported by the client Restored from haskell/ghcide#900

* Move tracing functions to own module * Bump opentelemetry to 0.6.0 * Write Values map size to OpenTelemetry metric * Trace all requests and notifications Instead of doing it in `HoverDefinition`, do it in with{Response,Notification,...}. These wrap all handlers, so this should cover everything. It also means that the span covers the entire processing time for the request, where before we missed the setup happening in the with* functions. * Add flag for OpenTelemetry profiling Run GC regularly with --ot-profiling * Add flag to enable OT profiling in benchmark * Use heapsize instead of ghc-datasize I renamed the fork to distringuish from the original. It is still being pulled from git using stack. This will be addressed once I can push the fork to hackage. * Bump opentelemetry to 0.6.1 - fixes 8.6 build * Use heapsize from hackage * Address HLint messages * Record size of each key independently * Refactor `startTelemetry` function * Remove delay between measuring memory loops * Each key in values map gets own OT instrument * Measure values map length more rarely * Rename --ot-profiling to --ot-memory-profiling * Add docs for how to use the opentelemetry output * Add instructions to build release version of tracy * Clarify dependencies in opentelemetry instructions * Fix LSP traces * otTraced: delete unused * Extract types out of D.IDE.Core.Shake to avoid circular module dependencies * Extract startTelemetry out of D.IDE.Shake and upgrade to 0.2 No more segfaults * [nix] install opentelemetry * [nix] install tracy * Fix merge wibble * Measure recursive sizes with sharing * Sort keys for cost attribution * Remove debug traces * Allocate less, group keys, clean up hlints * Add -A4G to the flags used for --ot-memory-profiling * Modularize D.IDE.Core.Tracing I want to reuse this code more directly in the non lsp driver * Direct driver: report closure sizes when --ot-memory-profiling An eventlog memory analysis doesnt' seem so relevant since this mode is not interactive, but we could easily produce both if wanted to * Everything is reachable from GhcSessionIO, so compute it last I suspect the ShakeExtras record is reachable from GhcSessionIO * bound recursion and use logger * hlint suggestions * Fix 8.6 build * Format imports * Do the memory analysis with full sharing. GhcSessionIO last * Fail fast in the memory analysis * error handling * runHeapsize now takes initSize as an input argument * Trace Shake sessions * Reduced frequency for sampling values length * Drop the -fexternal-interpreter flag in the Windows stack build * Produce more benchmark artifacts * Fix stack descriptors to use heapsize-0.2 from Hackage * Bump to heapsize-0.3.0 * Record completions snippets (haskell/ghcide#900) * Add field for RecordSnippets to CachcedCompletion * Initial version of local record snippets * Supprt record snippet completion for non local declarations. * Better integration of local completions with current implementation * Clean up non-local completions. * Remove commented code. * Switch from String to Text * Remove ununsed definition * Treat only Records and leave other defintions as is. * Differentiate Records from Data constructors for external declaration * Update test to include snippet in local record completions expected list. * Update completionTest to also compare insertText. * Add test for record snippet completion for imported records. * Hlint fixes * Hlint fixes * Hlint suggestions. * Update type. * Consolidate imports * Unpack tuple with explicit names * Idiomatic changes * Remove unused variable * Better variable name * Hlint suggestions * Handle exhaustive pattern warning * Add _ to snippet field name suggestions * Remove type information passed around but not used * Update to list comprehension style * Eliminate intermediate function * HLint suggestions. * Idiomatic list comprehension Co-authored-by: Pepe Iborra <pepeiborra@me.com> * [nix] use gitignore.nix (haskell/ghcide#920) * Ignore import list while producing completions (haskell/ghcide#919) * Drop any items in explicit import list * Test if imports not included in explicit list show up in completions * Update README.md (haskell/ghcide#924) * Custom cradle loading (haskell/ghcide#928) When using ghcide as a library, it may be desirable to host the hie.yaml file in a location other than the project root, or even avoid the file system altogether * Favor `lookupPathToId` over `pathToId` (haskell/ghcide#926) * Favor `lookupPathToId` over `pathToId` * Fix `typecheckParentsAction` * Fix `needsCompilationRule` * Return completion snippets only when client supports it (haskell/ghcide#929) * Use the real client capabilities on completions * Return completion snippets only when supported by the client Restored from haskell/ghcide#900 * Redundant import * Fix stack windows build Co-authored-by: Michalis Pardalos <m.pardalos@gmail.com> Co-authored-by: Michalis Pardalos <mpardalos@gmail.com> Co-authored-by: Guru Devanla <gdevanla@users.noreply.github.com> Co-authored-by: Samuel Ainsworth <skainsworth@gmail.com>

* Add field for RecordSnippets to CachcedCompletion * Initial version of local record snippets * Supprt record snippet completion for non local declarations. * Better integration of local completions with current implementation * Clean up non-local completions. * Remove commented code. * Switch from String to Text * Remove ununsed definition * Treat only Records and leave other defintions as is. * Differentiate Records from Data constructors for external declaration * Update test to include snippet in local record completions expected list. * Update completionTest to also compare insertText. * Add test for record snippet completion for imported records. * Hlint fixes * Hlint fixes * Hlint suggestions. * Update type. * Consolidate imports * Unpack tuple with explicit names * Idiomatic changes * Remove unused variable * Better variable name * Hlint suggestions * Handle exhaustive pattern warning * Add _ to snippet field name suggestions * Remove type information passed around but not used * Update to list comprehension style * Eliminate intermediate function * HLint suggestions. * Idiomatic list comprehension Co-authored-by: Pepe Iborra <pepeiborra@me.com>

…de#929) * Use the real client capabilities on completions * Return completion snippets only when supported by the client Restored from haskell/ghcide#900

* Move tracing functions to own module * Bump opentelemetry to 0.6.0 * Write Values map size to OpenTelemetry metric * Trace all requests and notifications Instead of doing it in `HoverDefinition`, do it in with{Response,Notification,...}. These wrap all handlers, so this should cover everything. It also means that the span covers the entire processing time for the request, where before we missed the setup happening in the with* functions. * Add flag for OpenTelemetry profiling Run GC regularly with --ot-profiling * Add flag to enable OT profiling in benchmark * Use heapsize instead of ghc-datasize I renamed the fork to distringuish from the original. It is still being pulled from git using stack. This will be addressed once I can push the fork to hackage. * Bump opentelemetry to 0.6.1 - fixes 8.6 build * Use heapsize from hackage * Address HLint messages * Record size of each key independently * Refactor `startTelemetry` function * Remove delay between measuring memory loops * Each key in values map gets own OT instrument * Measure values map length more rarely * Rename --ot-profiling to --ot-memory-profiling * Add docs for how to use the opentelemetry output * Add instructions to build release version of tracy * Clarify dependencies in opentelemetry instructions * Fix LSP traces * otTraced: delete unused * Extract types out of D.IDE.Core.Shake to avoid circular module dependencies * Extract startTelemetry out of D.IDE.Shake and upgrade to 0.2 No more segfaults * [nix] install opentelemetry * [nix] install tracy * Fix merge wibble * Measure recursive sizes with sharing * Sort keys for cost attribution * Remove debug traces * Allocate less, group keys, clean up hlints * Add -A4G to the flags used for --ot-memory-profiling * Modularize D.IDE.Core.Tracing I want to reuse this code more directly in the non lsp driver * Direct driver: report closure sizes when --ot-memory-profiling An eventlog memory analysis doesnt' seem so relevant since this mode is not interactive, but we could easily produce both if wanted to * Everything is reachable from GhcSessionIO, so compute it last I suspect the ShakeExtras record is reachable from GhcSessionIO * bound recursion and use logger * hlint suggestions * Fix 8.6 build * Format imports * Do the memory analysis with full sharing. GhcSessionIO last * Fail fast in the memory analysis * error handling * runHeapsize now takes initSize as an input argument * Trace Shake sessions * Reduced frequency for sampling values length * Drop the -fexternal-interpreter flag in the Windows stack build * Produce more benchmark artifacts * Fix stack descriptors to use heapsize-0.2 from Hackage * Bump to heapsize-0.3.0 * Record completions snippets (haskell/ghcide#900) * Add field for RecordSnippets to CachcedCompletion * Initial version of local record snippets * Supprt record snippet completion for non local declarations. * Better integration of local completions with current implementation * Clean up non-local completions. * Remove commented code. * Switch from String to Text * Remove ununsed definition * Treat only Records and leave other defintions as is. * Differentiate Records from Data constructors for external declaration * Update test to include snippet in local record completions expected list. * Update completionTest to also compare insertText. * Add test for record snippet completion for imported records. * Hlint fixes * Hlint fixes * Hlint suggestions. * Update type. * Consolidate imports * Unpack tuple with explicit names * Idiomatic changes * Remove unused variable * Better variable name * Hlint suggestions * Handle exhaustive pattern warning * Add _ to snippet field name suggestions * Remove type information passed around but not used * Update to list comprehension style * Eliminate intermediate function * HLint suggestions. * Idiomatic list comprehension Co-authored-by: Pepe Iborra <pepeiborra@me.com> * [nix] use gitignore.nix (haskell/ghcide#920) * Ignore import list while producing completions (haskell/ghcide#919) * Drop any items in explicit import list * Test if imports not included in explicit list show up in completions * Update README.md (haskell/ghcide#924) * Custom cradle loading (haskell/ghcide#928) When using ghcide as a library, it may be desirable to host the hie.yaml file in a location other than the project root, or even avoid the file system altogether * Favor `lookupPathToId` over `pathToId` (haskell/ghcide#926) * Favor `lookupPathToId` over `pathToId` * Fix `typecheckParentsAction` * Fix `needsCompilationRule` * Return completion snippets only when client supports it (haskell/ghcide#929) * Use the real client capabilities on completions * Return completion snippets only when supported by the client Restored from haskell/ghcide#900 * Redundant import * Fix stack windows build Co-authored-by: Michalis Pardalos <m.pardalos@gmail.com> Co-authored-by: Michalis Pardalos <mpardalos@gmail.com> Co-authored-by: Guru Devanla <gdevanla@users.noreply.github.com> Co-authored-by: Samuel Ainsworth <skainsworth@gmail.com>

gdevanla added 8 commits November 8, 2020 07:17

Add field for RecordSnippets to CachcedCompletion

1b9103a

Initial version of local record snippets

1de81f4

Supprt record snippet completion for non local declarations.

03578ca

Better integration of local completions with current implementation

3b55262

Clean up non-local completions.

839be49

Remove commented code.

c39b414

Switch from String to Text

95445d7

Remove ununsed definition

7e9aa3e

gdevanla mentioned this pull request Nov 9, 2020

Record Snippets Completion haskell/haskell-language-server#512

Closed

5 tasks

gdevanla commented Nov 9, 2020

View reviewed changes

gdevanla added 4 commits November 14, 2020 09:14

Treat only Records and leave other defintions as is.

6cef4c0

Differentiate Records from Data constructors for external declaration

0fc96a2

Update test to include snippet in local record completions expected l…

9532e07

…ist.

Update completionTest to also compare insertText.

b2e2db5

Add test for record snippet completion for imported records.

7b44a3f

gdevanla added 3 commits November 14, 2020 21:59

Hlint fixes

47eeca6

Hlint fixes

5f47940

Merge branch 'master' into record-completions-snippets

50ad9d4

gdevanla added 2 commits November 17, 2020 06:25

Hlint suggestions.

fc6ae54

Update type.

d47aa1e

gdevanla added 10 commits November 22, 2020 16:15

Idiomatic changes

6a22391

Remove unused variable

6337fda

Better variable name

1b16782

Hlint suggestions

f4239b6

Handle exhaustive pattern warning

3e9d9e4

Add _ to snippet field name suggestions

ae0062e

Remove type information passed around but not used

99142ba

Update to list comprehension style

44521dc

Eliminate intermediate function

3349138

HLint suggestions.

d1eea8e

gdevanla commented Nov 23, 2020

View reviewed changes

pepeiborra reviewed Nov 23, 2020

View reviewed changes

src/Development/IDE/Plugin/Completions/Logic.hs Outdated Show resolved Hide resolved

Idiomatic list comprehension

a586a9a

pepeiborra approved these changes Nov 23, 2020

View reviewed changes

src/Development/IDE/Plugin/Completions/Logic.hs Show resolved Hide resolved

pepeiborra merged commit 0289917 into haskell:master Nov 23, 2020

pepeiborra added a commit to pepeiborra/ghcide that referenced this pull request Nov 29, 2020

Return completion snippets only when supported by the client

2302a43

Restored from haskell#900

pepeiborra mentioned this pull request Nov 29, 2020

Return completion snippets only when client supports it #929

Merged

pepeiborra added a commit that referenced this pull request Nov 29, 2020

Return completion snippets only when client supports it (#929)

dc3c104

* Use the real client capabilities on completions * Return completion snippets only when supported by the client Restored from #900

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Record completions snippets #900

Record completions snippets #900

gdevanla commented Nov 9, 2020 •

edited

Loading

gdevanla Nov 9, 2020

pepeiborra Nov 22, 2020

wz1000 commented Nov 10, 2020

gdevanla commented Nov 14, 2020 •

edited

Loading

pepeiborra commented Nov 14, 2020 •

edited

Loading

gdevanla commented Nov 14, 2020

wz1000 commented Nov 14, 2020 •

edited

Loading

gdevanla commented Nov 14, 2020 •

edited

Loading

gdevanla commented Nov 17, 2020 •

edited

Loading

wz1000 commented Nov 17, 2020

gdevanla commented Nov 17, 2020

wz1000 commented Nov 17, 2020

gdevanla left a comment

pepeiborra left a comment

	let fakeClientCapabilities = ClientCapabilities Nothing Nothing Nothing Nothing
	Completions . List <$> getCompletions ideOpts cci' parsedMod bindMap pfix' fakeClientCapabilities (WithSnippets True)

Record completions snippets #900

Record completions snippets #900

Conversation

gdevanla commented Nov 9, 2020 • edited Loading

gdevanla Nov 9, 2020

Choose a reason for hiding this comment

pepeiborra Nov 22, 2020

Choose a reason for hiding this comment

wz1000 commented Nov 10, 2020

gdevanla commented Nov 14, 2020 • edited Loading

pepeiborra commented Nov 14, 2020 • edited Loading

gdevanla commented Nov 14, 2020

wz1000 commented Nov 14, 2020 • edited Loading

gdevanla commented Nov 14, 2020 • edited Loading

gdevanla commented Nov 17, 2020 • edited Loading

wz1000 commented Nov 17, 2020

gdevanla commented Nov 17, 2020

wz1000 commented Nov 17, 2020

gdevanla left a comment

Choose a reason for hiding this comment

pepeiborra left a comment

Choose a reason for hiding this comment

gdevanla commented Nov 9, 2020 •

edited

Loading

gdevanla commented Nov 14, 2020 •

edited

Loading

pepeiborra commented Nov 14, 2020 •

edited

Loading

wz1000 commented Nov 14, 2020 •

edited

Loading

gdevanla commented Nov 14, 2020 •

edited

Loading

gdevanla commented Nov 17, 2020 •

edited

Loading