Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLS 2.9.0.0 #222

Closed
wants to merge 3 commits into from
Closed

HLS 2.9.0.0 #222

wants to merge 3 commits into from

Conversation

wz1000
Copy link
Collaborator

@wz1000 wz1000 commented Jun 18, 2024

No description provided.

@wz1000
Copy link
Collaborator Author

wz1000 commented Jun 18, 2024

@wz1000
Copy link
Collaborator Author

wz1000 commented Jun 18, 2024

@wz1000
Copy link
Collaborator Author

wz1000 commented Jun 18, 2024

@fendor
Copy link
Contributor

fendor commented Jun 18, 2024

Heyo!

So, this PR can't succeed as the CI runs HLS on the bytestring-0.11 codebase as a sanity check to make sure the binaries aren't completely busted from the start.

However, GHC 9.10 can't compile bytestring-0.11. Upgrading to bytestring-0.12 doesn't work, because it can't be compiled with GHC 9.2 on aarch systems.

I don't understand the debian 12 error, though.

@dfordivam
Copy link
Contributor

hi @fendor
Thanks for debugging the issue, it seems that bytestring-0.11.5.3 works with both 9.10 and 9.2.

@fendor
Copy link
Contributor

fendor commented Jun 18, 2024

For what it is worth, we changed the tests to run on text:Date.Text in the HLS repo.

@hasufell
Copy link
Member

Using newer bytestring-0.11 should work.

Note that I don't mind whether CI passes or not for vanilla channel.

@hasufell
Copy link
Member

Please don't merge via github interface.

Merge locally into develop. Then push to develop.

Then git push upstream develop:master.

@wz1000
Copy link
Collaborator Author

wz1000 commented Jun 18, 2024

@hasufell I don't have permissions to push to develop or master.

@hasufell
Copy link
Member

@hasufell I don't have permissions to push to develop or master.

Can you try again?

@wz1000 wz1000 closed this Jun 18, 2024
@dfordivam
Copy link
Contributor

or what it is worth, we changed the tests to run on text:Date.Text in the HLS repo.

well text has bytestring as a dep, so my intuition is it will not be any better than using bytestring, in the long run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants