-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable Mac build in GitHub Action #1219
enable Mac build in GitHub Action #1219
Conversation
Would someone with a Mac try https://github.com/haskell/hackage-server/actions/runs/5307816226/jobs/9606696192#step:6:27
|
I have asked if this might be in |
@peterbecich This should do it, --- a/flake.nix
+++ b/flake.nix
@@ -117,7 +117,7 @@
with pkgs;
[ cabal-install
ghc
-
+ ] ++ lib.optionals pkgs.stdenv.isLinux [
glibc
icu67
zlib |
Or better (to re-use haskell-flake's devShell): diff --git a/flake.nix b/flake.nix
index cbac13ae..59f149f3 100644
--- a/flake.nix
+++ b/flake.nix
@@ -113,11 +113,11 @@
# devShells.default =
# config.mission-control.installToDevShell self'.devShells.main;
devShells.default = pkgs.mkShell {
+ inputsFrom = [
+ config.haskellProjects.main.outputs.devShell
+ ];
buildInputs =
- with pkgs;
- [ cabal-install
- ghc
-
+ with pkgs; lib.optionals pkgs.stdenv.isLinux [
glibc
icu67
zlib
|
nix flake check
and Mac build in GitHub Action
Awesome, thank you @srid . I am going to merge this now so it caches, which should use fewer GitHub Actions minutes, and I will apply that fix in a subsequent PR |
#1193
nix flake check
restricted to current system in latest Nix version, so there should be no error "Mac required but I am a Linux", or vice versa