Space leaks #64
Merged
Space leaks #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Classic foldl with a lazy accumulator. Alternatively, the entire `indexInto` function could be replaced with `Data.List.elemIndex`.
Using a `foldr` to do a summation, resulting in a space leak. Fixed by switching to `foldl'` and then forcing the elements inside the pair.
simonmar
added a commit
that referenced
this pull request
May 16, 2016
Add a missing import following #64
erikd
pushed a commit
to erikd/happy
that referenced
this pull request
Sep 1, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two space leaks, squashed by using a strict accumulator.