Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop ghc support for 8.6.4, 8.10.2, 8.10.3, 8.10.4 #2197

Merged
merged 12 commits into from
Sep 17, 2021

Conversation

jneira
Copy link
Member

@jneira jneira commented Sep 16, 2021

  • Following the incoming ghc deprecation policy ghc support deprecation schedule #2168
  • Include the bump of ghc-lib* versions to 8.10.7 and the use of 8.10.7 in tests and benchmarks
  • Update hackage index to 2021-09-16T07:00:23Z

Copy link
Collaborator

@pepeiborra pepeiborra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@July541
Copy link
Collaborator

July541 commented Sep 16, 2021

Should we change the default stack.yaml(https://github.com/haskell/haskell-language-server/blob/master/stack.yaml) to 8.10.7?

@jneira jneira added the merge me Label to trigger pull request merge label Sep 16, 2021
@jneira
Copy link
Member Author

jneira commented Sep 16, 2021

Should we change the default stack.yaml(https://github.com/haskell/haskell-language-server/blob/master/stack.yaml) to 8.10.7?

good catch! i forgot to update it, thanks!

Copy link
Member

@Ailrun Ailrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! However, this PR cannot be automatically merged, as

  1. This PR changes CI config
  2. This PR adds/removes some CI entries, so branch protection rule should be updated

@jneira
Copy link
Member Author

jneira commented Sep 16, 2021

/rerun-workflow Testing

@jneira jneira merged commit 3bfb9b3 into haskell:master Sep 17, 2021
@jneira
Copy link
Member Author

jneira commented Sep 17, 2021

  • Changed branch protection rules, we have to update rest of prs
    EDIT: i've updated a bunch of them

@anka-213
Copy link
Contributor

anka-213 commented Sep 18, 2021

Is there any specific reason why 8.8.3 is still here? Will it be removed at a later point or is it meant to stay for longer or was it simply forgotten?

@jneira
Copy link
Member Author

jneira commented Sep 18, 2021

Is there any specific reason why 8.8.3 is still here? Will it be removed at a later point or is it meant to stay for longer or was it simply forgotten?

hi, we keep it following the deprecation policy discussed in #2168, it says we will keep the last 2 minor versions for relatively recent ghc versions

@anka-213
Copy link
Contributor

Ah, I see! I missed that part! Thanks!

@anka-213
Copy link
Contributor

I was looking at the table which said:

condition removed ghc versions supported ghc versions
after next release 1.4.0 with 8.10.7 8.10.4, 8.10.3, 8.10.2, 8.8.3, 8.6.4 9.0.1 (partial), 8.10.7, 8.10.6, 8.10.5, 8.8.4, 8.6.5

which is what confused me. (ghc-8.8.3 is under the removed section)

@jneira
Copy link
Member Author

jneira commented Sep 18, 2021

oh, yeah, that was the initial proposal but it has changed due the discussion, we have to write down the definitive one with a new table

cdsmith pushed a commit to cdsmith/haskell-language-server that referenced this pull request Sep 21, 2021
* Remove outdated setup troubleshooting

* Remove ghc-8.6.4 support

* Remove ghc-8.10.2 support

* Remove ghc-8.10.3 support

* Remove ghc-8.10.4 support

* Complete list of tested ghcs

* Update stack resolvers

* Update hackage index

* Set 8.10.7 as default stack.yaml

* Use extra 1.7.9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants