Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve the last empty comment line after eval plugin #631

Merged
merged 1 commit into from
Nov 27, 2020

Conversation

expipiplus1
Copy link
Contributor

-- >>> foo
--
-- >>> bar

After running the plugin on both prompts we end up with this:

-- >>> foo
-- foo_output
--
-- >>> bar
-- bar_output

instead of

-- >>> foo
-- foo_output
-- >>> bar
-- bar_output

```haskell
-- >>> foo
--
-- >>> bar
```

After running the plugin on both prompts we end up with this:

```haskell
-- >>> foo
-- foo_output
--
-- >>> bar
-- bar_output
```

instead of

```haskell
-- >>> foo
-- foo_output
-- >>> bar
-- bar_output
```
Copy link
Member

@Ailrun Ailrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please provide some rationals for this change?

@expipiplus1
Copy link
Contributor Author

Could you please provide some rationals for this change?

Sure, I often have code of the form

-- >>> doctest1
-- result
--
-- >>> doctest2
-- result2
myFunction :: _

When I use the eval plugin the pleasing space between the doctests is removed.

Copy link
Collaborator

@pepeiborra pepeiborra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pepeiborra pepeiborra merged commit d0fb85e into haskell:master Nov 27, 2020
@pepeiborra
Copy link
Collaborator

Thanks Joe!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants