Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language pragma snippet corrupts undo history #216

Closed
brandonw opened this issue Nov 22, 2013 · 7 comments
Closed

Language pragma snippet corrupts undo history #216

brandonw opened this issue Nov 22, 2013 · 7 comments
Assignees

Comments

@brandonw
Copy link
Contributor

If you do the initial expand of the lang snippet into {-# LANGUAGE #-} but then cancel the expansion before choosing the extension, your undo history will not contain the insertion of {-# LANGUAGE #-}.

It looks as if the text outputted from the snippet before the macro is invoked is somehow not added to the undo history. I tried putting the entire content of the snippet inside of the macro instead of just the extension, but that somehow adds a line break that is not added to the undo history instead.

@chrisdone
Copy link
Member

This is yasnippet?

@brandonw
Copy link
Contributor Author

Yes, it was. I haven't used emacs & haskell-mode in a while, so I'm not sure if this still exists.

@gracjan
Copy link
Contributor

gracjan commented Feb 26, 2015

Related #364, #305, #361.

@gracjan gracjan changed the title language pragma snippet corrupts undo history Language pragma snippet corrupts undo history Mar 9, 2015
@lukehoersten
Copy link
Member

This is still an issue and since this is my code I'll try to figure out what's going on.

@lukehoersten lukehoersten self-assigned this Apr 22, 2015
@lukehoersten
Copy link
Member

I have no idea why this is happening. @capitaomorte can you provide any insight here?

@joaotavora
Copy link

Undo support in yasnippet is finicky, but it should work. Can I see the snippet definition? Alternatively open related issue in yasnippet.

@lukehoersten
Copy link
Member

@capitaomorte https://github.com/haskell/haskell-snippets/blob/master/snippets/haskell-mode/lang-pragma

I'll wait to open a yasnippet issue until we've determined this isn't something I've caused.

@gracjan gracjan closed this as completed Aug 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants