Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the repository #6

Closed
jstolarek opened this issue May 6, 2015 · 5 comments
Closed

Clean up the repository #6

jstolarek opened this issue May 6, 2015 · 5 comments

Comments

@jstolarek
Copy link

Repository currently stores things that should not be there:

  • prototype versions of the library that have absolutely no practical use
  • source of the paper
  • response from reviewers (these should probably be never made public)
  • src directory stores some unused modules like Compiler.Hoopl.OldDataflow (perhaps some other as well?).

There are other files that might be good candidates for removal but need some more thinking before making such a decision:

  • various notes spread throughout source directories (src/LOOPS, src/Compiler/Hoopl/NOTES)
  • mkfiles - do we actually use them? If so, do they do anything that cannot be done using Cabal?
@mlite
Copy link
Contributor

mlite commented May 6, 2015

I support this cleanup. The documentation deserves its own repo. The current documentation is far from enough to support a wider adoption of hoopl. I had some thoughts about improving the documentation and will share them later.

@mlite
Copy link
Contributor

mlite commented May 6, 2015

mkfile was removed. It's no longer needed. All tests can be run with "cabal test"

michalt added a commit to michalt/hoopl that referenced this issue May 29, 2015
Most of the prototypes don't compile and keeping them in the
repository might be more confusing than helpful.
michalt added a commit to michalt/hoopl that referenced this issue May 29, 2015
It contained reviews from ICFP and POPL, which are not really useful
(at least now) and probably shouldn't have been made public in the
first place.
@lexpank
Copy link
Contributor

lexpank commented Dec 25, 2015

I've made some more cleanup, but I've got error while trying to push changes to branch:

remote: Permission to haskell/hoopl.git denied to AlexanderPankiv.
fatal: unable to access 'https://github.com/haskell/hoopl/': The requested URL returned error: 403

What am I doing wrong? Should I maybe use Phabricator instead?

@mlite
Copy link
Contributor

mlite commented Dec 25, 2015

You don't have the write permission to this repo. You need to create a
pull request.

On 12/25/2015 7:59 AM, Alexander Pankiv wrote:

I've made some more cleanup, but I've got error while trying to push changes to branch:

remote: Permission to haskell/hoopl.git denied to AlexanderPankiv.
fatal: unable to access 'https://github.com/haskell/hoopl/': The requested URL returned error: 403

What am I doing wrong? Should I maybe use Phabricator instead?


Reply to this email directly or view it on GitHub:
#6 (comment)

@lexpank
Copy link
Contributor

lexpank commented Dec 25, 2015

Sorry, worked with private repositories only before that.

michalt added a commit to michalt/hoopl that referenced this issue Jan 16, 2016
Part of ticket cleaning up the repository (ticket haskell#6). For discussions
about the paper see also PR haskell#22.
michalt added a commit to michalt/hoopl that referenced this issue Jan 16, 2016
Part of ticket cleaning up the repository (ticket haskell#6). For discussions
about the paper see also PR haskell#22.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants