Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add (existing mtl typeclass) instances for AccumT #80

Merged
merged 6 commits into from
Jul 22, 2020
Merged

Conversation

chessai
Copy link
Member

@chessai chessai commented Jul 13, 2020

Like it says on the tin.

Note that this PR intentionally DOES NOT address adding MonadAccum, since IMO that is a larger concern and should be handled separately.

@chessai
Copy link
Member Author

chessai commented Jul 13, 2020

Requesting review from @ekmett @RyanGlScott and anyone who is interested from the CLC, cc @haskell/core-libraries-committee

Copy link
Member

@RyanGlScott RyanGlScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems plausible. I have one inline suggestion about the MonadWriter instance.

Control/Monad/Writer/Class.hs Show resolved Hide resolved
Copy link
Member

@RyanGlScott RyanGlScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chessai
Copy link
Member Author

chessai commented Jul 16, 2020

I would welcome more reviews, to be safe. Anyone?

Copy link
Member

@emilypi emilypi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @chessai

@chessai chessai merged commit c8af65e into master Jul 22, 2020
@chessai
Copy link
Member Author

chessai commented Jul 22, 2020

Okay, now on to #81

@turion turion mentioned this pull request Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants