-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add (existing mtl typeclass) instances for AccumT #80
Conversation
Requesting review from @ekmett @RyanGlScott and anyone who is interested from the CLC, cc @haskell/core-libraries-committee |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems plausible. I have one inline suggestion about the MonadWriter
instance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I would welcome more reviews, to be safe. Anyone? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @chessai
Okay, now on to #81 |
Like it says on the tin.
Note that this PR intentionally DOES NOT address adding MonadAccum, since IMO that is a larger concern and should be handled separately.