Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make network buildable on all MSYS flavours #132

Merged
merged 3 commits into from
Apr 13, 2014
Merged

Conversation

awson
Copy link
Contributor

@awson awson commented Apr 13, 2014

The first commit simply refreshes GNU config (current is 8 years old).

The second removes wspiapi.h references which breaks things when the package is built with mingw-w64-based GHC distributions (it is an official 64-bit GHC, and my private 32-bit GHC port, which I want to propose to replace current mingw-based 32-bit GHC when I have time). Wspiapi only exists on pre-XP windows' which aren't supported by recent GHC/network anyway AFAIUI.

Third makes configure recognize 'mingw64' os part of a configure triplet. It is current preferred configuration when building things with 64-bit windows GHC under MSYS2.

@tibbe tibbe merged commit 0b0cf92 into haskell:master Apr 13, 2014
@schernichkin
Copy link

Ok, it still non-functional on win_64 by default (when using cabal install with no additional flags). Build is ok, but program will fail with run-time error: https://gist.github.com/schernichkin/11143340

@tibbe
Copy link
Member

tibbe commented Apr 21, 2014

@schernichkin could you please file this as a separate bug? Also, I can't make much of your gist. How does it fail? What's the error message?

@schernichkin
Copy link

I will post separate bug as soon as I`ll be able to isolate it and reproduce on small program. Currently this is a part of lager application which uses network, http-conduit and so on. The runtime behaviour - application crash (no error messages). It may take few days.

@schernichkin
Copy link

I've traces source source of the error, it in x509-system package, not in network. So network itself working well on my system.

@tibbe
Copy link
Member

tibbe commented Apr 23, 2014

@schernichkin thanks for investigating.

@Bodigrim
Copy link

As a Hackage trustee I marked network-2.4.2.1 and network-2.4.2.2 as deprecated since prior to this patch (which landed in network-2.4.2.3) the package was unbuildable on Windows. This old versions keep appearing in build plans for (yet unreleased) cabal build --prefer-oldest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants