Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inspection testing with coverage #107

Closed
lehins opened this issue Jun 5, 2021 · 2 comments
Closed

Inspection testing with coverage #107

lehins opened this issue Jun 5, 2021 · 2 comments

Comments

@lehins
Copy link
Contributor

lehins commented Jun 5, 2021 •
edited
Loading

Inspection testing that was introduced in #102 fails when coverage report is being produced.

It is known that when compiled with -fhpc the binary produced is completely different and execution will follow a very different path. This doesn't affect the outcome of pure functions and only occasionally affects stuff that runs in IO (eg. concurrency), but because it affects core inspection tests can and do fail.

So, what we can do about it? In my opinion it would be ok, to allow inspection testing failure when compiled with coverage. Potential solutions that come to mind

  • Same as in vector: move inspection tests into its own cabal test section, which would not be executed when coverage report is being generated
  • Enable inspection testing with CPP flag

CC @Bodigrim Thoughts?
@Bodigrim
Copy link
Contributor

Bodigrim commented Jun 5, 2021

Either way is fine from my perspective, whatever is easier. Probably moving to a separate test suite is a cleaner option? Sorry, I'm on vacation, cannot take an in-depth look.

@lehins
Copy link
Contributor Author

lehins commented Jun 5, 2021

No worries. Enjoy your vacation, I'll take care of it

lehins added a commit that referenced this issue Jun 5, 2021
@lehins
Move inspection testing into its own section to avoid failure when bu…
7af29e8 
…ilt with `-fhpc`. Fix #107
@lehins lehins closed this as completed in 4def4b4 Jun 6, 2021
@lehins lehins changed the title Inspection testiing with coverage Inspection testing with coverage Jun 30, 2021
lehins added a commit that referenced this issue Sep 7, 2021
@lehins
Move inspection testing into its own section to avoid failure when bu…
e75c2ed 
…ilt with `-fhpc`. Fix #107

Disable inspection testing for ghc-7.10

Ensure inspection tests do no nothing for pre ghc-8 compiler versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Bodigrim @lehins