Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export System.Posix.Directory.Common #25

Closed
JohnLato opened this issue Oct 27, 2014 · 4 comments
Closed

export System.Posix.Directory.Common #25

JohnLato opened this issue Oct 27, 2014 · 4 comments

Comments

@JohnLato
Copy link

Without DirStream, if you wish to do a deep traversal of a directory structure, it's necessary to stat everything in order to determine if it's a sub-directory (and needs to be descended into) or a regular file. This imposes a significant performance penalty (see https://github.com/JohnLato/posix-paths for benchmarks).

I don't think there's any reason this module can't be exported in its entirety.

@hvr
Copy link
Member

hvr commented Dec 6, 2014

Are you actually asking to export the constructor of DirStream?

@JohnLato
Copy link
Author

JohnLato commented Dec 7, 2014

Yes, and probably CDir and CDirent also. I think the most pragmatic way of doing so is exporting this module in its entirety, because I could imagine that someone may want to use one of the FFI calls as well.

@hvr
Copy link
Member

hvr commented Dec 7, 2014

@JohnLato But is .Common the proper name for it? It seems more like an .Internal module as we don't want to have to adhere to the PVP for the internal representation (I guess)...

@JohnLato
Copy link
Author

Sure, a .Internal name makes sense. Or possibly .Foreign since it's the
lowest level wrapper.

On 02:04, Sun, Dec 7, 2014 Herbert Valerio Riedel notifications@github.com
wrote:

@JohnLato https://github.com/JohnLato But is .Common the proper name
for it? It seems more like an .Internal module as we don't want to have
to adhere to the PVP for the internal representation (I guess)...


Reply to this email directly or view it on GitHub
#25 (comment).

hasufell added a commit to hasufell/unix that referenced this issue Jul 10, 2022
hasufell added a commit to hasufell/unix that referenced this issue Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants