-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wasm CI / disable for PRs #226
Conversation
The patch at #202 (comment) already mitigates the base bound issue for |
I want the wasm job disabled for PRs for now. Otherwise I'm not making any progress here. There have been more failures: https://github.com/haskell/unix/runs/7292165125?check_suite_focus=true#step:2:277 I don't want to monkey-patch this. Someone has to take a proper look at this CI and test it thoroughly. We can do that before the release. |
It seems it's working now... @TerrorJack my guess is that these things should work better on GHC gitlab CI. Migrating there would also allow us to mark jobs as non-fatal. Github doesn't have this feature yet. Opinions? |
It was a flakiness in head.hackage server, since the setup script of I suggest only pushing the |
We have a full-time devops working on it. We're relying on it already for ghcup, filepath, cabal (releases) and HLS (releases). |
I'm not a fan of moving If |
Please approve then. This repo is configured to not allow pushes to master, which I find rather annoying. |
@TerrorJack
This is starting to get a little cumbersome. I'm inclined to make the wasm job non-fatal until it's straightened out. It's blocking PRs that have nothing to do with it.