Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wasm CI / disable for PRs #226

Merged
merged 1 commit into from
Jul 14, 2022
Merged

Conversation

hasufell
Copy link
Member

@TerrorJack

This is starting to get a little cumbersome. I'm inclined to make the wasm job non-fatal until it's straightened out. It's blocking PRs that have nothing to do with it.

@TerrorJack
Copy link
Contributor

The patch at #202 (comment) already mitigates the base bound issue for ci-wasm32-wasi job.

@hasufell
Copy link
Member Author

hasufell commented Jul 11, 2022

I want the wasm job disabled for PRs for now. Otherwise I'm not making any progress here.

There have been more failures: https://github.com/haskell/unix/runs/7292165125?check_suite_focus=true#step:2:277

I don't want to monkey-patch this. Someone has to take a proper look at this CI and test it thoroughly. We can do that before the release.

@hasufell hasufell changed the title Loosen base Fix wasm CI / disable for PRs Jul 11, 2022
@hasufell
Copy link
Member Author

It seems it's working now...

@TerrorJack my guess is that these things should work better on GHC gitlab CI. Migrating there would also allow us to mark jobs as non-fatal. Github doesn't have this feature yet. Opinions?

@TerrorJack
Copy link
Contributor

It was a flakiness in head.hackage server, since the setup script of ghc-wasm32-wasi will perform a cabal update, which fetches from both hackage and head.hackage. I'm not sure if running those in ghc gitlab ci will be more robust, given ghc gitlab ci's track record of robustness.

I suggest only pushing the allow-newer: base change because that allows wasm32 CI job to continue to function, without blocking any ongoing PR. If you believe wasm32 CI job should still be disabled, please let me know and I'll open an alternative PR that moves the logic to a bash script that never fails, so jobs are always green and I'll manually check the status of each single actions run in the repo and offer fixes when needed.

@hasufell
Copy link
Member Author

I'm not sure if running those in ghc gitlab ci will be more robust, given ghc gitlab ci's track record of robustness.

We have a full-time devops working on it. We're relying on it already for ghcup, filepath, cabal (releases) and HLS (releases).

@Bodigrim
Copy link
Contributor

I'm not a fan of moving unix to GitLab. I'm already spreaded too thin and do not want to split attention between two platforms.

If allow-newer: all:base is sufficient, I'd prefer to keep WASM job for pull requests. Otherwise it is too easy to forget about it.

@hasufell
Copy link
Member Author

Please approve then.

This repo is configured to not allow pushes to master, which I find rather annoying.

@Bodigrim Bodigrim merged commit 34e4b59 into haskell:master Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants