Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add functions that are missing on Android #54

Closed
wants to merge 2 commits into from
Closed

Add functions that are missing on Android #54

wants to merge 2 commits into from

Conversation

rwbarton
Copy link
Contributor

No description provided.

@rwbarton
Copy link
Contributor Author

I have built the unix package for Android with these changes and verified that the functions involved appear to work as expected (drainOutput does not appear to do anything and getControllingTerminalName returns "/dev/tty", which even exists and acts as normal).

hvr
hvr reviewed Jan 28, 2016
View reviewed changes
cbits/ctermid.c
/* Provide ctermid() if it is missing (as on some Android versions). */

#include "HsUnixConfig.h"
#ifndef HAVE_CTERMID
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fwiw, I consider the use of #ifdefs for boolean macros bad style; I know that the unix package currently still has a lot of #ifdef HAVE_* around, but I'm considering replacing those at some point

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to make that change at some point, including the occurrences in this file.

@hvr
Copy link
Member

hvr commented Jan 28, 2016

In conclusion, I suggest a more principled way to address this issue.

@rwbarton
Copy link
Contributor Author

I can change the function names to hsunix_tcdrain and hsunix_ctermid.

@rwbarton rwbarton closed this Jan 29, 2016
@hvr hvr mentioned this pull request Jan 30, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rwbarton @hvr