-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade dependencies #564
Merged
Merged
Upgrade dependencies #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fendor
requested review from
hasufell and
jneira
and removed request for
hasufell
April 3, 2022 18:33
|
Don't need safe* functions anymore according to https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md#400---2021-01-03
Use 'resolveCliArgsFromVSCodeExecutablePath' because the API now tells you to.
fendor
force-pushed
the
polish/yarn-over-npm
branch
from
April 3, 2022 18:52
2c6767b
to
0432244
Compare
Did you test the extension after the update? |
@hasufell Yes, I tested that the hoogle command still works (which uncovered an error) since it is the main feature hit by these changes and that the extension can successfully setup HLS. However, I did not test the changes to |
fendor
force-pushed
the
polish/yarn-over-npm
branch
from
April 3, 2022 19:09
656c4e1
to
81d60d6
Compare
hasufell
approved these changes
Apr 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, decide to use yarn for development instead of npm. The decision is completely arbitrary, but we did have both
yarn.lock
andpackage-lock.json
, and this decides we only need the former.Decision subject to debate.
The big change here is that all dependencies are upgraded and deprecated dependencies are removed, most notably
request
has been replaced bybent
.