Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies #564

Merged
merged 11 commits into from
Apr 3, 2022
Merged

Upgrade dependencies #564

merged 11 commits into from
Apr 3, 2022

Conversation

fendor
Copy link
Collaborator

@fendor fendor commented Apr 3, 2022

Also, decide to use yarn for development instead of npm. The decision is completely arbitrary, but we did have both yarn.lock and package-lock.json, and this decides we only need the former.
Decision subject to debate.

The big change here is that all dependencies are upgraded and deprecated dependencies are removed, most notably request has been replaced by bent.

@fendor fendor requested review from hasufell and jneira and removed request for hasufell April 3, 2022 18:33
@hasufell
Copy link
Member

hasufell commented Apr 3, 2022

npm ERR! The `npm ci` command can only install with an existing package-lock.json or
npm ERR! npm-shrinkwrap.json with lockfileVersion >= 1. Run an install with npm@[5](https://github.com/haskell/vscode-haskell/runs/5807360080?check_suite_focus=true#step:9:5) or
npm ERR! later to generate a package-lock.json file, then try again.

npm ERR! A complete log of this run can be found in:
npm ERR!     C:\npm\cache\_logs\2022-04-03T18_2[7](https://github.com/haskell/vscode-haskell/runs/5807360080?check_suite_focus=true#step:9:7)_3[8](https://github.com/haskell/vscode-haskell/runs/5807360080?check_suite_focus=true#step:9:8)_180Z-debug-0.log

@hasufell
Copy link
Member

hasufell commented Apr 3, 2022

Did you test the extension after the update?

@fendor
Copy link
Collaborator Author

fendor commented Apr 3, 2022

@hasufell Yes, I tested that the hoogle command still works (which uncovered an error) since it is the main feature hit by these changes and that the extension can successfully setup HLS.

However, I did not test the changes to build.yml, not sure how would be the best way.

@fendor fendor merged commit b80f636 into haskell:master Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants