Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @jprupp
This PR fixes the build matrix for
secp256k1-haskell
, which currently does not build on GHC 7.10, 8.0, or 8.2 due to a lack of bounds, and also addresses #34. You can futz with them however you like, but (at least) the lack of bounds onbase16-bytestring
caused a breakage due to a major version bump that changed the API. Here, I've generated conservative bounds usingcabal gen-bounds
.It also fails for any LTS before
lts-9.0
, sinceunliftio
andunliftio-core
were not included in any previous LTS's. Fortunatelycabal-install
supports GHC 7.10 andunliftio-core
, so if you're okay with not usingstack
, you can get away with keeping the current GHC support. Otherwise, I've done the fix assuming you likestack
, and that includes supportinglts-9.0
, which means i've lowered your cabal version, and bumped yourbase
bounds to be GHC >=8.0.2 to accommodate the strictcabal-version
andbase
requirements of the old LTS's.I also noticed you're using
unliftio
as a dependency, but only using the typeclass. I've relaxed the dependency to useunliftio-core
, which should make your build a little faster, save on CI costs, and generally reduce the carbon footprint of the project 😄