Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bounds #35

Merged
merged 1 commit into from
Oct 16, 2020
Merged

Fix bounds #35

merged 1 commit into from
Oct 16, 2020

Conversation

emilypi
Copy link

@emilypi emilypi commented Oct 9, 2020

Hi @jprupp

This PR fixes the build matrix for secp256k1-haskell, which currently does not build on GHC 7.10, 8.0, or 8.2 due to a lack of bounds, and also addresses #34. You can futz with them however you like, but (at least) the lack of bounds on base16-bytestring caused a breakage due to a major version bump that changed the API. Here, I've generated conservative bounds using cabal gen-bounds.

It also fails for any LTS before lts-9.0, since unliftio and unliftio-core were not included in any previous LTS's. Fortunately cabal-install supports GHC 7.10 and unliftio-core, so if you're okay with not using stack, you can get away with keeping the current GHC support. Otherwise, I've done the fix assuming you like stack, and that includes supporting lts-9.0, which means i've lowered your cabal version, and bumped your base bounds to be GHC >=8.0.2 to accommodate the strict cabal-version and base requirements of the old LTS's.

I also noticed you're using unliftio as a dependency, but only using the typeclass. I've relaxed the dependency to use unliftio-core, which should make your build a little faster, save on CI costs, and generally reduce the carbon footprint of the project 😄

@jprupp
Copy link
Member

jprupp commented Oct 15, 2020

I noticed you added limits to the Cabal file, but that file is generated from the package.yaml file. Would you do the changes there and then use Stack to generate a new Cabal file from it, and then commit everything? I will then merge. My apologies for not responding earlier.

@emilypi
Copy link
Author

emilypi commented Oct 16, 2020

@jprupp You have the bounds, and your package is now up to date. I will not be making any more changes, but you are free to make commits to the PR to suit your convenience.

remove spurious use of <>

relax unliftio to unliftio-core

fix bounds for lts-9.0
@jprupp jprupp merged commit c038c74 into haskoin:master Oct 16, 2020
@emilypi emilypi deleted the base16-fix branch October 16, 2020 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants