-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mysqlclient to requirements #5
Comments
👋 Thanks for opening your first issue here! If you're reporting a 🐛 bug, please make sure you include steps to reproduce it. Also, logs, error messages and information about your hardware might be usefull. |
Just pushed out an update with this change, awaiting edge build results. |
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread. |
Problem/Motivation
Our jupyerlab-lite add-on should contain the same DB connectors as Hass.io, to ensure that we support all possible DB recorder urls that we can encounter in the config.
This is what Hass.io does for their container:
Expected behavior
Same DB support packages as Hass.io contains in the container
Actual behavior
We use PyMySQL instead of mysql client.
https://github.com/hassio-addons/addon-jupyterlab-lite/blob/e55ac7e4ffb2f8f2d575571fea43374614697947/jupyterlab/requirements.txt#L15
Steps to reproduce
use db recorder url starting with
mysql://
Proposed changes
Replace PyMySQL with mysqlclient
The text was updated successfully, but these errors were encountered: