Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy-embeddings make target vs python script #50

Closed
hvgazula opened this issue May 22, 2022 · 4 comments
Closed

copy-embeddings make target vs python script #50

hvgazula opened this issue May 22, 2022 · 4 comments
Assignees

Comments

@hvgazula
Copy link
Collaborator

If the copy-embeddings target replaces the tfspkl_copy.py, then I reckon we should just delete the python script. Also, probably ln -s is better instead of cp to save space. What do you think @zkokaja?

@zkokaja
Copy link
Contributor

zkokaja commented May 22, 2022

Good idea! How would it affect uploading to gcp? Either way it seems it can be in bash instead of python

@hvgazula
Copy link
Collaborator Author

hvgazula commented May 22, 2022

indeed. Also, I don't see it affecting gs rsync.

@hvgazula hvgazula changed the title copy-embeddings makr target vs python script copy-embeddings make target vs python script May 22, 2022
@zkokaja
Copy link
Contributor

zkokaja commented Aug 3, 2022

@zkokaja what can be done?

@hvgazula
Copy link
Collaborator Author

deleted tfspkl_copy.py as the make target 'copy-embeddings' takes care of it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants