-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
copy-embeddings make target vs python script #50
Comments
Good idea! How would it affect uploading to gcp? Either way it seems it can be in bash instead of python |
indeed. Also, I don't see it affecting gs rsync. |
hvgazula
changed the title
copy-embeddings makr target vs python script
copy-embeddings make target vs python script
May 22, 2022
@zkokaja what can be done? |
deleted tfspkl_copy.py as the make target 'copy-embeddings' takes care of it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If the copy-embeddings target replaces the tfspkl_copy.py, then I reckon we should just delete the python script. Also, probably
ln -s
is better instead of cp to save space. What do you think @zkokaja?The text was updated successfully, but these errors were encountered: