Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --global option for installing molt #165

Merged
merged 1 commit into from
May 7, 2024
Merged

Conversation

kyoh86
Copy link
Contributor

@kyoh86 kyoh86 commented May 4, 2024

Now the command shows the warning like this:

⚠️ `deno install` behavior will change in Deno 2. To preserve the current behavior use the `-g` or `--global` flag.

Maybe molt should be installed as global.

@hasundue
Copy link
Owner

hasundue commented May 4, 2024

Thanks! LGTM but something wrong with CI 👀
Very unlikely to be related to your change but let me figure it out before merging...

@hasundue
Copy link
Owner

hasundue commented May 6, 2024

Let me rebase the upstream change on CI and test it.

Now the command shows the warning like this:

```
⚠️ `deno install` behavior will change in Deno 2. To preserve the current behavior use the `-g` or `--global` flag.
```

Maybe molt should be installed as global.
Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.13%. Comparing base (5c884f6) to head (fb12cba).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #165      +/-   ##
==========================================
- Coverage   86.30%   86.13%   -0.18%     
==========================================
  Files          10       10              
  Lines        1161     1161              
  Branches      206      205       -1     
==========================================
- Hits         1002     1000       -2     
- Misses        157      159       +2     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hasundue
Copy link
Owner

hasundue commented May 6, 2024

Token-less upload of Codecov only works on Windows, which is weird, but I'm fixing it on another PR.

@kyoh86 do you mind if your commit being merged as unverified? I'm lazy and not configured signing...

@hasundue
Copy link
Owner

hasundue commented May 7, 2024

OK let me do it without a permission cause I don't think it super important.

@hasundue hasundue merged commit bda03e3 into hasundue:main May 7, 2024
6 of 7 checks passed
@kyoh86 kyoh86 deleted the patch-1 branch May 19, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants