Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

console: fix checkbox for forwarding client headers in actions (close #4595) #4669

Merged
merged 9 commits into from May 12, 2020

Conversation

lastnamearya
Copy link
Member

Description

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR.

Affected components

  • Console

Related Issues

#4595

Breaking changes

  • No Breaking changes

@lastnamearya lastnamearya added the c/console Related to console label May 5, 2020
@lastnamearya lastnamearya requested a review from wawhal May 5, 2020 03:17
@lastnamearya lastnamearya requested a review from a team as a code owner May 5, 2020 03:17
@hasura-bot
Copy link
Contributor

Review app for commit 5b95747 deployed to Heroku: https://hge-ci-pull-4669.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4669-5b957478

className={`${styles.add_mar_right} ${styles.cursorPointer}`}
onClick={toggleForwardClientHeaders}
>
<label className={styles.add_mar_right}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make the entire label (along with the checkbox) cursor:pointer?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure @wawhal

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pushed

@netlify
Copy link

netlify bot commented May 5, 2020

Deploy preview for hasura-docs ready!

Built with commit c6fd543

https://deploy-preview-4669--hasura-docs.netlify.app

@lastnamearya lastnamearya requested a review from wawhal May 5, 2020 09:00
@hasura-bot
Copy link
Contributor

Review app for commit 755fbaf deployed to Heroku: https://hge-ci-pull-4669.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4669-755fbaf0

@hasura-bot
Copy link
Contributor

Review app for commit 43198eb deployed to Heroku: https://hge-ci-pull-4669.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4669-43198eba

@hasura-bot
Copy link
Contributor

Review app for commit 247734c deployed to Heroku: https://hge-ci-pull-4669.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4669-247734c0

@lastnamearya lastnamearya requested a review from a team as a code owner May 12, 2020 09:03
CHANGELOG.md Outdated
@@ -39,6 +40,7 @@ Read more about the session argument for computed fields in the [docs](https://h
- console: avoid count queries for large tables (#4692)
- console: add read replica support section to pro popup (#4118)
- console: allow modifying default value for PK (fix #4075) (#4679)
- console: fix checkbox for actions headerconfeditor (#4595)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- console: fix checkbox for actions headerconfeditor (#4595)
- console: fix checkbox for forwarding client headers in actions (#4595)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated @tirumaraiselvan :)

Copy link
Contributor

@wawhal wawhal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functionality looks fine.

Copy link
Contributor

@tirumaraiselvan tirumaraiselvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog approved

@lastnamearya lastnamearya changed the title console: fix checkbox for actions headerconfeditor(close #4595) console: fix checkbox for forwarding client headers in actions (close #4595) May 12, 2020
@hasura-bot
Copy link
Contributor

Review app for commit ce5d24b deployed to Heroku: https://hge-ci-pull-4669.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4669-ce5d24bb

@rikinsk rikinsk merged commit f993a6c into hasura:master May 12, 2020
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-4669.herokuapp.com is deleted

beerose pushed a commit to beerose/graphql-engine that referenced this pull request Jun 16, 2020
rikinsk pushed a commit that referenced this pull request Jun 16, 2020
…5108)

* console: fix checkbox for forwarding client headers in actions (close #4595) (#4669)
* console: fix bulk selected rows state in data browser (close #4654) (#4673)
* console: fix displaying boolean values in Edit Row tab (#4682)
* console: fix regression in editing permissions manually (fix #4683) (#4826)
* console: fix "Cannot read property 'foldable'" runtime error in `Browse Rows` page (fix #4907) (#5016)
* console: fix enum tables reload data button UI (close #4647) (#4877)
stevefan1999-personal pushed a commit to stevefan1999-personal/graphql-engine that referenced this pull request Sep 12, 2020
hasura-bot pushed a commit that referenced this pull request Aug 5, 2022
PR-URL: hasura/graphql-engine-mono#5161
GitOrigin-RevId: 3bce830e283aa3c84044851be41e3c0db2f43e8b
seanparkross pushed a commit that referenced this pull request Aug 8, 2022
PR-URL: hasura/graphql-engine-mono#5161
GitOrigin-RevId: 3bce830e283aa3c84044851be41e3c0db2f43e8b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/console Related to console
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants