New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
console: fix checkbox for forwarding client headers in actions (close #4595) #4669
Conversation
Review app for commit 5b95747 deployed to Heroku: https://hge-ci-pull-4669.herokuapp.com |
className={`${styles.add_mar_right} ${styles.cursorPointer}`} | ||
onClick={toggleForwardClientHeaders} | ||
> | ||
<label className={styles.add_mar_right}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make the entire label (along with the checkbox) cursor:pointer
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure @wawhal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pushed
Deploy preview for hasura-docs ready! Built with commit c6fd543 |
Review app for commit 755fbaf deployed to Heroku: https://hge-ci-pull-4669.herokuapp.com |
Review app for commit 43198eb deployed to Heroku: https://hge-ci-pull-4669.herokuapp.com |
Review app for commit 247734c deployed to Heroku: https://hge-ci-pull-4669.herokuapp.com |
CHANGELOG.md
Outdated
@@ -39,6 +40,7 @@ Read more about the session argument for computed fields in the [docs](https://h | |||
- console: avoid count queries for large tables (#4692) | |||
- console: add read replica support section to pro popup (#4118) | |||
- console: allow modifying default value for PK (fix #4075) (#4679) | |||
- console: fix checkbox for actions headerconfeditor (#4595) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- console: fix checkbox for actions headerconfeditor (#4595) | |
- console: fix checkbox for forwarding client headers in actions (#4595) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated @tirumaraiselvan :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code and functionality looks fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changelog approved
Review app for commit ce5d24b deployed to Heroku: https://hge-ci-pull-4669.herokuapp.com |
Review app https://hge-ci-pull-4669.herokuapp.com is deleted |
…5108) * console: fix checkbox for forwarding client headers in actions (close #4595) (#4669) * console: fix bulk selected rows state in data browser (close #4654) (#4673) * console: fix displaying boolean values in Edit Row tab (#4682) * console: fix regression in editing permissions manually (fix #4683) (#4826) * console: fix "Cannot read property 'foldable'" runtime error in `Browse Rows` page (fix #4907) (#5016) * console: fix enum tables reload data button UI (close #4647) (#4877)
PR-URL: hasura/graphql-engine-mono#5161 GitOrigin-RevId: 3bce830e283aa3c84044851be41e3c0db2f43e8b
PR-URL: hasura/graphql-engine-mono#5161 GitOrigin-RevId: 3bce830e283aa3c84044851be41e3c0db2f43e8b
Description
Changelog
CHANGELOG.md
is updated with user-facing content relevant to this PR.Affected components
Related Issues
#4595
Breaking changes