console: fix "Cannot read property 'foldable'" runtime error in Browse Rows page (fix #4907)
#5016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rikinsk
approved these changes
Jun 8, 2020
CHANGELOG.md
Outdated
| @@ -92,6 +92,7 @@ Read more about the session argument for computed fields in the [docs](https://h | |||
| - console: fix visiting view modify page overwriting raw sql content (fix #4798) (#4810) | |||
| - console: add help button and move about page to settings (#4848) | |||
| - console: add new sidebar icon that separates enums from tables (fix #4984) (#4992) | |||
| - console: fix runtime error in `Browse Rows` page (fix #4907) (#5016) | |||
There was a problem hiding this comment.
is it possible to explain the condition (as simply as possible) when this error is hit.
There was a problem hiding this comment.
its not reproduceable but the offending code is fixed. will update with the error type
beerose
commented
Jun 8, 2020
|
Review app for commit e5f388c deployed to Heroku: https://hge-ci-pull-5016.herokuapp.com |
rikinsk
changed the title
Browse Rows page (fix #4907)
|
Review app https://hge-ci-pull-5016.herokuapp.com is deleted |
beerose
pushed a commit
to beerose/graphql-engine
that referenced
this pull request
Jun 16, 2020
…se Rows` page (fix hasura#4907) (hasura#5016)
1 task
rikinsk
pushed a commit
that referenced
this pull request
Jun 16, 2020
…5108) * console: fix checkbox for forwarding client headers in actions (close #4595) (#4669) * console: fix bulk selected rows state in data browser (close #4654) (#4673) * console: fix displaying boolean values in Edit Row tab (#4682) * console: fix regression in editing permissions manually (fix #4683) (#4826) * console: fix "Cannot read property 'foldable'" runtime error in `Browse Rows` page (fix #4907) (#5016) * console: fix enum tables reload data button UI (close #4647) (#4877)
stevefan1999-personal
pushed a commit
to stevefan1999-personal/graphql-engine
that referenced
this pull request
Sep 12, 2020
…se Rows` page (fix hasura#4907) (hasura#5016)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #4907
Description
This PR filters columns list for truthy values.
Changelog
CHANGELOG.mdis updated with user-facing content relevant to this PR. If no changelog is required, then add theno-changelog-requiredlabel.Affected components