-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
console: fix "Cannot read property 'foldable'" runtime error in Browse Rows
page (fix #4907)
#5016
Conversation
CHANGELOG.md
Outdated
@@ -92,6 +92,7 @@ Read more about the session argument for computed fields in the [docs](https://h | |||
- console: fix visiting view modify page overwriting raw sql content (fix #4798) (#4810) | |||
- console: add help button and move about page to settings (#4848) | |||
- console: add new sidebar icon that separates enums from tables (fix #4984) (#4992) | |||
- console: fix runtime error in `Browse Rows` page (fix #4907) (#5016) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it possible to explain the condition (as simply as possible) when this error is hit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its not reproduceable but the offending code is fixed. will update with the error type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CL
Review app for commit e5f388c deployed to Heroku: https://hge-ci-pull-5016.herokuapp.com |
Browse Rows
page (fix #4907)
Review app https://hge-ci-pull-5016.herokuapp.com is deleted |
…se Rows` page (fix hasura#4907) (hasura#5016)
…5108) * console: fix checkbox for forwarding client headers in actions (close #4595) (#4669) * console: fix bulk selected rows state in data browser (close #4654) (#4673) * console: fix displaying boolean values in Edit Row tab (#4682) * console: fix regression in editing permissions manually (fix #4683) (#4826) * console: fix "Cannot read property 'foldable'" runtime error in `Browse Rows` page (fix #4907) (#5016) * console: fix enum tables reload data button UI (close #4647) (#4877)
…se Rows` page (fix hasura#4907) (hasura#5016)
Solves #4907
Description
This PR filters columns list for truthy values.
Changelog
CHANGELOG.md
is updated with user-facing content relevant to this PR. If no changelog is required, then add theno-changelog-required
label.Affected components