Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

console: misc bug fixes (#4669, #4673, #4682, #4826, #5016, #4877 ) (#5108) #5108

Merged
merged 6 commits into from Jun 16, 2020
Merged

console: misc bug fixes (#4669, #4673, #4682, #4826, #5016, #4877 ) (#5108) #5108

merged 6 commits into from Jun 16, 2020

Conversation

beerose
Copy link
Contributor

@beerose beerose commented Jun 16, 2020

  1. Fix enum tables reload data button UI (console: enum tables reload data UI is buggy #4647)
  2. Fix regression in editing permissions manually (fix console: editing permissions manually seems to have stopped working properly #4683) (console: fix regression in editing permissions manually (fix #4683) (#4826) #4826)
  3. Fix checkbox for forwarding client headers in actions (Strange behavior for "forward client headers..." checkbox in action  #4595)
  4. Fix inconsistency between selected rows state and displayed rows (fix BUG: Console delete selected state inconsistency #4654) (console: update selected rows state after single row delete (close #4654) #4673)
  5. Fix displaying boolean values in Edit Row tab (console: don't overwrite default value in boolean selector #4682)
  6. Fix "Cannot read property 'foldable'" runtime error in Browse Rows page (fix console: Cannot read property 'foldable' of undefined #4907) (console: fix "Cannot read property 'foldable'" runtime error in Browse Rows page (fix #4907) #5016)

Affected components

  • Console

@beerose beerose added the c/console Related to console label Jun 16, 2020
@beerose beerose requested review from a team as code owners June 16, 2020 15:21
@hasura-bot
Copy link
Contributor

Review app for commit c8a9145 deployed to Heroku: https://hge-ci-pull-5108.herokuapp.com
Docker image for server: hasura/graphql-engine:pull5108-c8a9145b

@rikinsk rikinsk changed the title console: misc bug fixes console: misc bug fixes (#4669, #4673, #4682, #4826, #5016, #4877 ) (#5108) Jun 16, 2020
@rikinsk rikinsk merged commit ece895f into hasura:stable Jun 16, 2020
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-5108.herokuapp.com is deleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rikinsk rikinsk rikinsk approved these changes

Assignees
No one assigned
Labels
c/console Related to console
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@beerose @hasura-bot @rikinsk @lastnamearya @soorajshankar