Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

console: update selected rows state after single row delete (close #4654) #4673

Merged
merged 10 commits into from May 14, 2020
Merged

console: update selected rows state after single row delete (close #4654) #4673

merged 10 commits into from May 14, 2020

Conversation

beerose
Copy link
Contributor

@beerose beerose commented May 5, 2020 •
edited

Solves #4654

Description

This PR fixes inconsistency between selected rows and currently displayed rows, by updating selected rows state after single row delete.

It also adds tests for bulk delete rows and updates checkViewRelationship test as it was failing in some cases when there was an update notification visible. The test was looking for a element containing View and both relationship column and update notification contained string View:

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR.

Affected components

  • Console

@beerose beerose added the c/console Related to console label May 5, 2020
@beerose beerose requested a review from a team as a code owner May 5, 2020 14:28
@hasura-bot
Copy link
Contributor

Review app for commit 897cb39 deployed to Heroku: https://hge-ci-pull-4673.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4673-897cb396

@rikinsk
Copy link
Member

rikinsk commented May 5, 2020

/heroku deploy

@hasura-bot
Copy link
Contributor

Review app for commit 68dcdac deployed to Heroku: https://hge-ci-pull-4673.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4673-68dcdac9

@hasura-bot
Copy link
Contributor

Review app for commit cf89d62 deployed to Heroku: https://hge-ci-pull-4673.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4673-cf89d626

@beerose beerose requested a review from a team as a code owner May 5, 2020 16:41
@hasura-bot
Copy link
Contributor

Review app for commit b1caba7 deployed to Heroku: https://hge-ci-pull-4673.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4673-b1caba73

@rikinsk
Copy link
Member

rikinsk commented May 14, 2020

/heroku deploy

@hasura-bot
Copy link
Contributor

@rikinsk status checks not passed for commit c88bffd

@hasura-bot
Copy link
Contributor

Review app for commit c88bffd deployed to Heroku: https://hge-ci-pull-4673.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4673-c88bffdc

@rikinsk rikinsk requested a review from wawhal May 14, 2020 11:59
@rikinsk rikinsk assigned wawhal and unassigned rikinsk May 14, 2020
@hasura-bot
Copy link
Contributor

Review app for commit 7db2a31 deployed to Heroku: https://hge-ci-pull-4673.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4673-7db2a31d

@hasura-bot
Copy link
Contributor

Review app for commit e84ea9c deployed to Heroku: https://hge-ci-pull-4673.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4673-e84ea9c7

@rikinsk rikinsk merged commit 8a2d90c into hasura:master May 14, 2020
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-4673.herokuapp.com is deleted

beerose pushed a commit to beerose/graphql-engine that referenced this pull request Jun 16, 2020
console: fix bulk selected rows state in data browser (close hasura#4654
995d672 
) (hasura#4673)
@beerose beerose mentioned this pull request Jun 16, 2020
Merged
1 task
rikinsk pushed a commit that referenced this pull request Jun 16, 2020
console: misc bug fixes (#4669, #4673, #4682, #4826, #5016, #4877 ) (#…
ece895f 
…5108)

* console: fix checkbox for forwarding client headers in actions (close #4595) (#4669)
* console: fix bulk selected rows state in data browser (close #4654) (#4673)
* console: fix displaying boolean values in Edit Row tab (#4682)
* console: fix regression in editing permissions manually (fix #4683) (#4826)
* console: fix "Cannot read property 'foldable'" runtime error in `Browse Rows` page (fix #4907) (#5016)
* console: fix enum tables reload data button UI (close #4647) (#4877)
stevefan1999-personal pushed a commit to stevefan1999-personal/graphql-engine that referenced this pull request Sep 12, 2020
@stevefan1999-personal
console: fix bulk selected rows state in data browser (close hasura#4654
afea0cd 
) (hasura#4673)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wawhal wawhal wawhal approved these changes

@rikinsk rikinsk rikinsk approved these changes

Assignees

@wawhal wawhal

Labels
c/console Related to console
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@beerose @hasura-bot @rikinsk @wawhal