Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update the nextjs postgres graphql sample app, close #7672 #9048

Closed
wants to merge 4 commits into from
Closed

update the nextjs postgres graphql sample app, close #7672 #9048

wants to merge 4 commits into from

Conversation

amit-ksh
Copy link
Contributor

@amit-ksh amit-ksh commented Oct 1, 2022

Description

Rebuild the sample app using the latest version of NextJS and ApolloClient.

Changelog

Component : community

Product: community-edition

Short Changelog

  1. Removes all the older dependencies of the app and updated it to the latest one.
  2. Uses the ApolloClient instead of apollo-boost for data fetching.
  3. Uses the next-with-apollo instead of next-apollo for providing the ApolloClient context.

Related Issues

#7672

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

Server checklist

Catalog upgrade

Does this PR change Hasura Catalog version?

  • No
  • Yes
    • Updated docs with SQL for downgrading the catalog

Metadata

Does this PR add a new Metadata feature?

  • No
  • Yes
    • Does run_sql auto manages the new metadata through schema diffing?
      • Yes
      • Not required
    • Does run_sql auto manages the definitions of metadata on renaming?
      • Yes
      • Not required
    • Does export_metadata/replace_metadata supports the new metadata added?
      • Yes
      • Not required

GraphQL

  • No new GraphQL schema is generated
  • New GraphQL schema is being generated:
    • New types and typenames are correlated

Breaking changes

  • No Breaking changes

  • There are breaking changes:

    1. Metadata API

      Existing query types:

      • Modify args payload which is not backward compatible
      • Behavioural change of the API
      • Change in response JSON schema
      • Change in error code

    2. GraphQL API

      Schema Generation:

      • Change in any NamedType
      • Change in table field names

      Schema Resolve:-

      • Change in treatment of null value for any input fields

    3. Logging

      • Log JSON schema has changed
      • Log type names have changed

@amit-ksh amit-ksh requested a review from a team as a code owner October 1, 2022 16:28
@hasura-bot
Copy link
Contributor

Beep boop! 🤖

Hey @amit-ksh, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! 😎

@Stefmore02 Stefmore02 added c/community Related to community content hacktoberfest labels Oct 4, 2022
praveenweb
praveenweb requested changes Dec 21, 2022
View reviewed changes
Copy link
Member

@praveenweb praveenweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good apart from the admin secret usage. Please make the relevant changes for that (ideally, remove the admin secret usage and don't have any authentication, make a public role with Unauthorized access).

@amit-ksh amit-ksh force-pushed the sample-app-next-postgres-graphql branch from 78c9a5d to 4921dae Compare December 23, 2022 11:04
hasura-bot added a commit that referenced this pull request Feb 1, 2023
@hasura-bot @amit-ksh @github-actions
update the nextjs postgres graphql sample app
95444b6 
GITHUB_PR_NUMBER: 9048
GITHUB_PR_URL: #9048

PR-URL: hasura/graphql-engine-mono#6159
Co-authored-by: Amit Kumar Sharma <91947037+amit-ksh@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
GitOrigin-RevId: 0565d8a00c944d72b46bc5ce0ff40fc3e8bfca51
@hasura-bot hasura-bot closed this Feb 1, 2023
@hasura-bot
Copy link
Contributor

Beep boop! 🤖

GIF

Awesome work @amit-ksh!

Your changes were merged successfully. All of us at Hasura ❤️ what you did.

Thanks again 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praveenweb praveenweb praveenweb approved these changes

Assignees
No one assigned
Labels
auto-update-auto-merge c/community Related to community content hacktoberfest merged no-changelog-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amit-ksh @hasura-bot @praveenweb @Stefmore02