Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #9125

Closed
wants to merge 1 commit into from
Closed

Update README.md #9125

wants to merge 1 commit into from

Conversation

JensColman
Copy link
Contributor

@JensColman JensColman commented Oct 18, 2022

Minor spelling and grammar corrections.

Description

Changelog

Component : server / cli / console / build

Type: bugfix / feature / enhancement

Product: community-edition

Short Changelog

Long Changelog

Related Issues

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

Server checklist

Catalog upgrade

Does this PR change Hasura Catalog version?

  • No
  • Yes
    • Updated docs with SQL for downgrading the catalog

Metadata

Does this PR add a new Metadata feature?

  • No
  • Yes
    • Does run_sql auto manages the new metadata through schema diffing?
      • Yes
      • Not required
    • Does run_sql auto manages the definitions of metadata on renaming?
      • Yes
      • Not required
    • Does export_metadata/replace_metadata supports the new metadata added?
      • Yes
      • Not required

GraphQL

  • No new GraphQL schema is generated
  • New GraphQL schema is being generated:
    • New types and typenames are correlated

Breaking changes

  • No Breaking changes

  • There are breaking changes:

    1. Metadata API

      Existing query types:

      • Modify args payload which is not backward compatible
      • Behavioural change of the API
      • Change in response JSON schema
      • Change in error code
    2. GraphQL API

      Schema Generation:

      • Change in any NamedType
      • Change in table field names

      Schema Resolve:-

      • Change in treatment of null value for any input fields
    3. Logging

      • Log JSON schema has changed
      • Log type names have changed

Minor spelling and grammar corrections.
@JensColman JensColman requested a review from a team as a code owner October 18, 2022 19:52
@hasura-bot
Copy link
Contributor

Beep boop! 🤖

Hey @JensColman, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! 😎

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

hasura-bot added a commit that referenced this pull request Oct 24, 2022
GITHUB_PR_NUMBER: 9125
GITHUB_PR_URL: #9125

PR-URL: hasura/graphql-engine-mono#6428
Co-authored-by: JensColman <19571117+JensColman@users.noreply.github.com>
GitOrigin-RevId: e577d1b6e4fdff2d8d870f2fb0d9715ae7dcfbec
@hasura-bot hasura-bot closed this Oct 24, 2022
@hasura-bot
Copy link
Contributor

Beep boop! 🤖

GIF

Awesome work @JensColman!

Your changes were merged successfully. All of us at Hasura ❤️ what you did.

Thanks again 🤗

@JensColman JensColman deleted the patch-1 branch October 24, 2022 17:50
@Stefmore02 Stefmore02 added hacktoberfest-accepted Valid hacktoberfest PR and removed hacktoberfest-accepted Valid hacktoberfest PR labels Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants