Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in remote-schemas overview #9520

Closed
wants to merge 2 commits into from
Closed

Fix typo in remote-schemas overview #9520

wants to merge 2 commits into from

Conversation

jahirfiquitiva
Copy link
Contributor

No description provided.

@jahirfiquitiva jahirfiquitiva requested a review from a team as a code owner March 24, 2023 01:14
@hasura-bot
Copy link
Contributor

Beep boop! 🤖

Hey @jahirfiquitiva, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! 😎

@CLAassistant
Copy link

CLAassistant commented Mar 24, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

psramkumar
psramkumar approved these changes Apr 14, 2023
View reviewed changes
Copy link

@psramkumar psramkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no harm in accepting this PR

robertjdominguez
robertjdominguez approved these changes Apr 16, 2023
View reviewed changes
Copy link
Contributor

@robertjdominguez robertjdominguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, and sorry for the delay, @jahirfiquitiva 🙌

hasura-bot added a commit that referenced this pull request May 11, 2023
@hasura-bot @jahirfiquitiva
docs: fix typo in remote-schemas overview
ae14af3 
GITHUB_PR_NUMBER: 9520
GITHUB_PR_URL: #9520

PR-URL: hasura/graphql-engine-mono#9128
Co-authored-by: Jahir Fiquitiva <10360816+jahirfiquitiva@users.noreply.github.com>
GitOrigin-RevId: 4e69199664540df711f6086c9f314e1b57bf5b0b
@hasura-bot hasura-bot closed this May 11, 2023
@hasura-bot
Copy link
Contributor

Beep boop! 🤖

GIF

Awesome work @jahirfiquitiva!

Your changes were merged successfully. All of us at Hasura ❤️ what you did.

Thanks again 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psramkumar psramkumar psramkumar approved these changes

@robertjdominguez robertjdominguez robertjdominguez approved these changes

Assignees
No one assigned
Labels
merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jahirfiquitiva @hasura-bot @CLAassistant @psramkumar @robertjdominguez