Fix mapping of aggregate functions in v3->v2 query translation #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hallettj
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR fixes the incorrect mapping of aggregation functions in the v3->v2 query translation logic. The code was incorrectly trying to find the aggregation function in the native query functions data structure instead of looking up the aggregate function off of the scalar type in the NDC schema.
This broken logic was the cause of some of the failing ndc-test tests.
This PR also fixes the Nix config for running ndc-test, which was lacking a dependency from the test suite container to the MongoDB container, which caused the MongoDB container to not start when the tests started.
The direnv config has been modified to actually activate the Nix flake, because that was the point of it in the first place. 😄