fix: insert nulls in place of missing database document fields #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hallettj
requested review from
codedmart,
sordina,
daniel-chambers and
dmoverton
dmoverton
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a problem where a missing requested field on any database document would lead to an internal error in the engine. It turns out that in
$replaceWithstages fields with missing values are silently omitted from response documents.This change adds
$ifNullchecks which insertnullvalues in such cases.$ifNullchecks for either null or missing values, and the checks are written to put in an explicitnullvalue in either case.Thankfully I was able to record a macro to help update the test cases!
Ticket: https://hasurahq.atlassian.net/browse/MDB-90