Run all unit tests on CI. #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were only running a subset of unit tests on CI. Instead of trying to list the (growing) package names, let's just filter out the database tests. This also updates the snapshots to include the new connection URI default value, as these tests were failing.
soupi
reviewed
Jun 24, 2024
There was a problem hiding this comment.
Very nice. I assume the tests are failing because we didn't start the relevant databases for the configuration tests. We could:
- Start them in the "test-unit", or
- Add them to "test-ndc-postgres-with-database", or
- Create a separate job for them
I think (2) or (3) are better than (1).
|
@soupi, I have moved the CLI and configuration tests causing problems into |
|
@SamirTalwar test unit do not seem to be running. Probably need to change the name of the test in github settings? |
|
I've made the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
We were only running a subset of unit tests on CI. Let's run all of them.
How
Instead of trying to list the (growing) package names, let's just filter out the database tests.
This also updates the snapshots to include the new connection URI default value, as these tests were failing.
I had to move some tests into the databases-tests package as they weren't really unit tests.