Skip to content

Commit

Permalink
chore(frontend/app): switch to pnpm
Browse files Browse the repository at this point in the history
  • Loading branch information
steebchen committed Dec 30, 2023
1 parent 2231f4a commit d0426d5
Show file tree
Hide file tree
Showing 6 changed files with 5,615 additions and 8,390 deletions.
22 changes: 16 additions & 6 deletions .github/workflows/app.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,19 @@ jobs:
steps:
- name: Clone repository
uses: actions/checkout@v4
- name: Setup pnpm
uses: pnpm/action-setup@v2
with:
version: 8
run_install: false
- name: Setup Node.js
uses: actions/setup-node@v4
with:
cache: npm
cache-dependency-path: frontend/app/package-lock.json
cache: pnpm
cache-dependency-path: frontend/app/pnpm-lock.yaml
- name: Install dependencies
working-directory: frontend/app
run: npm ci
run: pnpm install --frozen-lockfile
- name: Lint
working-directory: frontend/app
run: npm run lint:check
Expand All @@ -23,14 +28,19 @@ jobs:
steps:
- name: Clone repository
uses: actions/checkout@v4
- name: Setup pnpm
uses: pnpm/action-setup@v2
with:
version: 8
run_install: false
- name: Setup Node.js
uses: actions/setup-node@v4
with:
cache: npm
cache-dependency-path: frontend/app/package-lock.json
cache: pnpm
cache-dependency-path: frontend/app/pnpm-lock.yaml
- name: Install dependencies
working-directory: frontend/app
run: npm ci
run: pnpm install --frozen-lockfile
- name: Lint
working-directory: frontend/app
run: npm run build
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

1. Spin up Postgres and RabbitMQ: `docker-compose up -d`

2. Run `npm install` inside of `./frontend/app`.
2. Run `pnpm install` inside of `./frontend/app`.

3. Generate certificates needed for communicating between the Hatchet client and engine: `task generate-certs`

Expand Down
4 changes: 2 additions & 2 deletions build/package/frontend.dockerfile
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
FROM node:18-alpine as build

WORKDIR /app
COPY ./frontend/app/package.json ./frontend/app/package-lock.json ./
RUN npm ci
COPY ./frontend/app/package.json ./frontend/app/pnpm-lock.yaml ./
RUN pnpm install
COPY ./frontend/app ./
RUN npm run build

Expand Down
Loading

0 comments on commit d0426d5

Please sign in to comment.