Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(frontend/app): switch to pnpm #36

Merged
merged 1 commit into from
Dec 31, 2023
Merged

chore(frontend/app): switch to pnpm #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions .github/workflows/app.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,19 @@ jobs:
steps:
- name: Clone repository
uses: actions/checkout@v4
- name: Setup pnpm
uses: pnpm/action-setup@v2
with:
version: 8
run_install: false
- name: Setup Node.js
uses: actions/setup-node@v4
with:
cache: npm
cache-dependency-path: frontend/app/package-lock.json
cache: pnpm
cache-dependency-path: frontend/app/pnpm-lock.yaml
- name: Install dependencies
working-directory: frontend/app
run: npm ci
run: pnpm install --frozen-lockfile
- name: Lint
working-directory: frontend/app
run: npm run lint:check
Expand All @@ -23,14 +28,19 @@ jobs:
steps:
- name: Clone repository
uses: actions/checkout@v4
- name: Setup pnpm
uses: pnpm/action-setup@v2
with:
version: 8
run_install: false
- name: Setup Node.js
uses: actions/setup-node@v4
with:
cache: npm
cache-dependency-path: frontend/app/package-lock.json
cache: pnpm
cache-dependency-path: frontend/app/pnpm-lock.yaml
- name: Install dependencies
working-directory: frontend/app
run: npm ci
- name: Lint
run: pnpm install --frozen-lockfile
- name: Build
working-directory: frontend/app
run: npm run build
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

1. Spin up Postgres and RabbitMQ: `docker-compose up -d`

2. Run `npm install` inside of `./frontend/app`.
2. Run `pnpm install` inside of `./frontend/app`.

3. Generate certificates needed for communicating between the Hatchet client and engine: `task generate-certs`

Expand Down
4 changes: 2 additions & 2 deletions build/package/frontend.dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
FROM node:18-alpine as build

WORKDIR /app
COPY ./frontend/app/package.json ./frontend/app/package-lock.json ./
RUN npm ci
COPY ./frontend/app/package.json ./frontend/app/pnpm-lock.yaml ./
RUN pnpm install
COPY ./frontend/app ./
RUN npm run build

Expand Down
Loading