-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[osal]Add rt-thread script support. #2599
Conversation
Thanks for your PR but it's more like an example configuration which should be added to rt-thread instead of tinyusb. With your macro it only make things more complicate, more conditions need to check and only CDC+MSC is supported, what if someone simply wants 2*CDC ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/
is for tinyusb stack code, lots of pr's files are framework glue codes and does not belong to src/ folder. If rtthread needs these glue code to run, you can put it into lib/
instead.
Hello, by doing this you can add the tinyusb repo as the rtthread package to the project. This form is similar to the LVGL project: https://github.com/lvgl/lvgl/tree/master/env_support/rt-thread |
OK,I'll modify it. |
d34644f
to
33dd98e
Compare
Tinyusb has much more configurations than LVGL, it's impossible to cover every use case in a single For example if you compare These files should be removed. |
It has been modified, please take a look again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed a fix for pre-commmit. Look good, note that since I don't ( know how to) use rtthread yet, I won't be able to maintain the code, please submit PR to help keep it up to date.
No problem, I am an official member of rtthread and can help you maintain it. |
…ojects.
Describe the PR
Add rtthread script support to better integrate into rtthread projects.
Tinyusb will be added to the rtthread project in the form of a software package.
Additional context
If applicable, add any other context about the PR and/or screenshots here.