fix race condition that could cause drop packet of Bulk OUT transfer #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NRF_USBD->SIZE.EPOUT[epnum] only need to write once to enable Bulk/Interrupt transfer. We only need to do it in dcd_edpt_open() and dcd_edpt_clear_stall()
|
Running repeats successfully for an hour now - looks good to me. Good job on the quick fix. |
I am looking to your final number. Btw, the race condition probably get worse with the zero length packet. CDC host driver normally will send ZLP when all data is sent and is multiple of 64 (endpoint size). Hope we finally fix the issue. |
|
OK, I will run my repeat script overnight tonight and send you the result tomorrow morning.
On Mar 18, 2021, at 10:26 AM, Ha Thach ***@***.******@***.***>> wrote:
Running repeats successfully for an hour now - looks good to me. Good job on the quick fix.
I am looking to your final number. Btw, the race condition probably get worse with the zero length packet. CDC host driver normally will send ZLP when all data is sent and is multiple of 64 (endpoint size). Hope we finally fix the issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#733 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AI4S5NOBGCFVBW3UHHCTJS3TEIZWBANCNFSM4ZMD2KVA>.
|
|
1 hours is good enough for me, don't leave it running too long, it could degrade your nrf flash |
|
OK, just finished a little more than 1 hour of repeats - 110 trials, no failures. Looks good to me
On Mar 18, 2021, at 10:31 AM, Ha Thach ***@***.******@***.***>> wrote:
1 hours is good enough for me, don't leave it running too long, it could degrade your nrf flash
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#733 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AI4S5NO7IS6HP65NZA5CF5LTEI2HLANCNFSM4ZMD2KVA>.
|
|
@khpeterson thank you very much for testing and raising this very hard to catch issue 👍 |
This was referenced Mar 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
related to #723, fix issue raised by adafruit/Adafruit_nRF52_Bootloader#195.
@khpeterson I have tested and tried it with your dfu file. Seem to work well without blocking wait. Would you mind trying this out.