Use healthcheck instead of wait-for #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, remove extra docker-compose.test.yml
|
@mwarin I think all the race condition issues we were seeing were in |
mwarin
approved these changes
May 24, 2024
| @@ -71,16 +111,25 @@ services: | |||
| MINIO_ACCESS_KEY: TESTINGACCESSKEY | |||
| MINIO_SECRET_KEY: testingsecretkey | |||
| command: server /data | |||
| healthcheck: | |||
| <<: *healthcheck-defaults | |||
There was a problem hiding this comment.
Could minio and pushgateway health checks use the same tool (curl/get) to call the thing they are calling?
There was a problem hiding this comment.
Sadly, no, because the health check runs in the containers, and those containers are built off of different base images and include different things prom/pushgateway is built off of busybox and minio/minio appears to be built off of some kind of minimal RHEL thing.
aelkiss@byrd:~$ docker run --rm -ti --entrypoint /bin/bash minio/minio
bash-5.1# curl
curl: try 'curl --help' for more information
bash-5.1# wget
bash: wget: command not found
aelkiss@byrd:~$ docker run --rm -ti --entrypoint /bin/sh prom/pushgateway
/pushgateway $ curl
/bin/sh: curl: not found
/pushgateway $ wget
BusyBox v1.36.1 (2023-12-04 22:44:12 UTC) multi-call binary.
Usage: wget [-cqS] [--spider] [-O FILE] [-o LOGFILE] [--header STR]
...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, remove extra docker-compose.test.yml