-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add quotes on generated variables to avoid braking with spaces #2538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
please rebase and commit to dev branch, thanks |
pkishino
added a commit
that referenced
this pull request
Apr 15, 2023
* Quoute variables, fixes #2406 and #2418 * Fix sed busy (#2426) * fix sed device or resource busy errors Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> * update info Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> * update docs Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> * log and fail if config is a mountpoint Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> * correct mountpoint check Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> * Fix fallback of transmission-home #2409 * Fix to use iptables-legacy rather than iptables-nft (#2456) * Fix bug: the evironment file will be invalid (#2496) something environment like: `name=foo bar` will be invalid in the environment file, in a real example, it will be like `provider= SE Sto`. Simply add change it to `provider="SE Sto"` will fix that. * restart privoxy if docker changed eth0 address. (#2494) * restart privoxy if docker changed eth0 address. * sometimes, pidfile exists but process is dead * Simplify RPC creds setup (#2480) Reduce the complexity associated with creating RPC creds * Fix bitwise decimal & octal (#2457) * Fix bitwise decimal & octal The issue is tracked here: #2450 (comment) Also uses the TRASNMSISSION_UMASK variable instead of settings.json since updateSettings.py is called after userSetup.sh causing the TRANSMISSION_UMASK in settings.json to be stale when userSetup.sh accesses it. * fix: missing {} in sh variable * fix: missing {} in sh variable * fix regex for webproxy enabled (#2505) * review nordvpn error exit messages + tests (#2518) * Check for files existing instead of being executable #2459 * Bump docker/build-push-action from 3 to 4 (#2522) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: Add quotes on generated variables to avoid braking with spaces (#2538) This should fix #2406 * Fix crash in fetch-external-configs on unset vars (#2561) * simple adjustments to "openvpn/modify-openvpn-config.sh" and "transmission/start.sh" that can make the verbosity of logging user-adjustable (#2564) * Bump docker/build-push-action from 3 to 4 (#2534) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Socks5 example doc (#2541) * fixing some heading sizes * adding socks5-proxy example --------- Co-authored-by: Jonathan Fair <jonathaf@netapp.com> * Docs: add capabilities for Podman to tips&tricks (#2546) Co-authored-by: Tomas Vik <tvik@gitlab.com> * Change CONFIG_MOD_VERBOSITY usage This change causes ${CONFIG_MOD_VERBOSITY} to become a variable used directly in the .ovpn config file. The default value remains '3'. * Insert ${TRANSMISSION_LOGGING} into exec'd command This change allows for executing 'transmission-daemon' with '--log-level' set. Utilizing a case-statement and forced lowercase, only valid values are accepted. Default is no logging. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JtMotoX <7191259+JtMotoX@users.noreply.github.com> Co-authored-by: Jonathan Fair <jonathaf@netapp.com> Co-authored-by: Patrick Kishino <patrick.a.kishino@gmail.com> Co-authored-by: Tomas Vik <tvik@gitlab.com> * OVPN script fix for for 4.x branch (#2566) * Bump docker/build-push-action from 3 to 4 (#2534) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Socks5 example doc (#2541) * fixing some heading sizes * adding socks5-proxy example --------- Co-authored-by: Jonathan Fair <jonathaf@netapp.com> * Docs: add capabilities for Podman to tips&tricks (#2546) Co-authored-by: Tomas Vik <tvik@gitlab.com> * git instead of unzip git instead of unzip * Using GIT GIT is used now instead of UNZIP due to issues suddenly experienced. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JtMotoX <7191259+JtMotoX@users.noreply.github.com> Co-authored-by: Jonathan Fair <jonathaf@netapp.com> Co-authored-by: Patrick Kishino <patrick.a.kishino@gmail.com> Co-authored-by: Tomas Vik <tvik@gitlab.com> --------- Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Kristian Haugene <kristian@haugene.net> Co-authored-by: Jonathan Sloan <jsloan117@gmail.com> Co-authored-by: Robert Szynal <RJSzynal@Gmail.com> Co-authored-by: Jiangqiu Shen <ivy22233qiu@live.com> Co-authored-by: edgd1er <edgd1er@hotmail.com> Co-authored-by: Colin Hebert <active.luck0981@dedicated.contact> Co-authored-by: J.P. Hutchins <34154542+JPHutchins@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jayson Reis <santosdosreis@gmail.com> Co-authored-by: Chad <github@chad.org> Co-authored-by: phesster <115180691+phesster@users.noreply.github.com> Co-authored-by: JtMotoX <7191259+JtMotoX@users.noreply.github.com> Co-authored-by: Jonathan Fair <jonathaf@netapp.com> Co-authored-by: Tomas Vik <tvik@gitlab.com> Co-authored-by: Derek Gordon <derek@derekgordon.com>
pkishino
added a commit
that referenced
this pull request
Apr 15, 2023
* Quoute variables, fixes #2406 and #2418 * Fix sed busy (#2426) * fix sed device or resource busy errors * update info * update docs * log and fail if config is a mountpoint * correct mountpoint check * Fix fallback of transmission-home #2409 * Fix to use iptables-legacy rather than iptables-nft (#2456) * Fix bug: the evironment file will be invalid (#2496) something environment like: `name=foo bar` will be invalid in the environment file, in a real example, it will be like `provider= SE Sto`. Simply add change it to `provider="SE Sto"` will fix that. * restart privoxy if docker changed eth0 address. (#2494) * restart privoxy if docker changed eth0 address. * sometimes, pidfile exists but process is dead * Simplify RPC creds setup (#2480) Reduce the complexity associated with creating RPC creds * Fix bitwise decimal & octal (#2457) * Fix bitwise decimal & octal The issue is tracked here: #2450 (comment) Also uses the TRASNMSISSION_UMASK variable instead of settings.json since updateSettings.py is called after userSetup.sh causing the TRANSMISSION_UMASK in settings.json to be stale when userSetup.sh accesses it. * fix: missing {} in sh variable * fix: missing {} in sh variable * fix regex for webproxy enabled (#2505) * review nordvpn error exit messages + tests (#2518) * Check for files existing instead of being executable #2459 * Bump docker/build-push-action from 3 to 4 (#2522) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... * fix: Add quotes on generated variables to avoid braking with spaces (#2538) This should fix #2406 * Fix crash in fetch-external-configs on unset vars (#2561) * simple adjustments to "openvpn/modify-openvpn-config.sh" and "transmission/start.sh" that can make the verbosity of logging user-adjustable (#2564) * Bump docker/build-push-action from 3 to 4 (#2534) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... * Socks5 example doc (#2541) * fixing some heading sizes * adding socks5-proxy example --------- * Docs: add capabilities for Podman to tips&tricks (#2546) * Change CONFIG_MOD_VERBOSITY usage This change causes ${CONFIG_MOD_VERBOSITY} to become a variable used directly in the .ovpn config file. The default value remains '3'. * Insert ${TRANSMISSION_LOGGING} into exec'd command This change allows for executing 'transmission-daemon' with '--log-level' set. Utilizing a case-statement and forced lowercase, only valid values are accepted. Default is no logging. --------- * OVPN script fix for for 4.x branch (#2566) * Bump docker/build-push-action from 3 to 4 (#2534) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... * Socks5 example doc (#2541) * fixing some heading sizes * adding socks5-proxy example --------- * Docs: add capabilities for Podman to tips&tricks (#2546) * git instead of unzip git instead of unzip * Using GIT GIT is used now instead of UNZIP due to issues suddenly experienced. --------- --------- Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Kristian Haugene <kristian@haugene.net> Co-authored-by: Jonathan Sloan <jsloan117@gmail.com> Co-authored-by: Robert Szynal <RJSzynal@Gmail.com> Co-authored-by: Jiangqiu Shen <ivy22233qiu@live.com> Co-authored-by: edgd1er <edgd1er@hotmail.com> Co-authored-by: Colin Hebert <active.luck0981@dedicated.contact> Co-authored-by: J.P. Hutchins <34154542+JPHutchins@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jayson Reis <santosdosreis@gmail.com> Co-authored-by: Chad <github@chad.org> Co-authored-by: phesster <115180691+phesster@users.noreply.github.com> Co-authored-by: JtMotoX <7191259+JtMotoX@users.noreply.github.com> Co-authored-by: Jonathan Fair <jonathaf@netapp.com> Co-authored-by: Tomas Vik <tvik@gitlab.com> Co-authored-by: Derek Gordon <derek@derekgordon.com>
pkishino
added a commit
that referenced
this pull request
Apr 15, 2023
* Quoute variables, fixes #2406 and #2418 * Fix sed busy (#2426) * fix sed device or resource busy errors Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> * update info Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> * update docs Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> * log and fail if config is a mountpoint Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> * correct mountpoint check Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> * Fix fallback of transmission-home #2409 * Fix to use iptables-legacy rather than iptables-nft (#2456) * Fix bug: the evironment file will be invalid (#2496) something environment like: `name=foo bar` will be invalid in the environment file, in a real example, it will be like `provider= SE Sto`. Simply add change it to `provider="SE Sto"` will fix that. * restart privoxy if docker changed eth0 address. (#2494) * restart privoxy if docker changed eth0 address. * sometimes, pidfile exists but process is dead * Simplify RPC creds setup (#2480) Reduce the complexity associated with creating RPC creds * Fix bitwise decimal & octal (#2457) * Fix bitwise decimal & octal The issue is tracked here: #2450 (comment) Also uses the TRASNMSISSION_UMASK variable instead of settings.json since updateSettings.py is called after userSetup.sh causing the TRANSMISSION_UMASK in settings.json to be stale when userSetup.sh accesses it. * fix: missing {} in sh variable * fix: missing {} in sh variable * fix regex for webproxy enabled (#2505) * review nordvpn error exit messages + tests (#2518) * Check for files existing instead of being executable #2459 * Bump docker/build-push-action from 3 to 4 (#2522) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: Add quotes on generated variables to avoid braking with spaces (#2538) This should fix #2406 * Fix crash in fetch-external-configs on unset vars (#2561) * simple adjustments to "openvpn/modify-openvpn-config.sh" and "transmission/start.sh" that can make the verbosity of logging user-adjustable (#2564) * Bump docker/build-push-action from 3 to 4 (#2534) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Socks5 example doc (#2541) * fixing some heading sizes * adding socks5-proxy example --------- Co-authored-by: Jonathan Fair <jonathaf@netapp.com> * Docs: add capabilities for Podman to tips&tricks (#2546) Co-authored-by: Tomas Vik <tvik@gitlab.com> * Change CONFIG_MOD_VERBOSITY usage This change causes ${CONFIG_MOD_VERBOSITY} to become a variable used directly in the .ovpn config file. The default value remains '3'. * Insert ${TRANSMISSION_LOGGING} into exec'd command This change allows for executing 'transmission-daemon' with '--log-level' set. Utilizing a case-statement and forced lowercase, only valid values are accepted. Default is no logging. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JtMotoX <7191259+JtMotoX@users.noreply.github.com> Co-authored-by: Jonathan Fair <jonathaf@netapp.com> Co-authored-by: Patrick Kishino <patrick.a.kishino@gmail.com> Co-authored-by: Tomas Vik <tvik@gitlab.com> * OVPN script fix for for 4.x branch (#2566) * Bump docker/build-push-action from 3 to 4 (#2534) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Socks5 example doc (#2541) * fixing some heading sizes * adding socks5-proxy example --------- Co-authored-by: Jonathan Fair <jonathaf@netapp.com> * Docs: add capabilities for Podman to tips&tricks (#2546) Co-authored-by: Tomas Vik <tvik@gitlab.com> * git instead of unzip git instead of unzip * Using GIT GIT is used now instead of UNZIP due to issues suddenly experienced. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JtMotoX <7191259+JtMotoX@users.noreply.github.com> Co-authored-by: Jonathan Fair <jonathaf@netapp.com> Co-authored-by: Patrick Kishino <patrick.a.kishino@gmail.com> Co-authored-by: Tomas Vik <tvik@gitlab.com> * Update master with latest dev fixes (#2579) (#2582) * Quoute variables, fixes #2406 and #2418 * Fix sed busy (#2426) * fix sed device or resource busy errors * update info * update docs * log and fail if config is a mountpoint * correct mountpoint check * Fix fallback of transmission-home #2409 * Fix to use iptables-legacy rather than iptables-nft (#2456) * Fix bug: the evironment file will be invalid (#2496) something environment like: `name=foo bar` will be invalid in the environment file, in a real example, it will be like `provider= SE Sto`. Simply add change it to `provider="SE Sto"` will fix that. * restart privoxy if docker changed eth0 address. (#2494) * restart privoxy if docker changed eth0 address. * sometimes, pidfile exists but process is dead * Simplify RPC creds setup (#2480) Reduce the complexity associated with creating RPC creds * Fix bitwise decimal & octal (#2457) * Fix bitwise decimal & octal The issue is tracked here: #2450 (comment) Also uses the TRASNMSISSION_UMASK variable instead of settings.json since updateSettings.py is called after userSetup.sh causing the TRANSMISSION_UMASK in settings.json to be stale when userSetup.sh accesses it. * fix: missing {} in sh variable * fix: missing {} in sh variable * fix regex for webproxy enabled (#2505) * review nordvpn error exit messages + tests (#2518) * Check for files existing instead of being executable #2459 * Bump docker/build-push-action from 3 to 4 (#2522) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... * fix: Add quotes on generated variables to avoid braking with spaces (#2538) This should fix #2406 * Fix crash in fetch-external-configs on unset vars (#2561) * simple adjustments to "openvpn/modify-openvpn-config.sh" and "transmission/start.sh" that can make the verbosity of logging user-adjustable (#2564) * Bump docker/build-push-action from 3 to 4 (#2534) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... * Socks5 example doc (#2541) * fixing some heading sizes * adding socks5-proxy example --------- * Docs: add capabilities for Podman to tips&tricks (#2546) * Change CONFIG_MOD_VERBOSITY usage This change causes ${CONFIG_MOD_VERBOSITY} to become a variable used directly in the .ovpn config file. The default value remains '3'. * Insert ${TRANSMISSION_LOGGING} into exec'd command This change allows for executing 'transmission-daemon' with '--log-level' set. Utilizing a case-statement and forced lowercase, only valid values are accepted. Default is no logging. --------- * OVPN script fix for for 4.x branch (#2566) * Bump docker/build-push-action from 3 to 4 (#2534) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... * Socks5 example doc (#2541) * fixing some heading sizes * adding socks5-proxy example --------- * Docs: add capabilities for Podman to tips&tricks (#2546) * git instead of unzip git instead of unzip * Using GIT GIT is used now instead of UNZIP due to issues suddenly experienced. --------- --------- Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Kristian Haugene <kristian@haugene.net> Co-authored-by: Jonathan Sloan <jsloan117@gmail.com> Co-authored-by: Robert Szynal <RJSzynal@Gmail.com> Co-authored-by: Jiangqiu Shen <ivy22233qiu@live.com> Co-authored-by: edgd1er <edgd1er@hotmail.com> Co-authored-by: Colin Hebert <active.luck0981@dedicated.contact> Co-authored-by: J.P. Hutchins <34154542+JPHutchins@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jayson Reis <santosdosreis@gmail.com> Co-authored-by: Chad <github@chad.org> Co-authored-by: phesster <115180691+phesster@users.noreply.github.com> Co-authored-by: JtMotoX <7191259+JtMotoX@users.noreply.github.com> Co-authored-by: Jonathan Fair <jonathaf@netapp.com> Co-authored-by: Tomas Vik <tvik@gitlab.com> Co-authored-by: Derek Gordon <derek@derekgordon.com> --------- Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Kristian Haugene <kristian@haugene.net> Co-authored-by: Jonathan Sloan <jsloan117@gmail.com> Co-authored-by: Robert Szynal <RJSzynal@Gmail.com> Co-authored-by: Jiangqiu Shen <ivy22233qiu@live.com> Co-authored-by: edgd1er <edgd1er@hotmail.com> Co-authored-by: Colin Hebert <active.luck0981@dedicated.contact> Co-authored-by: J.P. Hutchins <34154542+JPHutchins@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jayson Reis <santosdosreis@gmail.com> Co-authored-by: Chad <github@chad.org> Co-authored-by: phesster <115180691+phesster@users.noreply.github.com> Co-authored-by: JtMotoX <7191259+JtMotoX@users.noreply.github.com> Co-authored-by: Jonathan Fair <jonathaf@netapp.com> Co-authored-by: Tomas Vik <tvik@gitlab.com> Co-authored-by: Derek Gordon <derek@derekgordon.com>
pkishino
added a commit
that referenced
this pull request
Apr 16, 2023
* Bump docker/build-push-action from 3 to 4 (#2522) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump docker/build-push-action from 3 to 4 (#2534) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Socks5 example doc (#2541) * fixing some heading sizes * adding socks5-proxy example --------- Co-authored-by: Jonathan Fair <jonathaf@netapp.com> * Docs: add capabilities for Podman to tips&tricks (#2546) Co-authored-by: Tomas Vik <tvik@gitlab.com> * fix: Add quotes on generated variables to avoid braking with spaces (#2538) This should fix #2406 * Fix crash in fetch-external-configs on unset vars (#2561) * simple adjustments to "openvpn/modify-openvpn-config.sh" and "transmission/start.sh" that can make the verbosity of logging user-adjustable (#2564) * Bump docker/build-push-action from 3 to 4 (#2534) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Socks5 example doc (#2541) * fixing some heading sizes * adding socks5-proxy example --------- Co-authored-by: Jonathan Fair <jonathaf@netapp.com> * Docs: add capabilities for Podman to tips&tricks (#2546) Co-authored-by: Tomas Vik <tvik@gitlab.com> * Change CONFIG_MOD_VERBOSITY usage This change causes ${CONFIG_MOD_VERBOSITY} to become a variable used directly in the .ovpn config file. The default value remains '3'. * Insert ${TRANSMISSION_LOGGING} into exec'd command This change allows for executing 'transmission-daemon' with '--log-level' set. Utilizing a case-statement and forced lowercase, only valid values are accepted. Default is no logging. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JtMotoX <7191259+JtMotoX@users.noreply.github.com> Co-authored-by: Jonathan Fair <jonathaf@netapp.com> Co-authored-by: Patrick Kishino <patrick.a.kishino@gmail.com> Co-authored-by: Tomas Vik <tvik@gitlab.com> * Update master with Transmission 4 (#2576) * Image with Transmission 4.0.0-beta * Build in separate stage * Updated to beta2 * Update Dockerfile * Updated transmission to 4.0.0 release * Update Dockerfile * update beta (#2554) * Bump docker/build-push-action from 3 to 4 (#2534) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Socks5 example doc (#2541) * fixing some heading sizes * adding socks5-proxy example --------- Co-authored-by: Jonathan Fair <jonathaf@netapp.com> * Docs: add capabilities for Podman to tips&tricks (#2546) Co-authored-by: Tomas Vik <tvik@gitlab.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JtMotoX <7191259+JtMotoX@users.noreply.github.com> Co-authored-by: Jonathan Fair <jonathaf@netapp.com> Co-authored-by: Tomas Vik <tvik@gitlab.com> * Update Dockerfile 4.0.2 * Update configure-openvpn.sh (#2567) Same changes to master going to beta for beta tests w latest Transmission * Transmission->4.0.3 * prep new master (#2575) * Bump docker/build-push-action from 3 to 4 (#2534) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Socks5 example doc (#2541) * fixing some heading sizes * adding socks5-proxy example --------- Co-authored-by: Jonathan Fair <jonathaf@netapp.com> * Docs: add capabilities for Podman to tips&tricks (#2546) Co-authored-by: Tomas Vik <tvik@gitlab.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JtMotoX <7191259+JtMotoX@users.noreply.github.com> Co-authored-by: Jonathan Fair <jonathaf@netapp.com> Co-authored-by: Tomas Vik <tvik@gitlab.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Kristian Haugene <kristian@haugene.net> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JtMotoX <7191259+JtMotoX@users.noreply.github.com> Co-authored-by: Jonathan Fair <jonathaf@netapp.com> Co-authored-by: Tomas Vik <tvik@gitlab.com> Co-authored-by: Derek Gordon <derek@derekgordon.com> * OVPN script fix for for 4.x branch (#2566) * Bump docker/build-push-action from 3 to 4 (#2534) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Socks5 example doc (#2541) * fixing some heading sizes * adding socks5-proxy example --------- Co-authored-by: Jonathan Fair <jonathaf@netapp.com> * Docs: add capabilities for Podman to tips&tricks (#2546) Co-authored-by: Tomas Vik <tvik@gitlab.com> * git instead of unzip git instead of unzip * Using GIT GIT is used now instead of UNZIP due to issues suddenly experienced. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JtMotoX <7191259+JtMotoX@users.noreply.github.com> Co-authored-by: Jonathan Fair <jonathaf@netapp.com> Co-authored-by: Patrick Kishino <patrick.a.kishino@gmail.com> Co-authored-by: Tomas Vik <tvik@gitlab.com> * Update docker-image-builds.yml Removed deleted beta branch * Update Dockerfile Removed beta reference * Update master with latest dev fixes (#2579) * Quoute variables, fixes #2406 and #2418 * Fix sed busy (#2426) * fix sed device or resource busy errors Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> * update info Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> * update docs Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> * log and fail if config is a mountpoint Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> * correct mountpoint check Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> * Fix fallback of transmission-home #2409 * Fix to use iptables-legacy rather than iptables-nft (#2456) * Fix bug: the evironment file will be invalid (#2496) something environment like: `name=foo bar` will be invalid in the environment file, in a real example, it will be like `provider= SE Sto`. Simply add change it to `provider="SE Sto"` will fix that. * restart privoxy if docker changed eth0 address. (#2494) * restart privoxy if docker changed eth0 address. * sometimes, pidfile exists but process is dead * Simplify RPC creds setup (#2480) Reduce the complexity associated with creating RPC creds * Fix bitwise decimal & octal (#2457) * Fix bitwise decimal & octal The issue is tracked here: #2450 (comment) Also uses the TRASNMSISSION_UMASK variable instead of settings.json since updateSettings.py is called after userSetup.sh causing the TRANSMISSION_UMASK in settings.json to be stale when userSetup.sh accesses it. * fix: missing {} in sh variable * fix: missing {} in sh variable * fix regex for webproxy enabled (#2505) * review nordvpn error exit messages + tests (#2518) * Check for files existing instead of being executable #2459 * Bump docker/build-push-action from 3 to 4 (#2522) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: Add quotes on generated variables to avoid braking with spaces (#2538) This should fix #2406 * Fix crash in fetch-external-configs on unset vars (#2561) * simple adjustments to "openvpn/modify-openvpn-config.sh" and "transmission/start.sh" that can make the verbosity of logging user-adjustable (#2564) * Bump docker/build-push-action from 3 to 4 (#2534) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Socks5 example doc (#2541) * fixing some heading sizes * adding socks5-proxy example --------- Co-authored-by: Jonathan Fair <jonathaf@netapp.com> * Docs: add capabilities for Podman to tips&tricks (#2546) Co-authored-by: Tomas Vik <tvik@gitlab.com> * Change CONFIG_MOD_VERBOSITY usage This change causes ${CONFIG_MOD_VERBOSITY} to become a variable used directly in the .ovpn config file. The default value remains '3'. * Insert ${TRANSMISSION_LOGGING} into exec'd command This change allows for executing 'transmission-daemon' with '--log-level' set. Utilizing a case-statement and forced lowercase, only valid values are accepted. Default is no logging. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JtMotoX <7191259+JtMotoX@users.noreply.github.com> Co-authored-by: Jonathan Fair <jonathaf@netapp.com> Co-authored-by: Patrick Kishino <patrick.a.kishino@gmail.com> Co-authored-by: Tomas Vik <tvik@gitlab.com> * OVPN script fix for for 4.x branch (#2566) * Bump docker/build-push-action from 3 to 4 (#2534) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Socks5 example doc (#2541) * fixing some heading sizes * adding socks5-proxy example --------- Co-authored-by: Jonathan Fair <jonathaf@netapp.com> * Docs: add capabilities for Podman to tips&tricks (#2546) Co-authored-by: Tomas Vik <tvik@gitlab.com> * git instead of unzip git instead of unzip * Using GIT GIT is used now instead of UNZIP due to issues suddenly experienced. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JtMotoX <7191259+JtMotoX@users.noreply.github.com> Co-authored-by: Jonathan Fair <jonathaf@netapp.com> Co-authored-by: Patrick Kishino <patrick.a.kishino@gmail.com> Co-authored-by: Tomas Vik <tvik@gitlab.com> --------- Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Kristian Haugene <kristian@haugene.net> Co-authored-by: Jonathan Sloan <jsloan117@gmail.com> Co-authored-by: Robert Szynal <RJSzynal@Gmail.com> Co-authored-by: Jiangqiu Shen <ivy22233qiu@live.com> Co-authored-by: edgd1er <edgd1er@hotmail.com> Co-authored-by: Colin Hebert <active.luck0981@dedicated.contact> Co-authored-by: J.P. Hutchins <34154542+JPHutchins@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jayson Reis <santosdosreis@gmail.com> Co-authored-by: Chad <github@chad.org> Co-authored-by: phesster <115180691+phesster@users.noreply.github.com> Co-authored-by: JtMotoX <7191259+JtMotoX@users.noreply.github.com> Co-authored-by: Jonathan Fair <jonathaf@netapp.com> Co-authored-by: Tomas Vik <tvik@gitlab.com> Co-authored-by: Derek Gordon <derek@derekgordon.com> * Update master with latest dev fixes (#2579) (#2582) * Quoute variables, fixes #2406 and #2418 * Fix sed busy (#2426) * fix sed device or resource busy errors * update info * update docs * log and fail if config is a mountpoint * correct mountpoint check * Fix fallback of transmission-home #2409 * Fix to use iptables-legacy rather than iptables-nft (#2456) * Fix bug: the evironment file will be invalid (#2496) something environment like: `name=foo bar` will be invalid in the environment file, in a real example, it will be like `provider= SE Sto`. Simply add change it to `provider="SE Sto"` will fix that. * restart privoxy if docker changed eth0 address. (#2494) * restart privoxy if docker changed eth0 address. * sometimes, pidfile exists but process is dead * Simplify RPC creds setup (#2480) Reduce the complexity associated with creating RPC creds * Fix bitwise decimal & octal (#2457) * Fix bitwise decimal & octal The issue is tracked here: #2450 (comment) Also uses the TRASNMSISSION_UMASK variable instead of settings.json since updateSettings.py is called after userSetup.sh causing the TRANSMISSION_UMASK in settings.json to be stale when userSetup.sh accesses it. * fix: missing {} in sh variable * fix: missing {} in sh variable * fix regex for webproxy enabled (#2505) * review nordvpn error exit messages + tests (#2518) * Check for files existing instead of being executable #2459 * Bump docker/build-push-action from 3 to 4 (#2522) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... * fix: Add quotes on generated variables to avoid braking with spaces (#2538) This should fix #2406 * Fix crash in fetch-external-configs on unset vars (#2561) * simple adjustments to "openvpn/modify-openvpn-config.sh" and "transmission/start.sh" that can make the verbosity of logging user-adjustable (#2564) * Bump docker/build-push-action from 3 to 4 (#2534) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... * Socks5 example doc (#2541) * fixing some heading sizes * adding socks5-proxy example --------- * Docs: add capabilities for Podman to tips&tricks (#2546) * Change CONFIG_MOD_VERBOSITY usage This change causes ${CONFIG_MOD_VERBOSITY} to become a variable used directly in the .ovpn config file. The default value remains '3'. * Insert ${TRANSMISSION_LOGGING} into exec'd command This change allows for executing 'transmission-daemon' with '--log-level' set. Utilizing a case-statement and forced lowercase, only valid values are accepted. Default is no logging. --------- * OVPN script fix for for 4.x branch (#2566) * Bump docker/build-push-action from 3 to 4 (#2534) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... * Socks5 example doc (#2541) * fixing some heading sizes * adding socks5-proxy example --------- * Docs: add capabilities for Podman to tips&tricks (#2546) * git instead of unzip git instead of unzip * Using GIT GIT is used now instead of UNZIP due to issues suddenly experienced. --------- --------- Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Kristian Haugene <kristian@haugene.net> Co-authored-by: Jonathan Sloan <jsloan117@gmail.com> Co-authored-by: Robert Szynal <RJSzynal@Gmail.com> Co-authored-by: Jiangqiu Shen <ivy22233qiu@live.com> Co-authored-by: edgd1er <edgd1er@hotmail.com> Co-authored-by: Colin Hebert <active.luck0981@dedicated.contact> Co-authored-by: J.P. Hutchins <34154542+JPHutchins@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jayson Reis <santosdosreis@gmail.com> Co-authored-by: Chad <github@chad.org> Co-authored-by: phesster <115180691+phesster@users.noreply.github.com> Co-authored-by: JtMotoX <7191259+JtMotoX@users.noreply.github.com> Co-authored-by: Jonathan Fair <jonathaf@netapp.com> Co-authored-by: Tomas Vik <tvik@gitlab.com> Co-authored-by: Derek Gordon <derek@derekgordon.com> * Merge dev into master (#2583) * Quoute variables, fixes #2406 and #2418 * Fix sed busy (#2426) * fix sed device or resource busy errors Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> * update info Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> * update docs Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> * log and fail if config is a mountpoint Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> * correct mountpoint check Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> * Fix fallback of transmission-home #2409 * Fix to use iptables-legacy rather than iptables-nft (#2456) * Fix bug: the evironment file will be invalid (#2496) something environment like: `name=foo bar` will be invalid in the environment file, in a real example, it will be like `provider= SE Sto`. Simply add change it to `provider="SE Sto"` will fix that. * restart privoxy if docker changed eth0 address. (#2494) * restart privoxy if docker changed eth0 address. * sometimes, pidfile exists but process is dead * Simplify RPC creds setup (#2480) Reduce the complexity associated with creating RPC creds * Fix bitwise decimal & octal (#2457) * Fix bitwise decimal & octal The issue is tracked here: #2450 (comment) Also uses the TRASNMSISSION_UMASK variable instead of settings.json since updateSettings.py is called after userSetup.sh causing the TRANSMISSION_UMASK in settings.json to be stale when userSetup.sh accesses it. * fix: missing {} in sh variable * fix: missing {} in sh variable * fix regex for webproxy enabled (#2505) * review nordvpn error exit messages + tests (#2518) * Check for files existing instead of being executable #2459 * Bump docker/build-push-action from 3 to 4 (#2522) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: Add quotes on generated variables to avoid braking with spaces (#2538) This should fix #2406 * Fix crash in fetch-external-configs on unset vars (#2561) * simple adjustments to "openvpn/modify-openvpn-config.sh" and "transmission/start.sh" that can make the verbosity of logging user-adjustable (#2564) * Bump docker/build-push-action from 3 to 4 (#2534) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Socks5 example doc (#2541) * fixing some heading sizes * adding socks5-proxy example --------- Co-authored-by: Jonathan Fair <jonathaf@netapp.com> * Docs: add capabilities for Podman to tips&tricks (#2546) Co-authored-by: Tomas Vik <tvik@gitlab.com> * Change CONFIG_MOD_VERBOSITY usage This change causes ${CONFIG_MOD_VERBOSITY} to become a variable used directly in the .ovpn config file. The default value remains '3'. * Insert ${TRANSMISSION_LOGGING} into exec'd command This change allows for executing 'transmission-daemon' with '--log-level' set. Utilizing a case-statement and forced lowercase, only valid values are accepted. Default is no logging. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JtMotoX <7191259+JtMotoX@users.noreply.github.com> Co-authored-by: Jonathan Fair <jonathaf@netapp.com> Co-authored-by: Patrick Kishino <patrick.a.kishino@gmail.com> Co-authored-by: Tomas Vik <tvik@gitlab.com> * OVPN script fix for for 4.x branch (#2566) * Bump docker/build-push-action from 3 to 4 (#2534) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Socks5 example doc (#2541) * fixing some heading sizes * adding socks5-proxy example --------- Co-authored-by: Jonathan Fair <jonathaf@netapp.com> * Docs: add capabilities for Podman to tips&tricks (#2546) Co-authored-by: Tomas Vik <tvik@gitlab.com> * git instead of unzip git instead of unzip * Using GIT GIT is used now instead of UNZIP due to issues suddenly experienced. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JtMotoX <7191259+JtMotoX@users.noreply.github.com> Co-authored-by: Jonathan Fair <jonathaf@netapp.com> Co-authored-by: Patrick Kishino <patrick.a.kishino@gmail.com> Co-authored-by: Tomas Vik <tvik@gitlab.com> * Update master with latest dev fixes (#2579) (#2582) * Quoute variables, fixes #2406 and #2418 * Fix sed busy (#2426) * fix sed device or resource busy errors * update info * update docs * log and fail if config is a mountpoint * correct mountpoint check * Fix fallback of transmission-home #2409 * Fix to use iptables-legacy rather than iptables-nft (#2456) * Fix bug: the evironment file will be invalid (#2496) something environment like: `name=foo bar` will be invalid in the environment file, in a real example, it will be like `provider= SE Sto`. Simply add change it to `provider="SE Sto"` will fix that. * restart privoxy if docker changed eth0 address. (#2494) * restart privoxy if docker changed eth0 address. * sometimes, pidfile exists but process is dead * Simplify RPC creds setup (#2480) Reduce the complexity associated with creating RPC creds * Fix bitwise decimal & octal (#2457) * Fix bitwise decimal & octal The issue is tracked here: #2450 (comment) Also uses the TRASNMSISSION_UMASK variable instead of settings.json since updateSettings.py is called after userSetup.sh causing the TRANSMISSION_UMASK in settings.json to be stale when userSetup.sh accesses it. * fix: missing {} in sh variable * fix: missing {} in sh variable * fix regex for webproxy enabled (#2505) * review nordvpn error exit messages + tests (#2518) * Check for files existing instead of being executable #2459 * Bump docker/build-push-action from 3 to 4 (#2522) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... * fix: Add quotes on generated variables to avoid braking with spaces (#2538) This should fix #2406 * Fix crash in fetch-external-configs on unset vars (#2561) * simple adjustments to "openvpn/modify-openvpn-config.sh" and "transmission/start.sh" that can make the verbosity of logging user-adjustable (#2564) * Bump docker/build-push-action from 3 to 4 (#2534) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... * Socks5 example doc (#2541) * fixing some heading sizes * adding socks5-proxy example --------- * Docs: add capabilities for Podman to tips&tricks (#2546) * Change CONFIG_MOD_VERBOSITY usage This change causes ${CONFIG_MOD_VERBOSITY} to become a variable used directly in the .ovpn config file. The default value remains '3'. * Insert ${TRANSMISSION_LOGGING} into exec'd command This change allows for executing 'transmission-daemon' with '--log-level' set. Utilizing a case-statement and forced lowercase, only valid values are accepted. Default is no logging. --------- * OVPN script fix for for 4.x branch (#2566) * Bump docker/build-push-action from 3 to 4 (#2534) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... * Socks5 example doc (#2541) * fixing some heading sizes * adding socks5-proxy example --------- * Docs: add capabilities for Podman to tips&tricks (#2546) * git instead of unzip git instead of unzip * Using GIT GIT is used now instead of UNZIP due to issues suddenly experienced. --------- --------- Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Kristian Haugene <kristian@haugene.net> Co-authored-by: Jonathan Sloan <jsloan117@gmail.com> Co-authored-by: Robert Szynal <RJSzynal@Gmail.com> Co-authored-by: Jiangqiu Shen <ivy22233qiu@live.com> Co-authored-by: edgd1er <edgd1er@hotmail.com> Co-authored-by: Colin Hebert <active.luck0981@dedicated.contact> Co-authored-by: J.P. Hutchins <34154542+JPHutchins@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jayson Reis <santosdosreis@gmail.com> Co-authored-by: Chad <github@chad.org> Co-authored-by: phesster <115180691+phesster@users.noreply.github.com> Co-authored-by: JtMotoX <7191259+JtMotoX@users.noreply.github.com> Co-authored-by: Jonathan Fair <jonathaf@netapp.com> Co-authored-by: Tomas Vik <tvik@gitlab.com> Co-authored-by: Derek Gordon <derek@derekgordon.com> --------- Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Kristian Haugene <kristian@haugene.net> Co-authored-by: Jonathan Sloan <jsloan117@gmail.com> Co-authored-by: Robert Szynal <RJSzynal@Gmail.com> Co-authored-by: Jiangqiu Shen <ivy22233qiu@live.com> Co-authored-by: edgd1er <edgd1er@hotmail.com> Co-authored-by: Colin Hebert <active.luck0981@dedicated.contact> Co-authored-by: J.P. Hutchins <34154542+JPHutchins@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jayson Reis <santosdosreis@gmail.com> Co-authored-by: Chad <github@chad.org> Co-authored-by: phesster <115180691+phesster@users.noreply.github.com> Co-authored-by: JtMotoX <7191259+JtMotoX@users.noreply.github.com> Co-authored-by: Jonathan Fair <jonathaf@netapp.com> Co-authored-by: Tomas Vik <tvik@gitlab.com> Co-authored-by: Derek Gordon <derek@derekgordon.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JtMotoX <7191259+JtMotoX@users.noreply.github.com> Co-authored-by: Jonathan Fair <jonathaf@netapp.com> Co-authored-by: Tomas Vik <tvik@gitlab.com> Co-authored-by: Jayson Reis <santosdosreis@gmail.com> Co-authored-by: Chad <github@chad.org> Co-authored-by: phesster <115180691+phesster@users.noreply.github.com> Co-authored-by: Kristian Haugene <kristian@haugene.net> Co-authored-by: Derek Gordon <derek@derekgordon.com> Co-authored-by: Jonathan Sloan <jsloan117@gmail.com> Co-authored-by: Robert Szynal <RJSzynal@Gmail.com> Co-authored-by: Jiangqiu Shen <ivy22233qiu@live.com> Co-authored-by: edgd1er <edgd1er@hotmail.com> Co-authored-by: Colin Hebert <active.luck0981@dedicated.contact> Co-authored-by: J.P. Hutchins <34154542+JPHutchins@users.noreply.github.com>
pkishino
added a commit
that referenced
this pull request
Apr 16, 2023
* Bump docker/build-push-action from 3 to 4 (#2522) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump docker/build-push-action from 3 to 4 (#2534) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Socks5 example doc (#2541) * fixing some heading sizes * adding socks5-proxy example --------- Co-authored-by: Jonathan Fair <jonathaf@netapp.com> * Docs: add capabilities for Podman to tips&tricks (#2546) Co-authored-by: Tomas Vik <tvik@gitlab.com> * fix: Add quotes on generated variables to avoid braking with spaces (#2538) This should fix #2406 * Fix crash in fetch-external-configs on unset vars (#2561) * simple adjustments to "openvpn/modify-openvpn-config.sh" and "transmission/start.sh" that can make the verbosity of logging user-adjustable (#2564) * Bump docker/build-push-action from 3 to 4 (#2534) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Socks5 example doc (#2541) * fixing some heading sizes * adding socks5-proxy example --------- Co-authored-by: Jonathan Fair <jonathaf@netapp.com> * Docs: add capabilities for Podman to tips&tricks (#2546) Co-authored-by: Tomas Vik <tvik@gitlab.com> * Change CONFIG_MOD_VERBOSITY usage This change causes ${CONFIG_MOD_VERBOSITY} to become a variable used directly in the .ovpn config file. The default value remains '3'. * Insert ${TRANSMISSION_LOGGING} into exec'd command This change allows for executing 'transmission-daemon' with '--log-level' set. Utilizing a case-statement and forced lowercase, only valid values are accepted. Default is no logging. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JtMotoX <7191259+JtMotoX@users.noreply.github.com> Co-authored-by: Jonathan Fair <jonathaf@netapp.com> Co-authored-by: Patrick Kishino <patrick.a.kishino@gmail.com> Co-authored-by: Tomas Vik <tvik@gitlab.com> * Update master with Transmission 4 (#2576) * Image with Transmission 4.0.0-beta * Build in separate stage * Updated to beta2 * Update Dockerfile * Updated transmission to 4.0.0 release * Update Dockerfile * update beta (#2554) * Bump docker/build-push-action from 3 to 4 (#2534) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Socks5 example doc (#2541) * fixing some heading sizes * adding socks5-proxy example --------- Co-authored-by: Jonathan Fair <jonathaf@netapp.com> * Docs: add capabilities for Podman to tips&tricks (#2546) Co-authored-by: Tomas Vik <tvik@gitlab.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JtMotoX <7191259+JtMotoX@users.noreply.github.com> Co-authored-by: Jonathan Fair <jonathaf@netapp.com> Co-authored-by: Tomas Vik <tvik@gitlab.com> * Update Dockerfile 4.0.2 * Update configure-openvpn.sh (#2567) Same changes to master going to beta for beta tests w latest Transmission * Transmission->4.0.3 * prep new master (#2575) * Bump docker/build-push-action from 3 to 4 (#2534) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Socks5 example doc (#2541) * fixing some heading sizes * adding socks5-proxy example --------- Co-authored-by: Jonathan Fair <jonathaf@netapp.com> * Docs: add capabilities for Podman to tips&tricks (#2546) Co-authored-by: Tomas Vik <tvik@gitlab.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JtMotoX <7191259+JtMotoX@users.noreply.github.com> Co-authored-by: Jonathan Fair <jonathaf@netapp.com> Co-authored-by: Tomas Vik <tvik@gitlab.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Kristian Haugene <kristian@haugene.net> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JtMotoX <7191259+JtMotoX@users.noreply.github.com> Co-authored-by: Jonathan Fair <jonathaf@netapp.com> Co-authored-by: Tomas Vik <tvik@gitlab.com> Co-authored-by: Derek Gordon <derek@derekgordon.com> * OVPN script fix for for 4.x branch (#2566) * Bump docker/build-push-action from 3 to 4 (#2534) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Socks5 example doc (#2541) * fixing some heading sizes * adding socks5-proxy example --------- Co-authored-by: Jonathan Fair <jonathaf@netapp.com> * Docs: add capabilities for Podman to tips&tricks (#2546) Co-authored-by: Tomas Vik <tvik@gitlab.com> * git instead of unzip git instead of unzip * Using GIT GIT is used now instead of UNZIP due to issues suddenly experienced. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JtMotoX <7191259+JtMotoX@users.noreply.github.com> Co-authored-by: Jonathan Fair <jonathaf@netapp.com> Co-authored-by: Patrick Kishino <patrick.a.kishino@gmail.com> Co-authored-by: Tomas Vik <tvik@gitlab.com> * Update docker-image-builds.yml Removed deleted beta branch * Update Dockerfile Removed beta reference * Update master with latest dev fixes (#2579) * Quoute variables, fixes #2406 and #2418 * Fix sed busy (#2426) * fix sed device or resource busy errors Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> * update info Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> * update docs Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> * log and fail if config is a mountpoint Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> * correct mountpoint check Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> * Fix fallback of transmission-home #2409 * Fix to use iptables-legacy rather than iptables-nft (#2456) * Fix bug: the evironment file will be invalid (#2496) something environment like: `name=foo bar` will be invalid in the environment file, in a real example, it will be like `provider= SE Sto`. Simply add change it to `provider="SE Sto"` will fix that. * restart privoxy if docker changed eth0 address. (#2494) * restart privoxy if docker changed eth0 address. * sometimes, pidfile exists but process is dead * Simplify RPC creds setup (#2480) Reduce the complexity associated with creating RPC creds * Fix bitwise decimal & octal (#2457) * Fix bitwise decimal & octal The issue is tracked here: #2450 (comment) Also uses the TRASNMSISSION_UMASK variable instead of settings.json since updateSettings.py is called after userSetup.sh causing the TRANSMISSION_UMASK in settings.json to be stale when userSetup.sh accesses it. * fix: missing {} in sh variable * fix: missing {} in sh variable * fix regex for webproxy enabled (#2505) * review nordvpn error exit messages + tests (#2518) * Check for files existing instead of being executable #2459 * Bump docker/build-push-action from 3 to 4 (#2522) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: Add quotes on generated variables to avoid braking with spaces (#2538) This should fix #2406 * Fix crash in fetch-external-configs on unset vars (#2561) * simple adjustments to "openvpn/modify-openvpn-config.sh" and "transmission/start.sh" that can make the verbosity of logging user-adjustable (#2564) * Bump docker/build-push-action from 3 to 4 (#2534) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Socks5 example doc (#2541) * fixing some heading sizes * adding socks5-proxy example --------- Co-authored-by: Jonathan Fair <jonathaf@netapp.com> * Docs: add capabilities for Podman to tips&tricks (#2546) Co-authored-by: Tomas Vik <tvik@gitlab.com> * Change CONFIG_MOD_VERBOSITY usage This change causes ${CONFIG_MOD_VERBOSITY} to become a variable used directly in the .ovpn config file. The default value remains '3'. * Insert ${TRANSMISSION_LOGGING} into exec'd command This change allows for executing 'transmission-daemon' with '--log-level' set. Utilizing a case-statement and forced lowercase, only valid values are accepted. Default is no logging. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JtMotoX <7191259+JtMotoX@users.noreply.github.com> Co-authored-by: Jonathan Fair <jonathaf@netapp.com> Co-authored-by: Patrick Kishino <patrick.a.kishino@gmail.com> Co-authored-by: Tomas Vik <tvik@gitlab.com> * OVPN script fix for for 4.x branch (#2566) * Bump docker/build-push-action from 3 to 4 (#2534) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Socks5 example doc (#2541) * fixing some heading sizes * adding socks5-proxy example --------- Co-authored-by: Jonathan Fair <jonathaf@netapp.com> * Docs: add capabilities for Podman to tips&tricks (#2546) Co-authored-by: Tomas Vik <tvik@gitlab.com> * git instead of unzip git instead of unzip * Using GIT GIT is used now instead of UNZIP due to issues suddenly experienced. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JtMotoX <7191259+JtMotoX@users.noreply.github.com> Co-authored-by: Jonathan Fair <jonathaf@netapp.com> Co-authored-by: Patrick Kishino <patrick.a.kishino@gmail.com> Co-authored-by: Tomas Vik <tvik@gitlab.com> --------- Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Kristian Haugene <kristian@haugene.net> Co-authored-by: Jonathan Sloan <jsloan117@gmail.com> Co-authored-by: Robert Szynal <RJSzynal@Gmail.com> Co-authored-by: Jiangqiu Shen <ivy22233qiu@live.com> Co-authored-by: edgd1er <edgd1er@hotmail.com> Co-authored-by: Colin Hebert <active.luck0981@dedicated.contact> Co-authored-by: J.P. Hutchins <34154542+JPHutchins@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jayson Reis <santosdosreis@gmail.com> Co-authored-by: Chad <github@chad.org> Co-authored-by: phesster <115180691+phesster@users.noreply.github.com> Co-authored-by: JtMotoX <7191259+JtMotoX@users.noreply.github.com> Co-authored-by: Jonathan Fair <jonathaf@netapp.com> Co-authored-by: Tomas Vik <tvik@gitlab.com> Co-authored-by: Derek Gordon <derek@derekgordon.com> * Update master with latest dev fixes (#2579) (#2582) * Quoute variables, fixes #2406 and #2418 * Fix sed busy (#2426) * fix sed device or resource busy errors * update info * update docs * log and fail if config is a mountpoint * correct mountpoint check * Fix fallback of transmission-home #2409 * Fix to use iptables-legacy rather than iptables-nft (#2456) * Fix bug: the evironment file will be invalid (#2496) something environment like: `name=foo bar` will be invalid in the environment file, in a real example, it will be like `provider= SE Sto`. Simply add change it to `provider="SE Sto"` will fix that. * restart privoxy if docker changed eth0 address. (#2494) * restart privoxy if docker changed eth0 address. * sometimes, pidfile exists but process is dead * Simplify RPC creds setup (#2480) Reduce the complexity associated with creating RPC creds * Fix bitwise decimal & octal (#2457) * Fix bitwise decimal & octal The issue is tracked here: #2450 (comment) Also uses the TRASNMSISSION_UMASK variable instead of settings.json since updateSettings.py is called after userSetup.sh causing the TRANSMISSION_UMASK in settings.json to be stale when userSetup.sh accesses it. * fix: missing {} in sh variable * fix: missing {} in sh variable * fix regex for webproxy enabled (#2505) * review nordvpn error exit messages + tests (#2518) * Check for files existing instead of being executable #2459 * Bump docker/build-push-action from 3 to 4 (#2522) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... * fix: Add quotes on generated variables to avoid braking with spaces (#2538) This should fix #2406 * Fix crash in fetch-external-configs on unset vars (#2561) * simple adjustments to "openvpn/modify-openvpn-config.sh" and "transmission/start.sh" that can make the verbosity of logging user-adjustable (#2564) * Bump docker/build-push-action from 3 to 4 (#2534) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... * Socks5 example doc (#2541) * fixing some heading sizes * adding socks5-proxy example --------- * Docs: add capabilities for Podman to tips&tricks (#2546) * Change CONFIG_MOD_VERBOSITY usage This change causes ${CONFIG_MOD_VERBOSITY} to become a variable used directly in the .ovpn config file. The default value remains '3'. * Insert ${TRANSMISSION_LOGGING} into exec'd command This change allows for executing 'transmission-daemon' with '--log-level' set. Utilizing a case-statement and forced lowercase, only valid values are accepted. Default is no logging. --------- * OVPN script fix for for 4.x branch (#2566) * Bump docker/build-push-action from 3 to 4 (#2534) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... * Socks5 example doc (#2541) * fixing some heading sizes * adding socks5-proxy example --------- * Docs: add capabilities for Podman to tips&tricks (#2546) * git instead of unzip git instead of unzip * Using GIT GIT is used now instead of UNZIP due to issues suddenly experienced. --------- --------- Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Kristian Haugene <kristian@haugene.net> Co-authored-by: Jonathan Sloan <jsloan117@gmail.com> Co-authored-by: Robert Szynal <RJSzynal@Gmail.com> Co-authored-by: Jiangqiu Shen <ivy22233qiu@live.com> Co-authored-by: edgd1er <edgd1er@hotmail.com> Co-authored-by: Colin Hebert <active.luck0981@dedicated.contact> Co-authored-by: J.P. Hutchins <34154542+JPHutchins@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jayson Reis <santosdosreis@gmail.com> Co-authored-by: Chad <github@chad.org> Co-authored-by: phesster <115180691+phesster@users.noreply.github.com> Co-authored-by: JtMotoX <7191259+JtMotoX@users.noreply.github.com> Co-authored-by: Jonathan Fair <jonathaf@netapp.com> Co-authored-by: Tomas Vik <tvik@gitlab.com> Co-authored-by: Derek Gordon <derek@derekgordon.com> * Merge dev into master (#2583) * Quoute variables, fixes #2406 and #2418 * Fix sed busy (#2426) * fix sed device or resource busy errors Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> * update info Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> * update docs Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> * log and fail if config is a mountpoint Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> * correct mountpoint check Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> * Fix fallback of transmission-home #2409 * Fix to use iptables-legacy rather than iptables-nft (#2456) * Fix bug: the evironment file will be invalid (#2496) something environment like: `name=foo bar` will be invalid in the environment file, in a real example, it will be like `provider= SE Sto`. Simply add change it to `provider="SE Sto"` will fix that. * restart privoxy if docker changed eth0 address. (#2494) * restart privoxy if docker changed eth0 address. * sometimes, pidfile exists but process is dead * Simplify RPC creds setup (#2480) Reduce the complexity associated with creating RPC creds * Fix bitwise decimal & octal (#2457) * Fix bitwise decimal & octal The issue is tracked here: #2450 (comment) Also uses the TRASNMSISSION_UMASK variable instead of settings.json since updateSettings.py is called after userSetup.sh causing the TRANSMISSION_UMASK in settings.json to be stale when userSetup.sh accesses it. * fix: missing {} in sh variable * fix: missing {} in sh variable * fix regex for webproxy enabled (#2505) * review nordvpn error exit messages + tests (#2518) * Check for files existing instead of being executable #2459 * Bump docker/build-push-action from 3 to 4 (#2522) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: Add quotes on generated variables to avoid braking with spaces (#2538) This should fix #2406 * Fix crash in fetch-external-configs on unset vars (#2561) * simple adjustments to "openvpn/modify-openvpn-config.sh" and "transmission/start.sh" that can make the verbosity of logging user-adjustable (#2564) * Bump docker/build-push-action from 3 to 4 (#2534) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Socks5 example doc (#2541) * fixing some heading sizes * adding socks5-proxy example --------- Co-authored-by: Jonathan Fair <jonathaf@netapp.com> * Docs: add capabilities for Podman to tips&tricks (#2546) Co-authored-by: Tomas Vik <tvik@gitlab.com> * Change CONFIG_MOD_VERBOSITY usage This change causes ${CONFIG_MOD_VERBOSITY} to become a variable used directly in the .ovpn config file. The default value remains '3'. * Insert ${TRANSMISSION_LOGGING} into exec'd command This change allows for executing 'transmission-daemon' with '--log-level' set. Utilizing a case-statement and forced lowercase, only valid values are accepted. Default is no logging. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JtMotoX <7191259+JtMotoX@users.noreply.github.com> Co-authored-by: Jonathan Fair <jonathaf@netapp.com> Co-authored-by: Patrick Kishino <patrick.a.kishino@gmail.com> Co-authored-by: Tomas Vik <tvik@gitlab.com> * OVPN script fix for for 4.x branch (#2566) * Bump docker/build-push-action from 3 to 4 (#2534) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Socks5 example doc (#2541) * fixing some heading sizes * adding socks5-proxy example --------- Co-authored-by: Jonathan Fair <jonathaf@netapp.com> * Docs: add capabilities for Podman to tips&tricks (#2546) Co-authored-by: Tomas Vik <tvik@gitlab.com> * git instead of unzip git instead of unzip * Using GIT GIT is used now instead of UNZIP due to issues suddenly experienced. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JtMotoX <7191259+JtMotoX@users.noreply.github.com> Co-authored-by: Jonathan Fair <jonathaf@netapp.com> Co-authored-by: Patrick Kishino <patrick.a.kishino@gmail.com> Co-authored-by: Tomas Vik <tvik@gitlab.com> * Update master with latest dev fixes (#2579) (#2582) * Quoute variables, fixes #2406 and #2418 * Fix sed busy (#2426) * fix sed device or resource busy errors * update info * update docs * log and fail if config is a mountpoint * correct mountpoint check * Fix fallback of transmission-home #2409 * Fix to use iptables-legacy rather than iptables-nft (#2456) * Fix bug: the evironment file will be invalid (#2496) something environment like: `name=foo bar` will be invalid in the environment file, in a real example, it will be like `provider= SE Sto`. Simply add change it to `provider="SE Sto"` will fix that. * restart privoxy if docker changed eth0 address. (#2494) * restart privoxy if docker changed eth0 address. * sometimes, pidfile exists but process is dead * Simplify RPC creds setup (#2480) Reduce the complexity associated with creating RPC creds * Fix bitwise decimal & octal (#2457) * Fix bitwise decimal & octal The issue is tracked here: #2450 (comment) Also uses the TRASNMSISSION_UMASK variable instead of settings.json since updateSettings.py is called after userSetup.sh causing the TRANSMISSION_UMASK in settings.json to be stale when userSetup.sh accesses it. * fix: missing {} in sh variable * fix: missing {} in sh variable * fix regex for webproxy enabled (#2505) * review nordvpn error exit messages + tests (#2518) * Check for files existing instead of being executable #2459 * Bump docker/build-push-action from 3 to 4 (#2522) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... * fix: Add quotes on generated variables to avoid braking with spaces (#2538) This should fix #2406 * Fix crash in fetch-external-configs on unset vars (#2561) * simple adjustments to "openvpn/modify-openvpn-config.sh" and "transmission/start.sh" that can make the verbosity of logging user-adjustable (#2564) * Bump docker/build-push-action from 3 to 4 (#2534) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... * Socks5 example doc (#2541) * fixing some heading sizes * adding socks5-proxy example --------- * Docs: add capabilities for Podman to tips&tricks (#2546) * Change CONFIG_MOD_VERBOSITY usage This change causes ${CONFIG_MOD_VERBOSITY} to become a variable used directly in the .ovpn config file. The default value remains '3'. * Insert ${TRANSMISSION_LOGGING} into exec'd command This change allows for executing 'transmission-daemon' with '--log-level' set. Utilizing a case-statement and forced lowercase, only valid values are accepted. Default is no logging. --------- * OVPN script fix for for 4.x branch (#2566) * Bump docker/build-push-action from 3 to 4 (#2534) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... * Socks5 example doc (#2541) * fixing some heading sizes * adding socks5-proxy example --------- * Docs: add capabilities for Podman to tips&tricks (#2546) * git instead of unzip git instead of unzip * Using GIT GIT is used now instead of UNZIP due to issues suddenly experienced. --------- --------- Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Kristian Haugene <kristian@haugene.net> Co-authored-by: Jonathan Sloan <jsloan117@gmail.com> Co-authored-by: Robert Szynal <RJSzynal@Gmail.com> Co-authored-by: Jiangqiu Shen <ivy22233qiu@live.com> Co-authored-by: edgd1er <edgd1er@hotmail.com> Co-authored-by: Colin Hebert <active.luck0981@dedicated.contact> Co-authored-by: J.P. Hutchins <34154542+JPHutchins@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jayson Reis <santosdosreis@gmail.com> Co-authored-by: Chad <github@chad.org> Co-authored-by: phesster <115180691+phesster@users.noreply.github.com> Co-authored-by: JtMotoX <7191259+JtMotoX@users.noreply.github.com> Co-authored-by: Jonathan Fair <jonathaf@netapp.com> Co-authored-by: Tomas Vik <tvik@gitlab.com> Co-authored-by: Derek Gordon <derek@derekgordon.com> --------- Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Kristian Haugene <kristian@haugene.net> Co-authored-by: Jonathan Sloan <jsloan117@gmail.com> Co-authored-by: Robert Szynal <RJSzynal@Gmail.com> Co-authored-by: Jiangqiu Shen <ivy22233qiu@live.com> Co-authored-by: edgd1er <edgd1er@hotmail.com> Co-authored-by: Colin Hebert <active.luck0981@dedicated.contact> Co-authored-by: J.P. Hutchins <34154542+JPHutchins@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jayson Reis <santosdosreis@gmail.com> Co-authored-by: Chad <github@chad.org> Co-authored-by: phesster <115180691+phesster@users.noreply.github.com> Co-authored-by: JtMotoX <7191259+JtMotoX@users.noreply.github.com> Co-authored-by: Jonathan Fair <jonathaf@netapp.com> Co-authored-by: Tomas Vik <tvik@gitlab.com> Co-authored-by: Derek Gordon <derek@derekgordon.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JtMotoX <7191259+JtMotoX@users.noreply.github.com> Co-authored-by: Jonathan Fair <jonathaf@netapp.com> Co-authored-by: Tomas Vik <tvik@gitlab.com> Co-authored-by: Jayson Reis <santosdosreis@gmail.com> Co-authored-by: Chad <github@chad.org> Co-authored-by: phesster <115180691+phesster@users.noreply.github.com> Co-authored-by: Kristian Haugene <kristian@haugene.net> Co-authored-by: Derek Gordon <derek@derekgordon.com> Co-authored-by: Jonathan Sloan <jsloan117@gmail.com> Co-authored-by: Robert Szynal <RJSzynal@Gmail.com> Co-authored-by: Jiangqiu Shen <ivy22233qiu@live.com> Co-authored-by: edgd1er <edgd1er@hotmail.com> Co-authored-by: Colin Hebert <active.luck0981@dedicated.contact> Co-authored-by: J.P. Hutchins <34154542+JPHutchins@users.noreply.github.com>
pkishino
added a commit
that referenced
this pull request
Apr 17, 2023
* Bump docker/build-push-action from 3 to 4 (#2522) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump docker/build-push-action from 3 to 4 (#2534) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Socks5 example doc (#2541) * fixing some heading sizes * adding socks5-proxy example --------- Co-authored-by: Jonathan Fair <jonathaf@netapp.com> * Docs: add capabilities for Podman to tips&tricks (#2546) Co-authored-by: Tomas Vik <tvik@gitlab.com> * fix: Add quotes on generated variables to avoid braking with spaces (#2538) This should fix #2406 * Fix crash in fetch-external-configs on unset vars (#2561) * simple adjustments to "openvpn/modify-openvpn-config.sh" and "transmission/start.sh" that can make the verbosity of logging user-adjustable (#2564) * Bump docker/build-push-action from 3 to 4 (#2534) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Socks5 example doc (#2541) * fixing some heading sizes * adding socks5-proxy example --------- Co-authored-by: Jonathan Fair <jonathaf@netapp.com> * Docs: add capabilities for Podman to tips&tricks (#2546) Co-authored-by: Tomas Vik <tvik@gitlab.com> * Change CONFIG_MOD_VERBOSITY usage This change causes ${CONFIG_MOD_VERBOSITY} to become a variable used directly in the .ovpn config file. The default value remains '3'. * Insert ${TRANSMISSION_LOGGING} into exec'd command This change allows for executing 'transmission-daemon' with '--log-level' set. Utilizing a case-statement and forced lowercase, only valid values are accepted. Default is no logging. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JtMotoX <7191259+JtMotoX@users.noreply.github.com> Co-authored-by: Jonathan Fair <jonathaf@netapp.com> Co-authored-by: Patrick Kishino <patrick.a.kishino@gmail.com> Co-authored-by: Tomas Vik <tvik@gitlab.com> * Update master with Transmission 4 (#2576) * Image with Transmission 4.0.0-beta * Build in separate stage * Updated to beta2 * Update Dockerfile * Updated transmission to 4.0.0 release * Update Dockerfile * update beta (#2554) * Bump docker/build-push-action from 3 to 4 (#2534) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Socks5 example doc (#2541) * fixing some heading sizes * adding socks5-proxy example --------- Co-authored-by: Jonathan Fair <jonathaf@netapp.com> * Docs: add capabilities for Podman to tips&tricks (#2546) Co-authored-by: Tomas Vik <tvik@gitlab.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JtMotoX <7191259+JtMotoX@users.noreply.github.com> Co-authored-by: Jonathan Fair <jonathaf@netapp.com> Co-authored-by: Tomas Vik <tvik@gitlab.com> * Update Dockerfile 4.0.2 * Update configure-openvpn.sh (#2567) Same changes to master going to beta for beta tests w latest Transmission * Transmission->4.0.3 * prep new master (#2575) * Bump docker/build-push-action from 3 to 4 (#2534) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Socks5 example doc (#2541) * fixing some heading sizes * adding socks5-proxy example --------- Co-authored-by: Jonathan Fair <jonathaf@netapp.com> * Docs: add capabilities for Podman to tips&tricks (#2546) Co-authored-by: Tomas Vik <tvik@gitlab.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JtMotoX <7191259+JtMotoX@users.noreply.github.com> Co-authored-by: Jonathan Fair <jonathaf@netapp.com> Co-authored-by: Tomas Vik <tvik@gitlab.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Kristian Haugene <kristian@haugene.net> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JtMotoX <7191259+JtMotoX@users.noreply.github.com> Co-authored-by: Jonathan Fair <jonathaf@netapp.com> Co-authored-by: Tomas Vik <tvik@gitlab.com> Co-authored-by: Derek Gordon <derek@derekgordon.com> * OVPN script fix for for 4.x branch (#2566) * Bump docker/build-push-action from 3 to 4 (#2534) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Socks5 example doc (#2541) * fixing some heading sizes * adding socks5-proxy example --------- Co-authored-by: Jonathan Fair <jonathaf@netapp.com> * Docs: add capabilities for Podman to tips&tricks (#2546) Co-authored-by: Tomas Vik <tvik@gitlab.com> * git instead of unzip git instead of unzip * Using GIT GIT is used now instead of UNZIP due to issues suddenly experienced. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JtMotoX <7191259+JtMotoX@users.noreply.github.com> Co-authored-by: Jonathan Fair <jonathaf@netapp.com> Co-authored-by: Patrick Kishino <patrick.a.kishino@gmail.com> Co-authored-by: Tomas Vik <tvik@gitlab.com> * Update docker-image-builds.yml Removed deleted beta branch * Update Dockerfile Removed beta reference * Update master with latest dev fixes (#2579) * Quoute variables, fixes #2406 and #2418 * Fix sed busy (#2426) * fix sed device or resource busy errors Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> * update info Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> * update docs Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> * log and fail if config is a mountpoint Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> * correct mountpoint check Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> * Fix fallback of transmission-home #2409 * Fix to use iptables-legacy rather than iptables-nft (#2456) * Fix bug: the evironment file will be invalid (#2496) something environment like: `name=foo bar` will be invalid in the environment file, in a real example, it will be like `provider= SE Sto`. Simply add change it to `provider="SE Sto"` will fix that. * restart privoxy if docker changed eth0 address. (#2494) * restart privoxy if docker changed eth0 address. * sometimes, pidfile exists but process is dead * Simplify RPC creds setup (#2480) Reduce the complexity associated with creating RPC creds * Fix bitwise decimal & octal (#2457) * Fix bitwise decimal & octal The issue is tracked here: #2450 (comment) Also uses the TRASNMSISSION_UMASK variable instead of settings.json since updateSettings.py is called after userSetup.sh causing the TRANSMISSION_UMASK in settings.json to be stale when userSetup.sh accesses it. * fix: missing {} in sh variable * fix: missing {} in sh variable * fix regex for webproxy enabled (#2505) * review nordvpn error exit messages + tests (#2518) * Check for files existing instead of being executable #2459 * Bump docker/build-push-action from 3 to 4 (#2522) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: Add quotes on generated variables to avoid braking with spaces (#2538) This should fix #2406 * Fix crash in fetch-external-configs on unset vars (#2561) * simple adjustments to "openvpn/modify-openvpn-config.sh" and "transmission/start.sh" that can make the verbosity of logging user-adjustable (#2564) * Bump docker/build-push-action from 3 to 4 (#2534) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Socks5 example doc (#2541) * fixing some heading sizes * adding socks5-proxy example --------- Co-authored-by: Jonathan Fair <jonathaf@netapp.com> * Docs: add capabilities for Podman to tips&tricks (#2546) Co-authored-by: Tomas Vik <tvik@gitlab.com> * Change CONFIG_MOD_VERBOSITY usage This change causes ${CONFIG_MOD_VERBOSITY} to become a variable used directly in the .ovpn config file. The default value remains '3'. * Insert ${TRANSMISSION_LOGGING} into exec'd command This change allows for executing 'transmission-daemon' with '--log-level' set. Utilizing a case-statement and forced lowercase, only valid values are accepted. Default is no logging. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JtMotoX <7191259+JtMotoX@users.noreply.github.com> Co-authored-by: Jonathan Fair <jonathaf@netapp.com> Co-authored-by: Patrick Kishino <patrick.a.kishino@gmail.com> Co-authored-by: Tomas Vik <tvik@gitlab.com> * OVPN script fix for for 4.x branch (#2566) * Bump docker/build-push-action from 3 to 4 (#2534) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Socks5 example doc (#2541) * fixing some heading sizes * adding socks5-proxy example --------- Co-authored-by: Jonathan Fair <jonathaf@netapp.com> * Docs: add capabilities for Podman to tips&tricks (#2546) Co-authored-by: Tomas Vik <tvik@gitlab.com> * git instead of unzip git instead of unzip * Using GIT GIT is used now instead of UNZIP due to issues suddenly experienced. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JtMotoX <7191259+JtMotoX@users.noreply.github.com> Co-authored-by: Jonathan Fair <jonathaf@netapp.com> Co-authored-by: Patrick Kishino <patrick.a.kishino@gmail.com> Co-authored-by: Tomas Vik <tvik@gitlab.com> --------- Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Kristian Haugene <kristian@haugene.net> Co-authored-by: Jonathan Sloan <jsloan117@gmail.com> Co-authored-by: Robert Szynal <RJSzynal@Gmail.com> Co-authored-by: Jiangqiu Shen <ivy22233qiu@live.com> Co-authored-by: edgd1er <edgd1er@hotmail.com> Co-authored-by: Colin Hebert <active.luck0981@dedicated.contact> Co-authored-by: J.P. Hutchins <34154542+JPHutchins@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jayson Reis <santosdosreis@gmail.com> Co-authored-by: Chad <github@chad.org> Co-authored-by: phesster <115180691+phesster@users.noreply.github.com> Co-authored-by: JtMotoX <7191259+JtMotoX@users.noreply.github.com> Co-authored-by: Jonathan Fair <jonathaf@netapp.com> Co-authored-by: Tomas Vik <tvik@gitlab.com> Co-authored-by: Derek Gordon <derek@derekgordon.com> * Update master with latest dev fixes (#2579) (#2582) * Quoute variables, fixes #2406 and #2418 * Fix sed busy (#2426) * fix sed device or resource busy errors * update info * update docs * log and fail if config is a mountpoint * correct mountpoint check * Fix fallback of transmission-home #2409 * Fix to use iptables-legacy rather than iptables-nft (#2456) * Fix bug: the evironment file will be invalid (#2496) something environment like: `name=foo bar` will be invalid in the environment file, in a real example, it will be like `provider= SE Sto`. Simply add change it to `provider="SE Sto"` will fix that. * restart privoxy if docker changed eth0 address. (#2494) * restart privoxy if docker changed eth0 address. * sometimes, pidfile exists but process is dead * Simplify RPC creds setup (#2480) Reduce the complexity associated with creating RPC creds * Fix bitwise decimal & octal (#2457) * Fix bitwise decimal & octal The issue is tracked here: #2450 (comment) Also uses the TRASNMSISSION_UMASK variable instead of settings.json since updateSettings.py is called after userSetup.sh causing the TRANSMISSION_UMASK in settings.json to be stale when userSetup.sh accesses it. * fix: missing {} in sh variable * fix: missing {} in sh variable * fix regex for webproxy enabled (#2505) * review nordvpn error exit messages + tests (#2518) * Check for files existing instead of being executable #2459 * Bump docker/build-push-action from 3 to 4 (#2522) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... * fix: Add quotes on generated variables to avoid braking with spaces (#2538) This should fix #2406 * Fix crash in fetch-external-configs on unset vars (#2561) * simple adjustments to "openvpn/modify-openvpn-config.sh" and "transmission/start.sh" that can make the verbosity of logging user-adjustable (#2564) * Bump docker/build-push-action from 3 to 4 (#2534) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... * Socks5 example doc (#2541) * fixing some heading sizes * adding socks5-proxy example --------- * Docs: add capabilities for Podman to tips&tricks (#2546) * Change CONFIG_MOD_VERBOSITY usage This change causes ${CONFIG_MOD_VERBOSITY} to become a variable used directly in the .ovpn config file. The default value remains '3'. * Insert ${TRANSMISSION_LOGGING} into exec'd command This change allows for executing 'transmission-daemon' with '--log-level' set. Utilizing a case-statement and forced lowercase, only valid values are accepted. Default is no logging. --------- * OVPN script fix for for 4.x branch (#2566) * Bump docker/build-push-action from 3 to 4 (#2534) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... * Socks5 example doc (#2541) * fixing some heading sizes * adding socks5-proxy example --------- * Docs: add capabilities for Podman to tips&tricks (#2546) * git instead of unzip git instead of unzip * Using GIT GIT is used now instead of UNZIP due to issues suddenly experienced. --------- --------- Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Kristian Haugene <kristian@haugene.net> Co-authored-by: Jonathan Sloan <jsloan117@gmail.com> Co-authored-by: Robert Szynal <RJSzynal@Gmail.com> Co-authored-by: Jiangqiu Shen <ivy22233qiu@live.com> Co-authored-by: edgd1er <edgd1er@hotmail.com> Co-authored-by: Colin Hebert <active.luck0981@dedicated.contact> Co-authored-by: J.P. Hutchins <34154542+JPHutchins@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jayson Reis <santosdosreis@gmail.com> Co-authored-by: Chad <github@chad.org> Co-authored-by: phesster <115180691+phesster@users.noreply.github.com> Co-authored-by: JtMotoX <7191259+JtMotoX@users.noreply.github.com> Co-authored-by: Jonathan Fair <jonathaf@netapp.com> Co-authored-by: Tomas Vik <tvik@gitlab.com> Co-authored-by: Derek Gordon <derek@derekgordon.com> * Merge dev into master (#2583) * Quoute variables, fixes #2406 and #2418 * Fix sed busy (#2426) * fix sed device or resource busy errors Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> * update info Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> * update docs Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> * log and fail if config is a mountpoint Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> * correct mountpoint check Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> * Fix fallback of transmission-home #2409 * Fix to use iptables-legacy rather than iptables-nft (#2456) * Fix bug: the evironment file will be invalid (#2496) something environment like: `name=foo bar` will be invalid in the environment file, in a real example, it will be like `provider= SE Sto`. Simply add change it to `provider="SE Sto"` will fix that. * restart privoxy if docker changed eth0 address. (#2494) * restart privoxy if docker changed eth0 address. * sometimes, pidfile exists but process is dead * Simplify RPC creds setup (#2480) Reduce the complexity associated with creating RPC creds * Fix bitwise decimal & octal (#2457) * Fix bitwise decimal & octal The issue is tracked here: #2450 (comment) Also uses the TRASNMSISSION_UMASK variable instead of settings.json since updateSettings.py is called after userSetup.sh causing the TRANSMISSION_UMASK in settings.json to be stale when userSetup.sh accesses it. * fix: missing {} in sh variable * fix: missing {} in sh variable * fix regex for webproxy enabled (#2505) * review nordvpn error exit messages + tests (#2518) * Check for files existing instead of being executable #2459 * Bump docker/build-push-action from 3 to 4 (#2522) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: Add quotes on generated variables to avoid braking with spaces (#2538) This should fix #2406 * Fix crash in fetch-external-configs on unset vars (#2561) * simple adjustments to "openvpn/modify-openvpn-config.sh" and "transmission/start.sh" that can make the verbosity of logging user-adjustable (#2564) * Bump docker/build-push-action from 3 to 4 (#2534) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Socks5 example doc (#2541) * fixing some heading sizes * adding socks5-proxy example --------- Co-authored-by: Jonathan Fair <jonathaf@netapp.com> * Docs: add capabilities for Podman to tips&tricks (#2546) Co-authored-by: Tomas Vik <tvik@gitlab.com> * Change CONFIG_MOD_VERBOSITY usage This change causes ${CONFIG_MOD_VERBOSITY} to become a variable used directly in the .ovpn config file. The default value remains '3'. * Insert ${TRANSMISSION_LOGGING} into exec'd command This change allows for executing 'transmission-daemon' with '--log-level' set. Utilizing a case-statement and forced lowercase, only valid values are accepted. Default is no logging. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JtMotoX <7191259+JtMotoX@users.noreply.github.com> Co-authored-by: Jonathan Fair <jonathaf@netapp.com> Co-authored-by: Patrick Kishino <patrick.a.kishino@gmail.com> Co-authored-by: Tomas Vik <tvik@gitlab.com> * OVPN script fix for for 4.x branch (#2566) * Bump docker/build-push-action from 3 to 4 (#2534) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Socks5 example doc (#2541) * fixing some heading sizes * adding socks5-proxy example --------- Co-authored-by: Jonathan Fair <jonathaf@netapp.com> * Docs: add capabilities for Podman to tips&tricks (#2546) Co-authored-by: Tomas Vik <tvik@gitlab.com> * git instead of unzip git instead of unzip * Using GIT GIT is used now instead of UNZIP due to issues suddenly experienced. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JtMotoX <7191259+JtMotoX@users.noreply.github.com> Co-authored-by: Jonathan Fair <jonathaf@netapp.com> Co-authored-by: Patrick Kishino <patrick.a.kishino@gmail.com> Co-authored-by: Tomas Vik <tvik@gitlab.com> * Update master with latest dev fixes (#2579) (#2582) * Quoute variables, fixes #2406 and #2418 * Fix sed busy (#2426) * fix sed device or resource busy errors * update info * update docs * log and fail if config is a mountpoint * correct mountpoint check * Fix fallback of transmission-home #2409 * Fix to use iptables-legacy rather than iptables-nft (#2456) * Fix bug: the evironment file will be invalid (#2496) something environment like: `name=foo bar` will be invalid in the environment file, in a real example, it will be like `provider= SE Sto`. Simply add change it to `provider="SE Sto"` will fix that. * restart privoxy if docker changed eth0 address. (#2494) * restart privoxy if docker changed eth0 address. * sometimes, pidfile exists but process is dead * Simplify RPC creds setup (#2480) Reduce the complexity associated with creating RPC creds * Fix bitwise decimal & octal (#2457) * Fix bitwise decimal & octal The issue is tracked here: #2450 (comment) Also uses the TRASNMSISSION_UMASK variable instead of settings.json since updateSettings.py is called after userSetup.sh causing the TRANSMISSION_UMASK in settings.json to be stale when userSetup.sh accesses it. * fix: missing {} in sh variable * fix: missing {} in sh variable * fix regex for webproxy enabled (#2505) * review nordvpn error exit messages + tests (#2518) * Check for files existing instead of being executable #2459 * Bump docker/build-push-action from 3 to 4 (#2522) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... * fix: Add quotes on generated variables to avoid braking with spaces (#2538) This should fix #2406 * Fix crash in fetch-external-configs on unset vars (#2561) * simple adjustments to "openvpn/modify-openvpn-config.sh" and "transmission/start.sh" that can make the verbosity of logging user-adjustable (#2564) * Bump docker/build-push-action from 3 to 4 (#2534) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... * Socks5 example doc (#2541) * fixing some heading sizes * adding socks5-proxy example --------- * Docs: add capabilities for Podman to tips&tricks (#2546) * Change CONFIG_MOD_VERBOSITY usage This change causes ${CONFIG_MOD_VERBOSITY} to become a variable used directly in the .ovpn config file. The default value remains '3'. * Insert ${TRANSMISSION_LOGGING} into exec'd command This change allows for executing 'transmission-daemon' with '--log-level' set. Utilizing a case-statement and forced lowercase, only valid values are accepted. Default is no logging. --------- * OVPN script fix for for 4.x branch (#2566) * Bump docker/build-push-action from 3 to 4 (#2534) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... * Socks5 example doc (#2541) * fixing some heading sizes * adding socks5-proxy example --------- * Docs: add capabilities for Podman to tips&tricks (#2546) * git instead of unzip git instead of unzip * Using GIT GIT is used now instead of UNZIP due to issues suddenly experienced. --------- --------- Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Kristian Haugene <kristian@haugene.net> Co-authored-by: Jonathan Sloan <jsloan117@gmail.com> Co-authored-by: Robert Szynal <RJSzynal@Gmail.com> Co-authored-by: Jiangqiu Shen <ivy22233qiu@live.com> Co-authored-by: edgd1er <edgd1er@hotmail.com> Co-authored-by: Colin Hebert <active.luck0981@dedicated.contact> Co-authored-by: J.P. Hutchins <34154542+JPHutchins@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jayson Reis <santosdosreis@gmail.com> Co-authored-by: Chad <github@chad.org> Co-authored-by: phesster <115180691+phesster@users.noreply.github.com> Co-authored-by: JtMotoX <7191259+JtMotoX@users.noreply.github.com> Co-authored-by: Jonathan Fair <jonathaf@netapp.com> Co-authored-by: Tomas Vik <tvik@gitlab.com> Co-authored-by: Derek Gordon <derek@derekgordon.com> --------- Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Kristian Haugene <kristian@haugene.net> Co-authored-by: Jonathan Sloan <jsloan117@gmail.com> Co-authored-by: Robert Szynal <RJSzynal@Gmail.com> Co-authored-by: Jiangqiu Shen <ivy22233qiu@live.com> Co-authored-by: edgd1er <edgd1er@hotmail.com> Co-authored-by: Colin Hebert <active.luck0981@dedicated.contact> Co-authored-by: J.P. Hutchins <34154542+JPHutchins@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jayson Reis <santosdosreis@gmail.com> Co-authored-by: Chad <github@chad.org> Co-authored-by: phesster <115180691+phesster@users.noreply.github.com> Co-authored-by: JtMotoX <7191259+JtMotoX@users.noreply.github.com> Co-authored-by: Jonathan Fair <jonathaf@netapp.com> Co-authored-by: Tomas Vik <tvik@gitlab.com> Co-authored-by: Derek Gordon <derek@derekgordon.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Jonathan Sloan <jsloan117@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JtMotoX <7191259+JtMotoX@users.noreply.github.com> Co-authored-by: Jonathan Fair <jonathaf@netapp.com> Co-authored-by: Tomas Vik <tvik@gitlab.com> Co-authored-by: Jayson Reis <santosdosreis@gmail.com> Co-authored-by: Chad <github@chad.org> Co-authored-by: phesster <115180691+phesster@users.noreply.github.com> Co-authored-by: Kristian Haugene <kristian@haugene.net> Co-authored-by: Derek Gordon <derek@derekgordon.com> Co-authored-by: Jonathan Sloan <jsloan117@gmail.com> Co-authored-by: Robert Szynal <RJSzynal@Gmail.com> Co-authored-by: Jiangqiu Shen <ivy22233qiu@live.com> Co-authored-by: edgd1er <edgd1er@hotmail.com> Co-authored-by: Colin Hebert <active.luck0981@dedicated.contact> Co-authored-by: J.P. Hutchins <34154542+JPHutchins@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Type of change
Additional information
relates to #
https://...
Checklist
If user exposed functionality or configuration variables are added/changed: