Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rolling back PR #305 for Mullvad configs, while keeping switch from URLs to IP addresses #312

Merged
merged 1 commit into from
Aug 25, 2024

Conversation

sntyj
Copy link
Contributor

@sntyj sntyj commented Aug 23, 2024

Breaking change

This is not a breaking change, it should fix it. 

Proposed change

I replaced block-outside-dns as this is a Windows specific option, that doesn't have a place with this container: 

https://openvpn.net/community-resources/reference-manual-for-openvpn-2-5/

I replaced the 'service' parameter as it is a deprecated option in OpenVPN from what I can tell:

https://community.openvpn.net/openvpn/wiki/DeprecatedOptions#Windows:openvpn-legacy-serviceStatus:Removed

I kept the switch from URLs to IP addresses, because I think that is a valid change that could help alleviate issues if DNS doesn't resolve on the client for some reason. 

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New provider (thank you!)
  • Updated provider (thank you!)
  • New feature (which adds functionality to a provider script/repo usage)
  • Breaking change (fix/feature causing existing functionality to break)

Additional information

  • This PR fixes or closes issue: fixes #311

Checklist

  • The code change is tested and works locally. (I am running this version of the configuration currently)
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

  • Documentation added/updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants