[WIP] Start downloading subtitles before download finishes #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hauxir
added
enhancement
hauxir
changed the title
hauxir
force-pushed
the
start-download-subtitles-before-download-finishes
branch
from
0f168d4
to
453e997
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To speed up the process, the goal of this PR is to start the download of subtitles from OpenSubtitles before the torrent file download finishes.
To accomplish this we need to prioritize the front and back of the file so that the opensubtitle hash function can be called on the file. We need 64bits from the beginning and end of the file.
For reference:
https://trac.opensubtitles.org/projects/opensubtitles/wiki/HashSourceCodes
This also helps pave the way for instant streaming in future releases, making it possible to start streaming a file before the torrent download finishes.