Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latency awareness #6

Closed
wants to merge 5 commits into from
Closed

Conversation

wprzytula
Copy link

@wprzytula wprzytula commented Jan 17, 2023

This is the first attempt to introduce latency awareness. I've chosen to build it atop the current DefaultPolicy, because it is natural that LA simply adds yet another level of iterator permutation.

The PR includes identification-by-HostID PR. This is for identifying nodes in LatencyAwareness' HashMap.

New things are in last 4 commits.

@wprzytula
Copy link
Author

@havaker @cvybhu Waiting for opinions on design adopted.

@wprzytula wprzytula force-pushed the lb2-latency-aware branch 3 times, most recently from b94e923 to 116c245 Compare January 19, 2023 09:29
@wprzytula wprzytula force-pushed the lb2-latency-aware branch 2 times, most recently from 46c297c to 9a5ea44 Compare January 19, 2023 15:50
@wprzytula
Copy link
Author

Addressed both comments:

  • Box'ed predicate instead of a generic
  • is_enabled() stub for is_alive()

Copy link
Owner

@havaker havaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please drop this commit a114513

@wprzytula
Copy link
Author

Please drop this commit a114513

Ok, but now latency_aware.rs is not deleted; I've made a mistake during recent rebase on main, so we probably need to remove it again. I would suggest removing it in a new commit, and I'll handle it in a final cleanup of this PR.

@havaker
Copy link
Owner

havaker commented Jan 19, 2023

Please rebase to havaker:lb2.

@wprzytula
Copy link
Author

Please rebase to havaker:lb2.

done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants