temporary solution to fix #71 #82
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TCPShield/RealIP#50 (comment) disabling this as detailed here; realIP already handles IP manipulation
|
What? What do you think this should fix? |
|
Read the issue and comment linked; this should fix incompatiability with TCPShield 2.5 |
|
Mhh, I see what you were thinking there and I wish it would be that easy, but I'm sorry to disappoint you - your changes won't fix anything. The problem is not this function. It has something to do this hashing a check value for the RealIP/TCPShield plugin. Removing this function will just break support for any prior version of the plugin. |
|
A shame. This would be really nice to see fixed. Whats the alternative for proxying with Infrared and retaining the IP? |
|
You could use proxy protocol. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TCPShield/RealIP#50 (comment)
disabling this as detailed here; realIP already handles IP manipulation