Tuple in bindings #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracted from GridTools#1130 and married with Connectivities. Co-authored-by: Enrique G. Paredes <18477+egparedes@users.noreply.github.com>
* Update coding guidelines * restructure cartesian and next test suites --------- Co-authored-by: Rico Häuselmann <ricoh@cscs.ch> Co-authored-by: Hannes Vogt <hannes@havogt.de> Co-authored-by: Enrique G. Paredes <enriqueg@cscs.ch>
* some tests in test_execution were effectifely not testing anything, since * np.allclose was used without assertion * np.asarray was used, effectively asserting identity with the same memory * in the same cases as np.asarray was used, the intended copy was based on result values so no values could have been different even if they were copied as intended Further cosmetic changes were made: (size)->(size,) (alternatively, parentheses could be dropped.) Co-authored-by: Linus Groner <linus.groner@gmail.com> Co-authored-by: Till Ehrengruber <till.ehrengruber@cscs.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the content of the PR and links to related issues, bugs of features.
Requirements
Before submitting this PR, please make sure:
Additionally, if this PR contains code authored by new contributors:
signed by the employer if needed, provided to ETH Zurich
version of the AUTHORS.rst file included in the PR