[RFC] Make Service generic
#1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This branch begins adding additional integration tests. In particular, it adds the following: - Additional "hello world" integration tests with request bodies, response bodies, and request and response bodies, - A `tests/client.rs` module to contain tests for "real" clients with mocked-out servers, and, - A `tests/support.rs` module containing utility code factored out of the server tests, which are used in both sets of tests. I plan to add additional tests in subsequent PRs, but I thought it would be best to get these changes merged now. Test coverage (as reported by [tarpaulin]): ------------------------------------------ Before: ``` $ cargo tarpaulin -p tests --exclude-files tests/* --exclude-files tower-balance/* Coverage Results Tested/Total Lines: src/body.rs: 4/28 src/buf.rs: 13/15 src/client/background.rs: 0/8 src/client/connect.rs: 0/34 src/client/connection.rs: 0/95 src/flush.rs: 35/55 src/recv_body.rs: 2/44 src/server/mod.rs: 57/158 src/service.rs: 0/14 24.61% coverage, 111/451 lines covered Tarpaulin finished ``` After: ``` $ cargo tarpaulin -p tests --exclude-files tests/* --exclude-files tower-balance/* Coverage Results Tested/Total Lines: src/body.rs: 4/28 src/buf.rs: 13/15 src/client/background.rs: 8/8 src/client/connect.rs: 16/34 src/client/connection.rs: 28/95 src/flush.rs: 35/55 src/recv_body.rs: 24/44 src/server/mod.rs: 57/158 src/service.rs: 0/14 41.02% coverage, 185/451 lines covered Tarpaulin finished ``` Coverage diff: +16.41% [tarpaulin]: https://github.com/xd009642/tarpaulin Signed-off-by: Eliza Weisman <eliza@buoyant.io> Signed-off-by: Eliza Weisman <eliza@buoyant.io>
hawkw
force-pushed
the
eliza/generic-service
branch
from
cda9fbe
to
bead6a2
Compare
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
hawkw
force-pushed
the
eliza/generic-service
branch
from
bead6a2
to
548707c
Compare
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
This reverts commit d27d22a. @carllerche suggested this bound be removed as it is not required by the trait. Bounding the request body type requires all users of `HttpService` to _also_ have this bound. This makes using the trait more difficult. Signed-off-by: Eliza Weisman <eliza@buoyant.io>
|
Closing this as the change has already been made upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in tower-rs/tower#99, this tracks the prototype
tower-rschange (hawkw/tower#1) that makesService::Requestinto a type parameter, rather than an associated type.This PR is not necessarily intended to be merged, but is opened to allow the changes to be discussed and reviewed more easily.