Avoid throwing an error when deactivating package #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hopefully, this should:
… fix #23
… fix hax/js-refactor#18
… fix hax/js-refactor#16
|
@hax Please use specs. Seriously. They would've alerted you long ago that you were using a deprecated property (which has now been removed from Atom's API, hence this breakage). |
|
@Alhadis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating an issue with icon loading, I noticed this flash in my console very briefly when reloading the window:
I can't confirm if this is what's causing the sporadic failures reported in #16, but I do know that Atom loads packages synchronously... which means it's subject to race conditions. So if an error occurred while deactivating every package whilst updating, it could interfere with the reactivation of every other package.
That's my theory at least. Even if it doesn't solve this stupid issue, you should at least know you're using a property that was deprecated over two years ago.