Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All js.node.Os methods should be static #168

Closed
cedx opened this issue Jun 28, 2020 · 0 comments · Fixed by #169
Closed

All js.node.Os methods should be static #168

cedx opened this issue Jun 28, 2020 · 0 comments · Fixed by #169

Comments

@cedx
Copy link
Contributor

cedx commented Jun 28, 2020

The methods Os.tmpdir(), Os.totalmem(), and Os.type() are instance methods, whereas they should be static like all other methods.
See: https://github.com/HaxeFoundation/hxnodejs/blob/master/src/js/node/Os.hx#L132
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make static the instance methods of module js.node.Os
1 participant
@cedx