Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

392. Is Subsequence #64

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

392. Is Subsequence #64

wants to merge 3 commits into from

Conversation

hayashi-ay
Copy link
Owner

nodchip
nodchip reviewed Mar 26, 2024
View reviewed changes
392. Is Subsequence.md
```python
class Solution:
def isSubsequence(self, s: str, t: str) -> bool:
si = 0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

読みやすさを優先し、変数名に index という単語を含めたほうが良いと思います。

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます。s_index, t_indexみたいな感じですかね？

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

それでよいと思います。

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

私は、si, ti はこのサイズ(と変数の寿命)だったら許容ですね。

@rihib rihib mentioned this pull request Aug 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oda oda oda left review comments

@nodchip nodchip nodchip left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hayashi-ay @oda @nodchip