-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example udd.yaml for GitHub actions to automate pull-request #38
Comments
If you re-run when other PR is opened it will just create a new one. About, What should I use instead of Thanks! |
Hmm, I can't actually find the reference, I was sure GitHub had mentioned this in their initial annoucement of scheduled actions - perhaps it's no longer the case. The idea was that everyone shouldn't schedule their actions at the same time (which 0 0 is the obvious example), so as not to pressure GitHub and whatever services you are calling (in this case the deno cdns), it's better to spread the load across the day.
In the action-behaviour it doesn't actually include this case, but in the concepts diagram it suggests changes can be "force pushed to update" the branch - this makes sense in the case your explicitly name the branch. I guess there's another interesting question here: if the tests fail what is the desired behaviour.
I suspect 2. is preferable, which is to say, it's tempting to drop the Thanks again for this yml. |
It makes sense, in this case the time it happens is not very important so I could change it.
I think this would be the best.
I'm not sure about this, I prefer to have the ci and udd separated. The CI runs every time I push changes, I need it to finish as quickly as possible, to see if all my changes are correct and continue with new features. Whereas UDD I prefer that I run only once a day, preferably while I am not developing. It seems to me that the best thing would be for |
See #38 TODO add to README with explanation and thanks to UltiRequiem.
I think we're not quite following each other/getting wires crossed RE the I updated to https://github.com/hayd/deno-udd/blob/ab0112ff1c756e8c812e0e67dace39cb52fbc00e/.github/workflows/udd.yml #39 is working PR example, if we leave open a week then we should see it work over a new std release (but I am already convinced that it is working). Once that's merged I'll include mention of this (and your contribution) in the README. Thanks again! |
I understand you now.
Thanks! |
closing with #40. |
Nice |
@UltiRequiem put together this script to automates dependency updates. I think it would be really nice to include/publicize it in the udd repo:
https://github.com/UltiRequiem/deno_template/blob/main/.github/workflows/uud.yaml
Questions:
What happens if re-run and no merge since PR opened (does it update the PR or create a new one)?
Is the
$(find . -name "*.ts")
reasonable (Should this be better supported in udd itself?) ?Note: IIRC GitHub recommends not using 0 0 to avoid everyone using 0 0 😆 .
But overall this is really nice, thanks @UltiRequiem!
The text was updated successfully, but these errors were encountered: