Remove @sentry/tracing from @pothos/sentry-tracing #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 951988d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@penpendayo is attempting to deploy a commit to the Michael Hayes' projects Team on Vercel. A member of the Team first needs to authorize it. |
penpendayo
force-pushed
the
bugfix/sentry
branch
from
e39dc3c
to
951988d
Compare
|
Sorry about that, thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dependency on @sentry/tracing has been removed in this PR:
https://github.com/hayes/pothos/pull/1220/files#diff-ebc36762ab958f662687f4e52e77f8e99c4765d7bffea474d5936f2890f8e893L53
It seems it was mistakenly added during the v4 release:
https://github.com/hayes/pothos/pull/855/files#diff-ebc36762ab958f662687f4e52e77f8e99c4765d7bffea474d5936f2890f8e893R53
Since Sentry v8, @sentry/tracing has been removed, so it is correct to not have this dependency.