Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing no results message #17

Merged
merged 3 commits into from
Jul 29, 2023

Conversation

FullStackSorcerer
Copy link
Contributor

here you go!

@haypho
Copy link
Owner

haypho commented Jul 28, 2023

Hello! I know the README does not specify this, but would you kindly update your commit message following the Conventional Commit format 🙏 I have created issue #18 to update the README with those details

@FullStackSorcerer FullStackSorcerer changed the title fix/missing no results message fix: add missing no results message Jul 28, 2023
@haypho
Copy link
Owner

haypho commented Jul 28, 2023

You seemed to have updated the PR title, but the actual commit message needs to be updated and pushed. You can edit commits using the git commit --amend command. The commit should have a title (the one you changed in this PR should be fine) and a footer (i.e., Refs: #11).

components/SmiteGodCards.tsx Outdated Show resolved Hide resolved
@haypho haypho merged commit 67535c9 into haypho:main Jul 29, 2023
2 checks passed
@haypho
Copy link
Owner

haypho commented Jul 29, 2023

Looks good! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants