Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resources parameters for cpu/memory #34

Closed
mesutcelik opened this issue May 1, 2019 · 3 comments · Fixed by #40
Closed

resources parameters for cpu/memory #34

mesutcelik opened this issue May 1, 2019 · 3 comments · Fixed by #40

Comments

@mesutcelik
Copy link

I see from this link that we can define 4 parameters for cpu/memory but README only mentions resources with a default value nil
https://kubernetes.io/docs/concepts/configuration/manage-compute-resources-container/#resource-requests-and-limits-of-pod-and-container

resources.limits.cpu
resources.limits.memory
resources.requests.cpu
resources.requests.memory

README has to be fixed by adding all those 4 parameters with their default values.

@leszko
Copy link

leszko commented May 24, 2019

@mesutcelik I remember that one of the comments when we send a PR to the official repo was that we should not set any default values on resources, but keep them commented out (let user uncomment them if needed). That makes sense to me, because when you keep them nil by default then the values which are default for the Kubernetes cluster are used. Otherwise we would need to decide what are the default values for Hazelcast.

Wdyt?

@mesutcelik
Copy link
Author

mesutcelik commented May 24, 2019

That makes sense to me, because when you keep them nil by default then the values which are default for the Kubernetes cluster are used

I did not know that and the person who asked the question was not clear on that too. Good to know! Thanks.

Can we add all those 4 parameters to the table and put default instead of nil? The table only contains resources for now.

@leszko
Copy link

leszko commented May 24, 2019

Sure, sent as #40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants