-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resources parameters for cpu/memory #34
Comments
@mesutcelik I remember that one of the comments when we send a PR to the official repo was that we should not set any default values on resources, but keep them commented out (let user uncomment them if needed). That makes sense to me, because when you keep them Wdyt? |
I did not know that and the person who asked the question was not clear on that too. Good to know! Thanks. Can we add all those 4 parameters to the table and put |
Sure, sent as #40 |
I see from this link that we can define 4 parameters for cpu/memory but README only mentions
resources
with a default valuenil
https://kubernetes.io/docs/concepts/configuration/manage-compute-resources-container/#resource-requests-and-limits-of-pod-and-container
README has to be fixed by adding all those 4 parameters with their default values.
The text was updated successfully, but these errors were encountered: