Fix unused parameter warnings for all components #1138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
akeles85
reviewed
Mar 8, 2023
akeles85
reviewed
Mar 8, 2023
hazelcast/include/hazelcast/client/spi/impl/ClientExecutionServiceImpl.h
Outdated
Show resolved
Hide resolved
akeles85
reviewed
Mar 8, 2023
hazelcast/include/hazelcast/client/internal/nearcache/impl/store/BaseHeapNearCacheRecordStore.h
Outdated
Show resolved
Hide resolved
akeles85
reviewed
Mar 8, 2023
hazelcast/include/hazelcast/client/internal/nearcache/impl/store/NearCacheDataRecordStore.h
Outdated
Show resolved
Hide resolved
akeles85
reviewed
Mar 8, 2023
hazelcast/include/hazelcast/client/internal/nearcache/impl/store/NearCacheDataRecordStore.h
Outdated
Show resolved
Hide resolved
akeles85
reviewed
Mar 8, 2023
hazelcast/include/hazelcast/client/internal/nearcache/impl/store/NearCacheObjectRecordStore.h
Outdated
Show resolved
Hide resolved
akeles85
reviewed
Mar 8, 2023
hazelcast/include/hazelcast/client/internal/nearcache/impl/store/NearCacheObjectRecordStore.h
Outdated
Show resolved
Hide resolved
akeles85
reviewed
Mar 8, 2023
akeles85
reviewed
Mar 8, 2023
akeles85
reviewed
Mar 8, 2023
akeles85
reviewed
Mar 8, 2023
akeles85
reviewed
Mar 8, 2023
akeles85
suggested changes
Mar 8, 2023
There was a problem hiding this comment.
As a general rule, if a method is public API, we should have a strong reason to change it. If we change it, there might be compatibility issues with client code. In the light of this, I gave my comments for this PR. Could you please review my comments and do the appropriate changes?
|
verify |
|
By the way, could you please give the details about compiler options and compiler version in the description of PR? |
|
Linux test FAILed. |
|
Windows test FAILed. |
cngzhnp
force-pushed
the
fix_for_unused_parameters
branch
from
0ccbf3a
to
d45685a
Compare
|
verify |
|
Windows test PASSed. |
|
Linux test PASSed. |
akeles85
approved these changes
Mar 23, 2023
|
verify |
|
Linux test PASSed. |
|
Windows test PASSed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for unused parameter warnings that mentioned in previous PR. This patch also fixes #1137 as well.
C++ compiler version: GNU 12.2.0
Compiler options : "-Wunused"
Hazelcast Cpp client version: 5.1.0
Cluster size, i.e. the number of Hazelcast cluster members:
OS version (Windows/Linux/OSX): Linux