Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Hazelcast 3.11 #2

Merged

Conversation

googlielmo
Copy link
Contributor

Use Hazelcast Client from official hazelcast-all OSGi bundle.
Client Bundle Activator by @emre-aydin was moved to this repo, so we don't have to modify upstream Hazelcast code.

 - include client OSGi service for hazelcast
Copy link
Contributor

@emre-aydin emre-aydin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only a minor comment.

Copy link
Contributor

@mesutcelik mesutcelik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @googlielmo ,
Can you update readme with the compatible version of websphere liberty if not done yet?

 - Specify Liberty version in README
 - Update copyright year to 2019
@googlielmo
Copy link
Contributor Author

@mesutcelik @emre-aydin I addressed comments above

@mesutcelik
Copy link
Contributor

👍

@googlielmo googlielmo merged commit 12f2bbb into hazelcast:master Mar 5, 2019
@googlielmo
Copy link
Contributor Author

Fixes #1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants